[TLS] Comments on draft-ietf-tls-applayerprotoneg-03

John Mattsson <john.mattsson@ericsson.com> Mon, 04 November 2013 18:17 UTC

Return-Path: <john.mattsson@ericsson.com>
X-Original-To: tls@ietfa.amsl.com
Delivered-To: tls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EE88E11E820A for <tls@ietfa.amsl.com>; Mon, 4 Nov 2013 10:17:15 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.358
X-Spam-Level:
X-Spam-Status: No, score=-6.358 tagged_above=-999 required=5 tests=[AWL=-0.109, BAYES_00=-2.599, HELO_EQ_SE=0.35, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5zbvR3egWa-Z for <tls@ietfa.amsl.com>; Mon, 4 Nov 2013 10:17:10 -0800 (PST)
Received: from mailgw7.ericsson.se (mailgw7.ericsson.se [193.180.251.48]) by ietfa.amsl.com (Postfix) with ESMTP id CBEF711E8162 for <TLS@ietf.org>; Mon, 4 Nov 2013 10:17:05 -0800 (PST)
X-AuditID: c1b4fb30-b7eff8e000006d14-4d-5277e49e3f8d
Received: from ESESSHC014.ericsson.se (Unknown_Domain [153.88.253.124]) by mailgw7.ericsson.se (Symantec Mail Security) with SMTP id 57.13.27924.E94E7725; Mon, 4 Nov 2013 19:17:02 +0100 (CET)
Received: from ESESSMB307.ericsson.se ([169.254.7.88]) by ESESSHC014.ericsson.se ([153.88.183.60]) with mapi id 14.02.0328.009; Mon, 4 Nov 2013 19:17:01 +0100
From: John Mattsson <john.mattsson@ericsson.com>
To: "TLS@ietf.org" <TLS@ietf.org>
Thread-Topic: Comments on draft-ietf-tls-applayerprotoneg-03
Thread-Index: Ac7Zh9lj/ZIF1PUMQyaqF9nf3z7OeQ==
Date: Mon, 4 Nov 2013 18:17:01 +0000
Message-ID: <CAAB765F71FCD344B6BABC031C19EC490EE793@ESESSMB307.ericsson.se>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [153.88.183.154]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDLMWRmVeSWpSXmKPExsUyM+Jvje68J+VBBvOeiFh8Ot/F6MDosWTJ T6YAxigum5TUnMyy1CJ9uwSujIMHZjAVzOGqmPi1m7mBcQ1HFyMHh4SAicS8TeVdjJxAppjE hXvr2boYuTiEBA4xSsx+38YE4SxilOhb95odpIpNwEBi7p4GNpBmEQFFiU+fs0HCwgLmEicu H2ABsUUEbCQuft/PCGHrSdz8/RTMZhFQkZj69wU7SCuvgLfEh7lBIGFGoL3fT61hArGZBcQl bj2ZzwRxj4DEkj3nmSFsUYmXj/+xQthKEotuf4aq15O4MXUKG4StLbFs4Wuwel4BQYmTM5+w TGAUnoVk7CwkLbOQtMxC0rKAkWUVI3tuYmZOern5JkZgCB/c8ttgB+Om+2KHGKU5WJTEeT+8 dQ4SEkhPLEnNTk0tSC2KLyrNSS0+xMjEwSnVwLgg//mH5l8HSo6anZBN7DhZ9dX+9sonitqu nM+9y92XVu4W+aff/vGQsbTfsh1z+yfGRx5If6ou+Fv65j+x/O5oDdX5va8/7tl0pTKVS+rP oSv58cV39e/OMTu74nzv1mMirs43tkpkCT9863Pkgg/7/e8v4wIUS6KXOBVfOnvKxEyd3732 XpkSS3FGoqEWc1FxIgAKp8LqLwIAAA==
Subject: [TLS] Comments on draft-ietf-tls-applayerprotoneg-03
X-BeenThere: tls@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "This is the mailing list for the Transport Layer Security working group of the IETF." <tls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tls>, <mailto:tls-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/tls>
List-Post: <mailto:tls@ietf.org>
List-Help: <mailto:tls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tls>, <mailto:tls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Nov 2013 18:17:16 -0000

Hi, 

Some minor comments on draft-ietf-tls-applayerprotoneg-03

/John

- [Section 3.1]
"Implementations MUST ensure that an empty string is not included and that no byte strings are truncated."

How does an implementation differentiate between the byte string "spdy/10" truncated to "spdy/1" and the non-truncated string "spdy/1"?  ;)

I assume what is meant is that the implementation MUST ensure that the length of protocol_name_list is correct. But isn't that already handled by RFC5246 for both client and server (which sends a decode_error)? I suggest to reformulate or remove.

- [Section 3.2]
Seems to be an extra line break that should be removed: 

enum {
    no_application_protocol(120), (255)
} AlertDescription;


------------------------------------------------------------------------------------
JOHN MATTSSON
MSc Engineering Physics, MSc Business Administration and Economics 
Senior Researcher, Security 

Ericsson AB
Security Research
Färögatan 6
SE-164 80 Stockholm, Sweden
Phone +46 10 71 43 501
SMS/MMS +46 76 11 53 501
john.mattsson@ericsson.com
www.ericsson.com




This Communication is Confidential. We only send and receive email on the basis of the terms set out at www.ericsson.com/email_disclaimer