[TLS] Gen-ART Review of draft-ietf-tls-session-hash-04

Russ Housley <housley@vigilsec.com> Tue, 07 April 2015 17:16 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: expand-draft-ietf-tls-session-hash.all@virtual.ietf.org
Delivered-To: tls@ietfa.amsl.com
Received: by ietfa.amsl.com (Postfix, from userid 65534) id 4C4121A8ADA; Tue, 7 Apr 2015 10:16:00 -0700 (PDT)
X-Original-To: xfilter-draft-ietf-tls-session-hash.all@ietfa.amsl.com
Delivered-To: xfilter-draft-ietf-tls-session-hash.all@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2AA9B1A8AAC; Tue, 7 Apr 2015 10:16:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -101.9
X-Spam-Level:
X-Spam-Status: No, score=-101.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, USER_IN_WHITELIST=-100] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bw9xHqpFPie2; Tue, 7 Apr 2015 10:15:58 -0700 (PDT)
Received: from odin.smetech.net (x-bolt-wan.smeinc.net [209.135.219.146]) by ietfa.amsl.com (Postfix) with ESMTP id 5F65E1A8AA4; Tue, 7 Apr 2015 10:15:58 -0700 (PDT)
Received: from localhost (unknown [209.135.209.5]) by odin.smetech.net (Postfix) with ESMTP id 4C0DA9A401B; Tue, 7 Apr 2015 13:15:47 -0400 (EDT)
X-Virus-Scanned: amavisd-new at smetech.net
Received: from odin.smetech.net ([209.135.209.4]) by localhost (ronin.smeinc.net [209.135.209.5]) (amavisd-new, port 10024) with ESMTP id 5DOMM2ln+cyH; Tue, 7 Apr 2015 13:15:26 -0400 (EDT)
Received: from [192.168.2.100] (pool-96-255-133-185.washdc.fios.verizon.net [96.255.133.185]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by odin.smetech.net (Postfix) with ESMTP id 45CBF9A4015; Tue, 7 Apr 2015 13:15:26 -0400 (EDT)
From: Russ Housley <housley@vigilsec.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Date: Tue, 07 Apr 2015 13:15:15 -0400
Message-Id: <BD4B0CCF-D52D-4060-8065-6FA41DB2D7CC@vigilsec.com>
To: draft-ietf-tls-session-hash.all@ietf.org
Mime-Version: 1.0 (Apple Message framework v1085)
X-Mailer: Apple Mail (2.1085)
Archived-At: <http://mailarchive.ietf.org/arch/msg/tls/UYmVYMLBr4ctAoMsQwQ6pjlDL4Y>
X-Mailman-Approved-At: Wed, 08 Apr 2015 06:25:27 -0700
Cc: IETF Gen-ART <gen-art@ietf.org>, IETF <ietf@ietf.org>
Subject: [TLS] Gen-ART Review of draft-ietf-tls-session-hash-04
X-BeenThere: tls@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "This is the mailing list for the Transport Layer Security working group of the IETF." <tls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tls>, <mailto:tls-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/tls/>
List-Post: <mailto:tls@ietf.org>
List-Help: <mailto:tls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tls>, <mailto:tls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Apr 2015 17:16:00 -0000

I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

This review is in response to a request for early Gen-ART review.

Document: draft-ietf-tls-session-hash-04
Reviewer: Russ Housley
Review Date: 2015-04-01
IETF LC End Date: 2015-04-13
IESG Telechat date: unknown

Summary: Ready


Major Concerns:

None


Minor Concerns:

The most recent RFC Editor style guide places normative and informative
references in top-level sections.  In this document, the normative
references should be Section 9, and the informative references should
be in a new Section 10.


Other Comments:

For absolute clarity, I suggest a small addition to Section 5.1.  It
says: "Thus, the entire encoding of the extension is 00 17 00 00."
I would add to the end of the sentence: "(in hexadecimal)".

Typo correction in Section 6.3: "sent by the server/".  Please replace
the slash with a period.