Re: [TLS] Finished stuffing/PSK Binders

Eric Rescorla <ekr@rtfm.com> Wed, 12 October 2016 02:48 UTC

Return-Path: <ekr@rtfm.com>
X-Original-To: tls@ietfa.amsl.com
Delivered-To: tls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 17A8E129436 for <tls@ietfa.amsl.com>; Tue, 11 Oct 2016 19:48:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=rtfm-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zNZAtb3fhUiG for <tls@ietfa.amsl.com>; Tue, 11 Oct 2016 19:48:46 -0700 (PDT)
Received: from mail-yb0-x234.google.com (mail-yb0-x234.google.com [IPv6:2607:f8b0:4002:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4B4F6129408 for <tls@ietf.org>; Tue, 11 Oct 2016 19:48:46 -0700 (PDT)
Received: by mail-yb0-x234.google.com with SMTP id 184so15405150yby.2 for <tls@ietf.org>; Tue, 11 Oct 2016 19:48:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rtfm-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=kpJN8AOdXSc2x1bfyvwF9NANnFT4EhpfgM72+gMoXVg=; b=1R/Wg2N7yMAoUsLe69vZKcnYj+19lUiQEREl3PwEW+hsgNgWz3PdT4iV6oNh7APkUn OgthlpN1CqVyODbcdAGY+ejc2Uh/onduCdp20dSJ0wo4ZqYAviYuR1usLeem6xanHutD pq2uhc8hdj6cRIItbkegec12Ie1lzzH7NITxG4iEv+f2mn/oSrmEaXsE9rKoEcxoSskt QCK6aGCLlQ5QrE6oh0BiQkoY01AH2EkOFGEcXKUDopLxcHdwvad3oQMKXAFEQT+emtJk usB9nq8wKhCB/egSQHgNdjsNN2XBBmtmpCe19gRTx7SGAiUAmmtwoCQ/zFSO103g09PB GvVQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kpJN8AOdXSc2x1bfyvwF9NANnFT4EhpfgM72+gMoXVg=; b=kRvY0E3RvWpKHj2WFKp6fkm+FcPXusTzb01ibpYN9yNoBA28lchnhtT4xrZ3lpq2sE U1GdLxKGxM5lcsLRWbfxjIm1Yqw1KoxWillhSIY5//XcLb+bGhY+LHl8xx0lZ8XinK8Y YUPZ54oINwaL1lMcqFNsT63FCYb9ZPRVWr9Ik71OTXMQ97+zavmXKeWGpmf4pb6j/AzA 9F7nwvupYMSKci26pPdAL7+DhZ+ldZ4k/pZIQi2MF3VDcMV70MGGXttTZAHLI5lhNCsy 9JmGv/It+H3MrkLcCfCsqIPUyP3OoG81EmqCrMssqJcbonZH8Ftdm8b/BDVYwW9jslBy ar2g==
X-Gm-Message-State: AA6/9Rk8ZWa04qgY2gG2k2hBp03vPf2ZZaVaL5JBKtVAnGj71V7Lon2FoinP3C3RMDikqg2iG3UeA7TGXzFBnA==
X-Received: by 10.37.174.11 with SMTP id a11mr6129188ybj.180.1476240525543; Tue, 11 Oct 2016 19:48:45 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.129.75.212 with HTTP; Tue, 11 Oct 2016 19:48:05 -0700 (PDT)
In-Reply-To: <CABkgnnWC18Q+wxERnEgKLF_tjjYAmJB__32ci-hbHPuGUq162A@mail.gmail.com>
References: <CABcZeBOJPz8DY92LE6531xbRYLU-Wvkqeb-vTX59gU5rYcp+Ww@mail.gmail.com> <20161009135817.GA13000@LK-Perkele-V2.elisa-laajakaista.fi> <CABcZeBNjVbFinq8oH5UrQRSa6FpGBiOXj8WB_X0PncZvz49zDA@mail.gmail.com> <CABcZeBNJokdTHJLkWWx22AtW+4qWRjZtzh5JuviVuJcwbcmnTA@mail.gmail.com> <CABkgnnWC18Q+wxERnEgKLF_tjjYAmJB__32ci-hbHPuGUq162A@mail.gmail.com>
From: Eric Rescorla <ekr@rtfm.com>
Date: Tue, 11 Oct 2016 19:48:05 -0700
Message-ID: <CABcZeBMtYyL9+8=qD-rJo5tigx6qQZGorVS0fvGMmAttG5j=Zw@mail.gmail.com>
To: Martin Thomson <martin.thomson@gmail.com>
Content-Type: multipart/alternative; boundary=f403045db83e2109bc053ea20826
Archived-At: <https://mailarchive.ietf.org/arch/msg/tls/e74QD_Ojr4hd4FdILYuzAknsK4o>
Cc: "tls@ietf.org" <tls@ietf.org>
Subject: Re: [TLS] Finished stuffing/PSK Binders
X-BeenThere: tls@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "This is the mailing list for the Transport Layer Security working group of the IETF." <tls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tls>, <mailto:tls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tls/>
List-Post: <mailto:tls@ietf.org>
List-Help: <mailto:tls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tls>, <mailto:tls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Oct 2016 02:48:48 -0000

Thanks, I'll look at this. I'll be merging this change (modulo your
comments) Friday unless there is significant objection.

-Ekr


On Tue, Oct 11, 2016 at 5:16 PM, Martin Thomson <martin.thomson@gmail.com>;
wrote:

> On 12 October 2016 at 00:51, Eric Rescorla <ekr@rtfm.com>; wrote:
> > See:
> > https://github.com/tlswg/tls13-spec/pull/678
>
> I'm convinced that this is the right change.  Reconstruction was
> always going to be brittle.  I will note that I don't think that the
> change gets the error codes right though.  I explained why on the PR.
>