IETF Logo Mail Archive

Re: [TLS] draft-ietf-tls-tls13-21 posted

Kazu Yamamoto ( 山本和彦 ) <kazu@iij.ad.jp> Thu, 06 July 2017 04:06 UTC

Return-Path: <kazu@iij.ad.jp>
X-Original-To: tls@ietfa.amsl.com
Delivered-To: tls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ED5F7129AF6 for <tls@ietfa.amsl.com>; Wed, 5 Jul 2017 21:06:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.002
X-Spam-Level:
X-Spam-Status: No, score=-2.002 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=iij.ad.jp
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n3PxO7vIK1OL for <tls@ietfa.amsl.com>; Wed, 5 Jul 2017 21:06:29 -0700 (PDT)
Received: from omgo.iij.ad.jp (mo900.iij.ad.jp [202.232.31.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 864511243FE for <tls@ietf.org>; Wed, 5 Jul 2017 21:06:29 -0700 (PDT)
DKIM-Signature: v=1;a=rsa-sha256;c=relaxed/simple;d=iij.ad.jp;h=Date: Message-Id:To:Subject:From:In-Reply-To:References:Mime-Version:Content-Type: Content-Transfer-Encoding; i=kazu@iij.ad.jp; s=omgo2; t=1499313988; x=1500523588; bh=0YgcHpCw5EnH83qgr3vYNOj2Qh7RryMhKYVsdY4cHc8=; b=xtausyrX9VOGtEFjDAU38kbIxH3 9jdmBP15AH+Q6a4wX5eWWHqEaVvQbM5ob3bhRAULReJgFhjbNru7r3Dgj7Rbm/9A50WFbsHKRobzD pSzs9hBZx4cc23pmB8ndyHbIi4ne0JmOOAGryPBEYURR9sCSytz2I+1u3X/m3nLl1AdaXso5f4IdE WgMUUjRQe9KcMK1v86Ge/dDFFtluzpOSkOWh3wvaOg7XOranTKmYhTv1Aivn6faGe8H23cvvLj9y/ rJdv1T5ypeRSzjBPD0TxSdGpIC2FjDdnY719NRRncedQEqKiyeG3FDzELKkMmc3B1ARa1XtrVrIj8 zqomGQQ==;
Received: by omgo.iij.ad.jp (mo900) id v6646SoS024139; Thu, 6 Jul 2017 13:06:28 +0900
X-Iguazu-Qid: 33PuoJClv5tq0qEm80
Date: Thu, 06 Jul 2017 13:06:27 +0900
Message-Id: <20170706.130627.753481879086572434.kazu@iij.ad.jp>
To: tls@ietf.org
From: Kazu Yamamoto <kazu@iij.ad.jp>
In-Reply-To: <CABkgnnUpUXWTcYgjr7Wd5T9KZ=c+cpEUfrm9V_Vtwgi-RVgGGw@mail.gmail.com>
References: <CABcZeBMgYNAfjD6_mDCQ4OmvifEXXP6R_FzA6o5BCRPm78kj0Q@mail.gmail.com> <20170706.111918.990342802355467009.kazu@iij.ad.jp> <CABkgnnUpUXWTcYgjr7Wd5T9KZ=c+cpEUfrm9V_Vtwgi-RVgGGw@mail.gmail.com>
X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/tls/eodXa7cqRCXZwjBgcHIZnBcLE1Y>
Subject: Re: [TLS] draft-ietf-tls-tls13-21 posted
X-BeenThere: tls@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "This is the mailing list for the Transport Layer Security working group of the IETF." <tls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tls>, <mailto:tls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tls/>
List-Post: <mailto:tls@ietf.org>
List-Help: <mailto:tls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tls>, <mailto:tls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Jul 2017 04:06:32 -0000

>>        HKDF-Expand-Label(Secret, Label, *Value*, Length) =
>>             HKDF-Expand(Secret, HkdfLabel, Length)
>>
>>        struct {
>>            uint16 length = *Value.length*;
>>            opaque label<7..255> = "tls13 " + Label;
>>            opaque hash_value<0..255> = *Value*;
>>        } HkdfLabel;
> 
> Length is the size of the output, so you don't want to assign
> Value.length to that field in the struct.

Yes. I would remove the "length" field, too.

> Also, you forgot to rename hash_value in the struct.

You are right.

--Kazu

v2.23.0 | Report a Bug | By Email