[TLS] RE: Review of draft-santesson-tls-gssapi-03

Larry Zhu <lzhu@windows.microsoft.com> Tue, 18 September 2007 17:45 UTC

Return-path: <tls-bounces@lists.ietf.org>
Received: from [127.0.0.1] (helo=stiedprmman1.va.neustar.com) by megatron.ietf.org with esmtp (Exim 4.43) id 1IXh94-0003Hf-TQ; Tue, 18 Sep 2007 13:45:58 -0400
Received: from [10.91.34.44] (helo=ietf-mx.ietf.org) by megatron.ietf.org with esmtp (Exim 4.43) id 1IXh93-0003Cr-6v for tls@lists.ietf.org; Tue, 18 Sep 2007 13:45:57 -0400
Received: from mailb.microsoft.com ([131.107.115.215] helo=smtp.microsoft.com) by ietf-mx.ietf.org with esmtp (Exim 4.43) id 1IXh8v-0005HE-0z for tls@lists.ietf.org; Tue, 18 Sep 2007 13:45:55 -0400
Received: from tk5-exhub-c103.redmond.corp.microsoft.com (157.54.70.186) by TK5-EXGWY-E802.partners.extranet.microsoft.com (10.251.56.168) with Microsoft SMTP Server (TLS) id 8.1.177.2; Tue, 18 Sep 2007 10:45:21 -0700
Received: from tk5-exmlt-w602.wingroup.windeploy.ntdev.microsoft.com (157.54.70.14) by tk5-exhub-c103.redmond.corp.microsoft.com (157.54.70.186) with Microsoft SMTP Server id 8.1.177.1; Tue, 18 Sep 2007 10:45:20 -0700
Received: from NA-EXMSG-W601.wingroup.windeploy.ntdev.microsoft.com ([fe80::5efe:10.255.255.1]) by tk5-exmlt-w602.wingroup.windeploy.ntdev.microsoft.com ([::1]) with mapi; Tue, 18 Sep 2007 10:45:20 -0700
From: Larry Zhu <lzhu@windows.microsoft.com>
To: Simon Josefsson <simon@josefsson.org>
Date: Tue, 18 Sep 2007 10:45:20 -0700
Thread-Topic: Review of draft-santesson-tls-gssapi-03
Thread-Index: Acf5zU9BmeY3QOT9RJyvIMfdot1SIwATeXHw
Message-ID: <B78121AEC3DFC949BF5080E7BCDD79F4A1F9229632@NA-EXMSG-W601.wingroup.windeploy.ntdev.microsoft.com>
References: <87bqc9k3xy.fsf@mocca.josefsson.org> <B78121AEC3DFC949BF5080E7BCDD79F49BB7915A39@NA-EXMSG-W601.wingroup.windeploy.ntdev.microsoft.com> <87abrse6y9.fsf@mocca.josefsson.org> <B78121AEC3DFC949BF5080E7BCDD79F49D5D76A055@NA-EXMSG-W601.wingroup.windeploy.ntdev.microsoft.com> <87bqc0jsbm.fsf@mocca.josefsson.org>
In-Reply-To: <87bqc0jsbm.fsf@mocca.josefsson.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Spam-Score: -100.0 (---------------------------------------------------)
X-Scan-Signature: e8a67952aa972b528dd04570d58ad8fe
Cc: "tls@lists.ietf.org" <tls@lists.ietf.org>
Subject: [TLS] RE: Review of draft-santesson-tls-gssapi-03
X-BeenThere: tls@lists.ietf.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "This is the mailing list for the Transport Layer Security working group of the IETF." <tls.lists.ietf.org>
List-Unsubscribe: <https://www1.ietf.org/mailman/listinfo/tls>, <mailto:tls-request@lists.ietf.org?subject=unsubscribe>
List-Archive: <http://www1.ietf.org/pipermail/tls>
List-Post: <mailto:tls@lists.ietf.org>
List-Help: <mailto:tls-request@lists.ietf.org?subject=help>
List-Subscribe: <https://www1.ietf.org/mailman/listinfo/tls>, <mailto:tls-request@lists.ietf.org?subject=subscribe>
Errors-To: tls-bounces@lists.ietf.org

Simon wrote:
> A new handshake message type or just a new handshake message?  If the latter, I still think you need to discuss how implementations should react if they receive unsupported token_type's.  I look
> forwward to new text.

The former, it should be treated as a new handshake message type.

> > Assuming that, all your comments have been addressed to your
> > satisfactory, right?

> Yes I think so, although I may have opinions on how the issues are
> ultimately solved in later drafts.

Thanks for the positive acknowledgement.

--larry

-----Original Message-----
From: Simon Josefsson [mailto:simon@josefsson.org]
Sent: Tuesday, September 18, 2007 1:23 AM
To: Larry Zhu
Cc: tls@lists.ietf.org
Subject: Re: Review of draft-santesson-tls-gssapi-03

Larry Zhu <lzhu@windows.microsoft.com> writes:

> Simon Josefsson wrote:
>> do you think this is better? Thanks.
>
>> Ah, I see.  You fail to specify the size of the length field though.  I would prefer to make the token explicit though, by adding e.g.:
>>
>>        struct {
>>            opaque gss_api_data<0..2^32-1>;
>>        } GSSAPIExtensionData;
> The size of the length field is defined in section 2.3 of RFC3546. It is 2 in octets.

Ok, now I get it, thanks.

>> If you want to have this field, you need to specify how implementations
>> should behave if multiple TokenTransfer tokens are received during the
>> handshake and when only some of them contain supported token_type's.
>> Otherwise this structure can never be used in any future extension in a
>> reliable way.
>
> A new value would indicate a new handshake message. I would make this
> clear, hopefully that addresses your comments w.r.t. this point.

A new handshake message type or just a new handshake message?  If the
latter, I still think you need to discuss how implementations should
react if they receive unsupported token_type's.  I look forwward to new
text.

> Assuming that, all your comments have been addressed to your
> satisfactory, right?

Yes I think so, although I may have opinions on how the issues are
ultimately solved in later drafts.

/Simon


_______________________________________________
TLS mailing list
TLS@lists.ietf.org
https://www1.ietf.org/mailman/listinfo/tls