IETF Logo Mail Archive

[Tools-discuss] Re: make fix-lint in windows environment or integrate in github actions?

Martin Thomson <mt@lowentropy.net> Mon, 08 July 2024 22:59 UTC

Return-Path: <mt@lowentropy.net>
X-Original-To: tools-discuss@ietfa.amsl.com
Delivered-To: tools-discuss@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CF0B2C18DB8C for <tools-discuss@ietfa.amsl.com>; Mon, 8 Jul 2024 15:59:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.808
X-Spam-Level:
X-Spam-Status: No, score=-2.808 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=lowentropy.net header.b="gvM0FQt+"; dkim=pass (2048-bit key) header.d=messagingengine.com header.b="f5pPGH1c"
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VOv-gghuV6RU for <tools-discuss@ietfa.amsl.com>; Mon, 8 Jul 2024 15:59:15 -0700 (PDT)
Received: from fhigh4-smtp.messagingengine.com (fhigh4-smtp.messagingengine.com [103.168.172.155]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2C51DC16943A for <tools-discuss@ietf.org>; Mon, 8 Jul 2024 15:59:15 -0700 (PDT)
Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 6F11E114120E; Mon, 8 Jul 2024 18:59:14 -0400 (EDT)
Received: from imap41 ([10.202.2.91]) by compute6.internal (MEProxy); Mon, 08 Jul 2024 18:59:14 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lowentropy.net; h=cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1720479554; x=1720565954; bh=Hh/LfOzz+2 0kjIDpLxJKVxv+S8O0fSMun/U8A2q0tIk=; b=gvM0FQt+wprS0ss9Iml46li2MP pi+OY5jw62K0J81MZqmN3J/F8Az2ymCZqOP0mF1CX/6iwhQnNyr9BjVSkqvj7QZM q0MG46B6p3P+iTftqJE9HiOyGz3T9Nbec+4C/3xbKpIt3dq8x5+Pu3OhvbUAtC+f /xu3pNuiPo11/qY8+FqBS9yV9P6gVpjqsNFUwT9MZkGbj6R5wqzy4qAaq4LzxbMm zrf8v2+MTH96r3bSsKUnacHGvJawzAtMANG2B3GPV2WepX9+042+dADygeuM7cu2 qOrqXvvVFvAGFCy4GTggdBXwOsN1WWxqnSjvq2RrMChCAGxvgZW/yX9IHVxA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1720479554; x=1720565954; bh=Hh/LfOzz+20kjIDpLxJKVxv+S8O0 fSMun/U8A2q0tIk=; b=f5pPGH1cm1nT9WlJlTf+E1KBaAe3DMisAVnOTtTQeO/Z MaVtUY++YXcAkFiKz8WofQGAGBnp2vk41Pst4YF56INVFBOnl7BKIejHOuM5J3jM rBLDMXnUPn7n3sSirdXNKgmrplYmn36Mgk3SqKk0egvJpASg4BMPTss7xAPzReAP imjmocAfjPdYlYfzrmY1rf3qOXV/3N+jyvYgJDEjgCKvceHI5ZkG1Q5HUHRaKv9b IQb7FeWleJ8MTNsZWg9CPqaJMbiD0S3b/Zi8TgdO77JtLu8aiNvvcn1bYi9WhT25 rvRTajjvWPgCC5KMVAt+D50etH0N0jVIH9gmUxQOwg==
X-ME-Sender: <xms:QW-MZv5GeNTKyPE4oaxjNk_5EWnrCiS-3Xo3rdubcVCenrMYBI9pQw> <xme:QW-MZk6KHIWH7Z8Oa6aAFgL0VbyXnGR8HgW6Vz7mVDnQovRSyPjoS6jKf-IxjDxFl Y1GqgKZxvPMpfhxSWA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdekgdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkjghffffhvffutgesthdtre dtreertdenucfhrhhomhepfdforghrthhinhcuvfhhohhmshhonhdfuceomhhtsehlohif vghnthhrohhphidrnhgvtheqnecuggftrfgrthhtvghrnhephfeitddtveeihfejjefgve efuedugffgkeevkeehueeggeelveekveektdfhueeinecuffhomhgrihhnpehivghtfhdr ohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmtheslhhofigvnhhtrhhophihrdhnvght
X-ME-Proxy: <xmx:QW-MZmdPsWxX0wBbhmtQYEEGaANJ5edgcpd558z-KCW0eqng237FHg> <xmx:QW-MZgLFrF5OSqLLM1VP0QTuJlsjVm5Q9WWM4Ond_YWzCdePaO0dKg> <xmx:QW-MZjJyqx7J417ShyFmcLi1GADvqmUENo76TfpR7BE5ciEMRC_AEQ> <xmx:QW-MZpwnlzqKLsySINYKlbDMlStHWjXwBmoa1y1Vuan71XomHE8ISg> <xmx:Qm-MZpiuQlV7PwHIygom2zRsng-D4P9-EuJQYE5E_9nTCzZ0oOeiOlkN>
Feedback-ID: ic129442d:Fastmail
Received: by mailuser.nyi.internal (Postfix, from userid 501) id 40F2A2340080; Mon, 8 Jul 2024 18:59:13 -0400 (EDT)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.11.0-alpha0-568-g843fbadbe-fm-20240701.003-g843fbadb
MIME-Version: 1.0
Message-Id: <5f1c1574-0a18-4784-b987-26ce1f10f7fd@betaapp.fastmail.com>
In-Reply-To: <a6d7f21d3a974d658ea990d88f1ffad3@huawei.com>
References: <a6d7f21d3a974d658ea990d88f1ffad3@huawei.com>
Date: Tue, 09 Jul 2024 08:58:48 +1000
From: Martin Thomson <mt@lowentropy.net>
To: "Liuchunchi(Peter)" <liuchunchi=40huawei.com@dmarc.ietf.org>, "tools-discuss@ietf.org" <tools-discuss@ietf.org>
Content-Type: text/plain
Message-ID-Hash: OUBZJW5ZAPNEOUBQ4EMAETQ656T3Y6XE
X-Message-ID-Hash: OUBZJW5ZAPNEOUBQ4EMAETQ656T3Y6XE
X-MailFrom: mt@lowentropy.net
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-tools-discuss.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [Tools-discuss] Re: make fix-lint in windows environment or integrate in github actions?
List-Id: IETF Tools Discussion <tools-discuss.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/tools-discuss/DSeTdeFVGPVxjz-EGzLbnZ13Hbo>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tools-discuss>
List-Help: <mailto:tools-discuss-request@ietf.org?subject=help>
List-Owner: <mailto:tools-discuss-owner@ietf.org>
List-Post: <mailto:tools-discuss@ietf.org>
List-Subscribe: <mailto:tools-discuss-join@ietf.org>
List-Unsubscribe: <mailto:tools-discuss-leave@ietf.org>

Maybe add a .github/workflows/fix.yml file as follows:

name: "Fix Lints"
on: workflow_dispatch

jobs:
  build:
    name: "Update Files"
    runs-on: ubuntu-latest
    steps:
    - name: "Checkout"
      uses: actions/checkout@v4

    - name: "Fix Lints"
      uses: martinthomson/i-d-template@v1
      with:
        make: fix-lint
        token: ${{ github.token }}

    - name: "Push Fixes"
      run: git push

On Sun, Jul 7, 2024, at 19:35, Liuchunchi(Peter) wrote:
> Hi guys,
> 
> When using IETF github repo template, I wonder if we can use `make 
> fix-lint` in windows. I ran into a lot of install problems so I guess 
> it is a no. Switching between windows and mac is slightly inconvenient.
> 
> Simpler question, is it able to run `make fix-lint` in github actions 
> to auto-fix small problems while compiling? 
> 
> Best regards,
> Peter (Chunchi) Liu
> 
> -----------------------------------------------
> Tools-discuss mailing list -- tools-discuss@ietf.org
> To unsubscribe send an email to tools-discuss-leave@ietf.org
> https://mailarchive.ietf.org/arch/browse/tools-discuss/

v2.35.0 | Report a Bug | By Email | System Status