[Tools-discuss] Re: make fix-lint in windows environment or integrate in github actions?
Carsten Bormann <cabo@tzi.org> Tue, 09 July 2024 02:40 UTC
Return-Path: <cabo@tzi.org>
X-Original-To: tools-discuss@ietfa.amsl.com
Delivered-To: tools-discuss@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A20BAC180B6E for <tools-discuss@ietfa.amsl.com>; Mon, 8 Jul 2024 19:40:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.198
X-Spam-Level:
X-Spam-Status: No, score=-4.198 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VyqiMsCOEIdh for <tools-discuss@ietfa.amsl.com>; Mon, 8 Jul 2024 19:40:47 -0700 (PDT)
Received: from smtp.zfn.uni-bremen.de (smtp.zfn.uni-bremen.de [134.102.50.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6C6C3C180B7B for <tools-discuss@ietf.org>; Mon, 8 Jul 2024 19:40:43 -0700 (PDT)
Received: from clients-pool6-0352.vpn.uni-bremen.de (clients-pool6-0352.vpn.uni-bremen.de [134.102.91.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.zfn.uni-bremen.de (Postfix) with ESMTPSA id 4WJ4wk03H0zDCbx; Tue, 9 Jul 2024 04:40:37 +0200 (CEST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
From: Carsten Bormann <cabo@tzi.org>
In-Reply-To: <7f39d1a2-1957-412b-b401-37d0901733a3@betaapp.fastmail.com>
Date: Tue, 09 Jul 2024 04:40:37 +0200
X-Mao-Original-Outgoing-Id: 742185637.5609879-98d18d2f054d54e20932da4722b65897
Content-Transfer-Encoding: quoted-printable
Message-Id: <BBA72E7A-1F94-4D36-8955-AE2A36A5EA97@tzi.org>
References: <a6d7f21d3a974d658ea990d88f1ffad3@huawei.com> <5f1c1574-0a18-4784-b987-26ce1f10f7fd@betaapp.fastmail.com> <1F333F06-B64E-4459-892D-64315B4A81B9@tzi.org> <7f39d1a2-1957-412b-b401-37d0901733a3@betaapp.fastmail.com>
To: Martin Thomson <mt@lowentropy.net>
X-Mailer: Apple Mail (2.3608.120.23.2.7)
Message-ID-Hash: TK2OCOXY6WVHZCYAAEIM3E4WKANHAPIR
X-Message-ID-Hash: TK2OCOXY6WVHZCYAAEIM3E4WKANHAPIR
X-MailFrom: cabo@tzi.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-tools-discuss.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "Liuchunchi(Peter)" <liuchunchi=40huawei.com@dmarc.ietf.org>, "tools-discuss@ietf.org" <tools-discuss@ietf.org>
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [Tools-discuss] Re: make fix-lint in windows environment or integrate in github actions?
List-Id: IETF Tools Discussion <tools-discuss.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/tools-discuss/STzO0W0yYBlkKb0tS8-q4sUSIJ8>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tools-discuss>
List-Help: <mailto:tools-discuss-request@ietf.org?subject=help>
List-Owner: <mailto:tools-discuss-owner@ietf.org>
List-Post: <mailto:tools-discuss@ietf.org>
List-Subscribe: <mailto:tools-discuss-join@ietf.org>
List-Unsubscribe: <mailto:tools-discuss-leave@ietf.org>
On 2024-07-09, at 03:56, Martin Thomson <mt@lowentropy.net> wrote: > > On Tue, Jul 9, 2024, at 11:25, Carsten Bormann wrote: >> On 2024-07-09, at 00:58, Martin Thomson <mt@lowentropy.net> wrote: >>> >>> Maybe add a .github/workflows/fix.yml file as follows: >> >> That doesn’t help if the lint prevents me from committing and pushing >> things to github in the first place. > > Nothing stops you from pushing. Yes, this installs a precommit hook, but that is easy to override with `git commit -n`. Sure, but is pushing linty stuff into the repo to get fixed, the mode of operation we want to encourage? > Besides, many people find that the precommit hook is not installed or active on their typical workflows. (True, it only ever works when it then also gets in the way :-) Of course, in emacs it’s a simple M-x delete-trailing-whitespace RET, but the commit block still disrupts the flow. (And don’t forget keeping the default value of mode-require-final-newline and delete-trailing-lines, plus an indent-tabs-mode set to nil.) Grüße, Carsten
- [Tools-discuss] make fix-lint in windows environm… Liuchunchi(Peter)
- [Tools-discuss] Re: make fix-lint in windows envi… Martin Thomson
- [Tools-discuss] Re: make fix-lint in windows envi… Carsten Bormann
- [Tools-discuss] Re: make fix-lint in windows envi… Michael Richardson
- [Tools-discuss] Re: make fix-lint in windows envi… Martin Thomson
- [Tools-discuss] Re: make fix-lint in windows envi… Carsten Bormann