IETF Logo Mail Archive

[Tools-discuss] Re: make fix-lint in windows environment or integrate in github actions?

Martin Thomson <mt@lowentropy.net> Tue, 09 July 2024 01:57 UTC

Return-Path: <mt@lowentropy.net>
X-Original-To: tools-discuss@ietfa.amsl.com
Delivered-To: tools-discuss@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3EBD0C1F45B8 for <tools-discuss@ietfa.amsl.com>; Mon, 8 Jul 2024 18:57:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.108
X-Spam-Level:
X-Spam-Status: No, score=-7.108 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=lowentropy.net header.b="ZOQfEDcr"; dkim=pass (2048-bit key) header.d=messagingengine.com header.b="i6TNCq5y"
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fnY1CuITdiEA for <tools-discuss@ietfa.amsl.com>; Mon, 8 Jul 2024 18:57:18 -0700 (PDT)
Received: from fout1-smtp.messagingengine.com (fout1-smtp.messagingengine.com [103.168.172.144]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 927C3C1D4A98 for <tools-discuss@ietf.org>; Mon, 8 Jul 2024 18:57:18 -0700 (PDT)
Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.nyi.internal (Postfix) with ESMTP id 990071381100; Mon, 8 Jul 2024 21:57:17 -0400 (EDT)
Received: from imap41 ([10.202.2.91]) by compute6.internal (MEProxy); Mon, 08 Jul 2024 21:57:17 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lowentropy.net; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm3; t=1720490237; x=1720576637; bh=mXdzahHazO/eiF7qC+5NdAgvYD3Yxhpn 2cJOpjZ5Ok4=; b=ZOQfEDcrowrerB7Y+wdW8aHgrhYmkzOr3BsnH+gD1D00IgeB WjZpptvifEIRiADcyxMwqU8cFxTrG00RMrv0jLfcNil1I/dYdww4xg1uS8aTwdFg koJ9wtDRKnfFT94VwyGHiBdmgb48oRQSUA++dBXAdxh3xptSYsJfiFsJ7iIosMsD YMlXOYO9GzUelDA1e+uO2YAM8dHZX8Q2oGjK1AR8BO068xM2Sq0hWKLo7Z+efy6i yeqwT48cChPIBRMktDdl3hQhjyRZeg6HxKdtH9f+DDiNhMImrbc6q13WRHcu3CxZ 8s69w9GfC0SIwP1+JJvflL4MtqNI4kKAlDxgAw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1720490237; x= 1720576637; bh=mXdzahHazO/eiF7qC+5NdAgvYD3Yxhpn2cJOpjZ5Ok4=; b=i 6TNCq5yNGFT6KoNUSS6M4RgF75q/hNO/OGxiakNN4TwqyKehqcvu8rCJdxaPkVhL c/kKq8lJ32F4d4yopIwqcSJX1zgsAXF8w94Iga2vN4vqRbYFRY2SJO3LYTmhWVH6 gFOy/R/azdDbiWtadgmPU60bHJruNh9iyWsM3TzmGcx45mnIN0zW2eHt649wh4Hw aNRAeJlehFDKiMwICTiE3aztDrDwHr4C9qzc0mIER09kvCOIjy5ZXZi6MtBHQ7mQ pRp3NVWUBZY7dB/bxRKEKTtHAc17OL60305iyS5qFPk8TvRu/M3sN1v5YxVc5N1z AbC7KP9uwta7+Veo1fMcw==
X-ME-Sender: <xms:_JiMZtW55xyUrA7mKijY4Ti6RO9O7b7-qZwJF7o7BMikZZozseo1gg> <xme:_JiMZtmZ8c17bXjGQJ6QMtsgv3u7I0D5YhdX71Vh-rcW1mnR76LJIIs41uBc0tAZ4 CY6edsZRoPZWWQmmMA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdekgdehvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgfgsehtqhertderreejnecuhfhrohhmpedfofgr rhhtihhnucfvhhhomhhsohhnfdcuoehmtheslhhofigvnhhtrhhophihrdhnvghtqeenuc ggtffrrghtthgvrhhnpeejtddvkeegiefhtddvffffheeiteegvdetleefieetieeiudek geegieektedujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehmtheslhhofigvnhhtrhhophihrdhnvght
X-ME-Proxy: <xmx:_JiMZpbPg7lk7GZsE9NbXB2Sf6DequsQyCpBKZmO2YNOCaxiSPF2VA> <xmx:_JiMZgWTyyBScoN9yT-dm8IePqfFjIboqKPbaMYgYXT4EIjiUpeQsw> <xmx:_JiMZnnbo_dBwcfb2RB_norfkpLPJwhijyhb8dR4I3t6es7znw8s-Q> <xmx:_JiMZtfEZWqKZ0fBAjE_GAeD4-Uw8J0I-YhqX0umRbgipkTP98R5Iw> <xmx:_ZiMZsx-t010hVS3AehEFb4RyikCk0jnLnu31FliGtHXoGa7nQ53Gdwu>
Feedback-ID: ic129442d:Fastmail
Received: by mailuser.nyi.internal (Postfix, from userid 501) id 677162340081; Mon, 8 Jul 2024 21:57:16 -0400 (EDT)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.11.0-alpha0-568-g843fbadbe-fm-20240701.003-g843fbadb
MIME-Version: 1.0
Message-Id: <7f39d1a2-1957-412b-b401-37d0901733a3@betaapp.fastmail.com>
In-Reply-To: <1F333F06-B64E-4459-892D-64315B4A81B9@tzi.org>
References: <a6d7f21d3a974d658ea990d88f1ffad3@huawei.com> <5f1c1574-0a18-4784-b987-26ce1f10f7fd@betaapp.fastmail.com> <1F333F06-B64E-4459-892D-64315B4A81B9@tzi.org>
Date: Tue, 09 Jul 2024 11:56:57 +1000
From: Martin Thomson <mt@lowentropy.net>
To: Carsten Bormann <cabo@tzi.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Message-ID-Hash: S5HLNEHLS4ABL4ZQ4QGOKKXXIL7P53WO
X-Message-ID-Hash: S5HLNEHLS4ABL4ZQ4QGOKKXXIL7P53WO
X-MailFrom: mt@lowentropy.net
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-tools-discuss.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "Liuchunchi(Peter)" <liuchunchi=40huawei.com@dmarc.ietf.org>, "tools-discuss@ietf.org" <tools-discuss@ietf.org>
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [Tools-discuss] Re: make fix-lint in windows environment or integrate in github actions?
List-Id: IETF Tools Discussion <tools-discuss.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/tools-discuss/jsKU26bhr7FCbTU6qYo9Tcox42A>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tools-discuss>
List-Help: <mailto:tools-discuss-request@ietf.org?subject=help>
List-Owner: <mailto:tools-discuss-owner@ietf.org>
List-Post: <mailto:tools-discuss@ietf.org>
List-Subscribe: <mailto:tools-discuss-join@ietf.org>
List-Unsubscribe: <mailto:tools-discuss-leave@ietf.org>

On Tue, Jul 9, 2024, at 11:25, Carsten Bormann wrote:
> On 2024-07-09, at 00:58, Martin Thomson <mt@lowentropy.net> wrote:
>> 
>> Maybe add a .github/workflows/fix.yml file as follows:
>
> That doesn’t help if the lint prevents me from committing and pushing 
> things to github in the first place.

Nothing stops you from pushing.  Yes, this installs a precommit hook, but that is easy to override with `git commit -n`.  Besides, many people find that the precommit hook is not installed or active on their typical workflows.

v2.35.0 | Report a Bug | By Email | System Status