Re: [tram] Fwd: New Version Notification for draft-johnston-tram-stun-origin-01.txt

Alan Johnston <alan.b.johnston@gmail.com> Fri, 07 February 2014 20:51 UTC

Return-Path: <alan.b.johnston@gmail.com>
X-Original-To: tram@ietfa.amsl.com
Delivered-To: tram@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 624DD1AD34C for <tram@ietfa.amsl.com>; Fri, 7 Feb 2014 12:51:34 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, MIME_QP_LONG_LINE=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3gXFPRe-XnEQ for <tram@ietfa.amsl.com>; Fri, 7 Feb 2014 12:51:31 -0800 (PST)
Received: from mail-ie0-x232.google.com (mail-ie0-x232.google.com [IPv6:2607:f8b0:4001:c03::232]) by ietfa.amsl.com (Postfix) with ESMTP id 7A4361A0459 for <tram@ietf.org>; Fri, 7 Feb 2014 12:51:31 -0800 (PST)
Received: by mail-ie0-f178.google.com with SMTP id x13so1920592ief.23 for <tram@ietf.org>; Fri, 07 Feb 2014 12:51:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=lhZUD0Ar1fTQd6YPvcbzhi+52pftcMHgpqmFvnFxqoY=; b=i4cmxsvHw8pA62xjMc/ewxJtSmUc7eCMQmZrIa30SKz82Oi9MvGlYpy1JYuqB9OqWe vnVR8f7ZUuwsr6/gq8vWts7fyfNSSc94VN4ShyQghUVKYT5Zt0RCgTdsU7R/3ddK9z4d 9vcxNDY417xiqEWX3ginQX3IATwl5HSMpmQQ3IpyNx9FLKP4jxMX/I6UdcxpbSi9f6Zh helf0FKIeNUL45gAH+zL38/4gexnpsjrPomYV3ebgZIoTAdL/GOW66iqa5vpDPnkgie8 SSa4io837dPHiGRsYWiSsyvzk7MU9B2MiZKaNXpZlo4HcuwBHPSugU6eFyWT8W8aZlWu YwNQ==
X-Received: by 10.50.154.102 with SMTP id vn6mr2034384igb.1.1391806291169; Fri, 07 Feb 2014 12:51:31 -0800 (PST)
Received: from [10.147.9.141] ([166.170.23.4]) by mx.google.com with ESMTPSA id kz4sm13266576igb.4.2014.02.07.12.51.29 for <multiple recipients> (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 07 Feb 2014 12:51:29 -0800 (PST)
Content-Type: multipart/alternative; boundary="Apple-Mail-CF277EB6-309A-471E-AC4B-83E49342E844"
Mime-Version: 1.0 (1.0)
From: Alan Johnston <alan.b.johnston@gmail.com>
X-Mailer: iPhone Mail (11B554a)
In-Reply-To: <CAP8pQQvhBqaV9zMqHw+Ntuy593fs9VJ398bKhVZxf7ioDy=-jA@mail.gmail.com>
Date: Fri, 07 Feb 2014 15:51:26 -0500
Content-Transfer-Encoding: 7bit
Message-Id: <7DD62C46-F124-4116-80F5-84AE708E9BCE@gmail.com>
References: <20140206202155.28963.48259.idtracker@ietfa.amsl.com> <CAKhHsXGcewhs6mk8PRVXeUB9BFwDRM0xZ297rckU+H4jjy819A@mail.gmail.com> <52F4E7FA.70600@viagenie.ca> <CAP8pQQvnEFmE1xrM_=a1dVMhd5acH_whRrdGRZq=-hoUig1DuA@mail.gmail.com> <CAP8pQQvhBqaV9zMqHw+Ntuy593fs9VJ398bKhVZxf7ioDy=-jA@mail.gmail.com>
To: John Selbie <john@selbie.com>
Cc: Simon Perreault <simon.perreault@viagenie.ca>, "tram@ietf.org" <tram@ietf.org>
Subject: Re: [tram] Fwd: New Version Notification for draft-johnston-tram-stun-origin-01.txt
X-BeenThere: tram@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "Discussing the creation of a Turn Revised And Modernized \(TRAM\) WG, which goal is to consolidate the various initiatives to update TURN and STUN." <tram.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tram>, <mailto:tram-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/tram/>
List-Post: <mailto:tram@ietf.org>
List-Help: <mailto:tram-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tram>, <mailto:tram-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Feb 2014 20:51:34 -0000

John,

Appreciate the detailed feedback. We will make sure to clarify and highlight these issues in the next version. 

- Alan -


> On Feb 7, 2014, at 3:35 PM, John Selbie <john@selbie.com> wrote:
> 
> Additionally, one other thing as an implementation note.
> 
> STUN attributes are expected to align on 4-byte boundaries.  The way padding applies to the LENGTH field of each STUN attribute differs between RFC 3489 and RFC 5389. Explicit attribute padding in RFC 3489 vs implicit padding between attributes in RFC 5389.
> 
> If the length of the ORIGIN value is not a multiple of 4, this may break compatibility with RFC 3489.  STUN servers written for RFC 3489 may encounter a parsing error when servicing a binding request from such a client that includes an ORIGIN attribute with a length not divisible by 4.  (Can't recall what Vovida stund.097 does, but I remember hitting this issue during the development of stuntman).
> 
> This is not a new issue for STUN. Implementers should take note of this legacy requirement if the server responding to binding requests can not be assumed to be RFC 5389 compliant. The workaround is to explicitly pad the string attribute with zero's and have it's length field adjusted accordingly. There's a presumption with this workaround that the server treats the attribute bytes as a "C" string and ignores the extra zero bytes when processing it.
> 
> jrs
> 
> 
> 
> 
>> On Fri, Feb 7, 2014 at 9:08 AM, John Selbie <john@selbie.com> wrote:
>> One minor nit to add.  Be deliberate on distinguishing between "type" vs. "value" fields when explaining the new attribute.  The text below references section 15 of RFC 5389. That section shows the STUN attribute format with specified fields labeled "type" and "value".  The draft tends to use the words "type" and "value" interchangeably in the paragraph below.  It can be inferred by context, but I suggest being more explicit and consistent with the other attribute definitions in section 15 of 5389. That is, make sure that "0x802F" is for the "type" field and that the "value" field is understood to be a string.
>> 
>> Change this text:
>> 
>>    This specification defines a new Attribute to the STUN protocol
>>    [RFC5389].  The attribute is called ORIGIN and uses the syntax
>>    defined in Section 15 of [RFC5389].  A STUN Attribute type is a hex
>>    number in the range 0x0000 - 0xFFFF.  The ORIGIN attribute value is
>>    0x802F, chosen in the comprehension optional range.
>> 
>> 
>> To this:
>>    This specification defines a new Attribute to the STUN protocol
>>    [RFC5389].  The attribute is called ORIGIN and uses the syntax
>>    defined in Section 15 of [RFC5389].  The number used for the this
>>    in the type field is 0x802F, chosen in the comprehension optional range.
>>    The value of ORIGIN is a variable-length value.  It MUST contain a
>>    UTF-8 [RFC3629] encoded sequence of characters less than N bytes.
>> 
>> Where "N" is some reasonable number between up 65535.
>> 
>> jrs
>> 
>> 
>> 
>>> On Fri, Feb 7, 2014 at 6:04 AM, Simon Perreault <simon.perreault@viagenie.ca> wrote:
>>> Le 2014-02-07 08:10, Alan Johnston a écrit :
>>> > We have updated the STUN Origin draft.  We have tried to incorporate all
>>> > the feedback we have received to date.
>>> 
>>> I'm a fan of the new text. Very well written.
>>> 
>>> A nit: please s/URL/URI/g
>>> 
>>> Thanks,
>>> Simon
>>> --
>>> DTN made easy, lean, and smart --> http://postellation.viagenie.ca
>>> NAT64/DNS64 open-source        --> http://ecdysis.viagenie.ca
>>> STUN/TURN server               --> http://numb.viagenie.ca
>>> _______________________________________________
>>> tram mailing list
>>> tram@ietf.org
>>> https://www.ietf.org/mailman/listinfo/tram
> 
> _______________________________________________
> tram mailing list
> tram@ietf.org
> https://www.ietf.org/mailman/listinfo/tram