[tram] Secdir last call review of draft-ietf-tram-stunbis-16

Matthew Miller <linuxwolf+ietf@outer-planes.net> Fri, 09 March 2018 21:50 UTC

Return-Path: <linuxwolf+ietf@outer-planes.net>
X-Original-To: tram@ietf.org
Delivered-To: tram@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 06BB01242F7; Fri, 9 Mar 2018 13:50:10 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Matthew Miller <linuxwolf+ietf@outer-planes.net>
To: secdir@ietf.org
Cc: draft-ietf-tram-stunbis.all@ietf.org, ietf@ietf.org, tram@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.74.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <152063220998.11155.12669577501214588133@ietfa.amsl.com>
Date: Fri, 09 Mar 2018 13:50:10 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/tram/0qyDBLBc-hFkKzB0XqbmOt33d18>
Subject: [tram] Secdir last call review of draft-ietf-tram-stunbis-16
X-BeenThere: tram@ietf.org
X-Mailman-Version: 2.1.22
List-Id: "Discussing the creation of a Turn Revised And Modernized \(TRAM\) WG, which goal is to consolidate the various initiatives to update TURN and STUN." <tram.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tram>, <mailto:tram-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tram/>
List-Post: <mailto:tram@ietf.org>
List-Help: <mailto:tram-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tram>, <mailto:tram-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Mar 2018 21:50:10 -0000

Reviewer: Matthew Miller
Review result: Has Issues

[ I realize how unfortunate it is this arrives well past last call.
I beg forgiveness and ask that you accept the comments as you would
have if they arrived on time. ]

I have reviewed this document as part of the security directorate's
ongoing effort to review all IETF documents being processed by the
IESG.  These comments were written primarily for the benefit of the
security area directors.  Document editors and WG chairs should
treat these comments just like any other last call comments.

Document: draft-ietf-stunbis-16
Reviewer: Matthew A. Miller
Review Date: 2018-03-07
IETF LC End Date: 2018-02-20
IESG Telechat date: 2018-04-05

Summary:  This document obsoletes 5389, adding some protection to
downgrade attacks against message integrity usage, as well
incorporating DTLS (over UDP).

The document is mostly ready, but there are a couple of issues I
have.

Major Issues: N/A

Minor Issues:

* I am wondering why a more robust password algorithm (key derivation
function) was not defined (e.g., HKDF-SHA-256) instead of or in addition
to, a simple salted "SHA-256" hash.  Some amount of parameterization is
accounted for in the PASSWORD-ALGORITHM/S attributes.  I think it is
perfectly fair and appropriate to take this issue as "asking for a quick
rationale (that maybe ought to be highlighted better in the document)"
over "use a real key derivation function".

* The description for 17.5.1. "MD5" list the key size as 20 bytes, but the
hash length of MD5 is 16 bytes (128 bits).  I think this is merely a typo,
since the purpose appears to be for backwards compatibility with existing
systems.

* Both 17.5.1.1. "MD5" Section 9.2.2. "HMAC Key" (long-term credential)
and Section appear to define the same functional algorithm, but with subtle
syntax differences.  As far as I can tell, they are actually the same
algorithm; would it not be acceptable to have Section 9.2.2 point to
Section 17.5.1.1 for the algorithm description?