Re: [tram] [Gen-art] Genart last call review of draft-ietf-tram-stun-pmtud-09

"Roni Even (A)" <roni.even@huawei.com> Mon, 17 September 2018 13:35 UTC

Return-Path: <roni.even@huawei.com>
X-Original-To: tram@ietfa.amsl.com
Delivered-To: tram@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0905E130E6E; Mon, 17 Sep 2018 06:35:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZRrg6zB2OuKO; Mon, 17 Sep 2018 06:35:51 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C3D13130E6B; Mon, 17 Sep 2018 06:35:50 -0700 (PDT)
Received: from LHREML710-CAH.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id 5C9759F0CBE4A; Mon, 17 Sep 2018 14:35:41 +0100 (IST)
Received: from DGGEMM401-HUB.china.huawei.com (10.3.20.209) by LHREML710-CAH.china.huawei.com (10.201.108.33) with Microsoft SMTP Server (TLS) id 14.3.399.0; Mon, 17 Sep 2018 14:31:55 +0100
Received: from DGGEMM526-MBX.china.huawei.com ([169.254.8.153]) by DGGEMM401-HUB.china.huawei.com ([10.3.20.209]) with mapi id 14.03.0399.000; Mon, 17 Sep 2018 21:31:46 +0800
From: "Roni Even (A)" <roni.even@huawei.com>
To: Marc Petit-Huguenin <petithug@acm.org>, Roni Even <ron.even.tlv@gmail.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "ietf@ietf.org" <ietf@ietf.org>, "tram@ietf.org" <tram@ietf.org>, "draft-ietf-tram-stun-pmtud.all@ietf.org" <draft-ietf-tram-stun-pmtud.all@ietf.org>
Thread-Topic: [Gen-art] [tram] Genart last call review of draft-ietf-tram-stun-pmtud-09
Thread-Index: AQHUToLBHLMSNcv+9UuFn8cw6HmWmaT0eFKQ
Date: Mon, 17 Sep 2018 13:31:46 +0000
Message-ID: <6E58094ECC8D8344914996DAD28F1CCD8DF5E7@dggemm526-mbx.china.huawei.com>
References: <153597861719.13253.13043738114222950149@ietfa.amsl.com> <b96fcc56-f188-435a-f59e-24dfc8f69f52@acm.org>
In-Reply-To: <b96fcc56-f188-435a-f59e-24dfc8f69f52@acm.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.47.144.93]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/tram/Nvv7fEVG0UGs83ODDlSGZmHcBhU>
Subject: Re: [tram] [Gen-art] Genart last call review of draft-ietf-tram-stun-pmtud-09
X-BeenThere: tram@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Discussing the creation of a Turn Revised And Modernized \(TRAM\) WG, which goal is to consolidate the various initiatives to update TURN and STUN." <tram.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tram>, <mailto:tram-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tram/>
List-Post: <mailto:tram@ietf.org>
List-Help: <mailto:tram-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tram>, <mailto:tram-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Sep 2018 13:35:53 -0000

Hi Marc,
Thanks, these changes address all my comments
Roni

-----Original Message-----
From: Gen-art [mailto:gen-art-bounces@ietf.org] On Behalf Of Marc Petit-Huguenin
Sent: Monday, September 17, 2018 3:34 PM
To: Roni Even; gen-art@ietf.org
Cc: ietf@ietf.org; tram@ietf.org; draft-ietf-tram-stun-pmtud.all@ietf.org
Subject: Re: [Gen-art] [tram] Genart last call review of draft-ietf-tram-stun-pmtud-09

Hi Roni,

Thank you for the review.

On 09/03/2018 05:43 AM, Roni Even wrote:
> Reviewer: Roni Even
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area 
> Review Team (Gen-ART) reviews all IETF documents being processed by 
> the IESG for the IETF Chair.  Please treat these comments just like 
> any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-tram-stun-pmtud-??
> Reviewer: Roni Even
> Review Date: 2018-09-03
> IETF LC End Date: 2018-09-12
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> The documents is ready for publication as a standard track RFC with 
> nits and minor issues
> 
> Major issues:
> 
> Minor issues:
> 
> 1. The security section says " The PMTUD mechanism described in this 
> document does not introduce any
>    specific security considerations" yet section 5.1 talk about amplification
>    attack

Right, I thought that RFC 4821 covered that attack, but neither RFC 4821 or RFC 1981 do.

So I rewrote the first paragraph as:

"The PMTUD mechanism described in this document, when used without the  signalling mechanism described in Section 5.1, does not introduce any  specific security considerations beyond those described in [RFC4821]."

And added:

"The amplification attacks introduced by the signalling mechanism  described in Section 5.1 can be prevented by using one of the  techniques described in that section."

> 
> Nits/editorial comments:
> 
> 1.  In section 2 last paragraph "Probe Indications of various sizes" 
> any guidelines about the sizes and how many indications?

The algorithm for choosing the size and numbers of indications is in RFC 4821, so there is no point of repeating that here.  But I changed the text to remind people that they must read RFC 4821:

"[...]
 chosen, then the Client sends Probe Indications of various sizes (as  specified in [RFC4821]) interleaved with UDP packets sent by the UDP  [...]"

> 
> 
> _______________________________________________
> tram mailing list
> tram@ietf.org
> https://www.ietf.org/mailman/listinfo/tram
> 


--
Marc Petit-Huguenin
Email: marc@petit-huguenin.org
Blog: https://marc.petit-huguenin.org
Profile: https://www.linkedin.com/in/petithug