Re: [tram] Fwd: New Version Notification for draft-johnston-tram-stun-origin-01.txt

John Selbie <john@selbie.com> Fri, 07 February 2014 17:08 UTC

Return-Path: <john@selbie.com>
X-Original-To: tram@ietfa.amsl.com
Delivered-To: tram@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EBD6F1A0027 for <tram@ietfa.amsl.com>; Fri, 7 Feb 2014 09:08:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.977
X-Spam-Level:
X-Spam-Status: No, score=-1.977 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FM_FORGED_GMAIL=0.622, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tjaCfLAQUg0a for <tram@ietfa.amsl.com>; Fri, 7 Feb 2014 09:08:18 -0800 (PST)
Received: from mail-oa0-f46.google.com (mail-oa0-f46.google.com [209.85.219.46]) by ietfa.amsl.com (Postfix) with ESMTP id D9B2C1A0433 for <tram@ietf.org>; Fri, 7 Feb 2014 09:08:17 -0800 (PST)
Received: by mail-oa0-f46.google.com with SMTP id n16so4504493oag.19 for <tram@ietf.org>; Fri, 07 Feb 2014 09:08:17 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=iK+jaTvi281YhJLu/qBLoImCO8sO/g5rcW0/JGg5KCM=; b=EKn327fKoG5FvAFRJrpBCmxUdoE8YZ9Z2hxxsJ6kt57pq5wrlPh5S8xWehZPXmQ/DD 2QeDCkJYZJDOSPqCjSDidos2NcSPbT/kGzqfOwRpcRPDwmy+dzmj0SodPbqIO21JzgSc yAJSIzzHjqcBGzh41gRjpt0cSruavqKGVPkRgEwBXvufwOwJQDl9uCIhmFI9YtWioUaI +38UZrou1t0+UiPDamhV26j3280E4o1m34ijGQcO12X/7cw+Mm6+rpq6XJ9vt10EV7y3 GiZdYBVmdPuvoy4UFex1O39gnG90G+sfYNYWW9uEyW+U1iYvzVFIdhxxFeGl7QlMG2cD jyrA==
X-Gm-Message-State: ALoCoQl74+jB96d0iNPE2bqLjFP1YHCU3LwF7mfNf51WwnSPn+q8kdCy3f5aoMmvz/brsLUynM7Q
MIME-Version: 1.0
X-Received: by 10.182.48.233 with SMTP id p9mr13685835obn.44.1391792897509; Fri, 07 Feb 2014 09:08:17 -0800 (PST)
Received: by 10.76.34.131 with HTTP; Fri, 7 Feb 2014 09:08:17 -0800 (PST)
In-Reply-To: <52F4E7FA.70600@viagenie.ca>
References: <20140206202155.28963.48259.idtracker@ietfa.amsl.com> <CAKhHsXGcewhs6mk8PRVXeUB9BFwDRM0xZ297rckU+H4jjy819A@mail.gmail.com> <52F4E7FA.70600@viagenie.ca>
Date: Fri, 07 Feb 2014 09:08:17 -0800
Message-ID: <CAP8pQQvnEFmE1xrM_=a1dVMhd5acH_whRrdGRZq=-hoUig1DuA@mail.gmail.com>
From: John Selbie <john@selbie.com>
To: Simon Perreault <simon.perreault@viagenie.ca>
Content-Type: multipart/alternative; boundary="047d7b66f0bd42727c04f1d40967"
Cc: tram@ietf.org
Subject: Re: [tram] Fwd: New Version Notification for draft-johnston-tram-stun-origin-01.txt
X-BeenThere: tram@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "Discussing the creation of a Turn Revised And Modernized \(TRAM\) WG, which goal is to consolidate the various initiatives to update TURN and STUN." <tram.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tram>, <mailto:tram-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/tram/>
List-Post: <mailto:tram@ietf.org>
List-Help: <mailto:tram-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tram>, <mailto:tram-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Feb 2014 17:08:21 -0000

One minor nit to add.  Be deliberate on distinguishing between "type" vs.
"value" fields when explaining the new attribute.  The text below
references section 15 of RFC 5389. That section shows the STUN attribute
format with specified fields labeled "type" and "value".  The draft tends
to use the words "type" and "value" interchangeably in the paragraph below.
 It can be inferred by context, but I suggest being more explicit and
consistent with the other attribute definitions in section 15 of 5389. That
is, make sure that "0x802F" is for the "type" field and that the "value"
field is understood to be a string.

Change this text:

   This specification defines a new Attribute to the STUN protocol
   [RFC5389].  The attribute is called ORIGIN and uses the syntax
   defined in Section 15 of [RFC5389].  A STUN Attribute type is a hex
   number in the range 0x0000 - 0xFFFF.  The ORIGIN attribute value is
   0x802F, chosen in the comprehension optional range.


To this:
   This specification defines a new Attribute to the STUN protocol
   [RFC5389].  The attribute is called ORIGIN and uses the syntax
   defined in Section 15 of [RFC5389].  The number used for the this
   in the type field is 0x802F, chosen in the comprehension optional range.
   The value of ORIGIN is a variable-length value.  It MUST contain a
   UTF-8 [RFC3629] encoded sequence of characters less than N bytes.

Where "N" is some reasonable number between up 65535.

jrs



On Fri, Feb 7, 2014 at 6:04 AM, Simon Perreault <simon.perreault@viagenie.ca
> wrote:

> Le 2014-02-07 08:10, Alan Johnston a écrit :
> > We have updated the STUN Origin draft.  We have tried to incorporate all
> > the feedback we have received to date.
>
> I'm a fan of the new text. Very well written.
>
> A nit: please s/URL/URI/g
>
> Thanks,
> Simon
> --
> DTN made easy, lean, and smart --> http://postellation.viagenie.ca
> NAT64/DNS64 open-source        --> http://ecdysis.viagenie.ca
> STUN/TURN server               --> http://numb.viagenie.ca
> _______________________________________________
> tram mailing list
> tram@ietf.org
> https://www.ietf.org/mailman/listinfo/tram
>