Re: [tram] [Technical Errata Reported] RFC8489 (6268)

RenThraysk <renthraysk@gmail.com> Mon, 07 September 2020 15:22 UTC

Return-Path: <renthraysk@gmail.com>
X-Original-To: tram@ietfa.amsl.com
Delivered-To: tram@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F2FD83A106E for <tram@ietfa.amsl.com>; Mon, 7 Sep 2020 08:22:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C_MfX1xi96tF for <tram@ietfa.amsl.com>; Mon, 7 Sep 2020 08:22:43 -0700 (PDT)
Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BF5FF3A106D for <tram@ietf.org>; Mon, 7 Sep 2020 08:22:42 -0700 (PDT)
Received: by mail-wr1-x435.google.com with SMTP id w5so16196135wrp.8 for <tram@ietf.org>; Mon, 07 Sep 2020 08:22:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NQXGY7Nr/td3Q00LK0afWBZcTQb2bXGFXE9JIkg2Wng=; b=Ps4QDtQgdtwVMCgKswqpu6Cka4cN9yv1QD8zRDdyIMlU914/2aTUaeKx21hK3YVLx/ lhzgF+a46yLJ3bJn/lYqpPWwwtkvb5eWffftgPbnNAwpgtEdPz0v0AO+QRa+z6Gi3gxQ tBD+z4I0KVaf02SK9TH4vL+UJu6fSj6OCKJI5WPPPWVSqgY+/eE+jYdsS6c/VnlVWcpS hAHVIFlS9cmfdfY+UzntERaVZv4KH2EW5L6i7GPA/XXeBFeZAeYzdjJF4Npj7gMxkC9S VlUejCBb0QktdypgZW3dOt/2qY238Kx8fJ5bu+8ahSlObq7UTDOzlEbNzqGmuuBcyKEI fm3A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NQXGY7Nr/td3Q00LK0afWBZcTQb2bXGFXE9JIkg2Wng=; b=oK5XnRBcKuG2hYKQRTobEddg8VG9cFB+LO8SkPhX3mZOL4COG0hqwSNv5pZa3L1KPV gMIZ8bIPyJO73RrIktBUDCTQf2T2Lzrkf/aYtrnYOItbjR4jdZ5G43L7eN4SeRV0mfkm Qe4URhx2ctb1pdB4zLJSCyU9NRCvhnZ1KnoHRR3BO4UHVEi1NHFZrXATy3LHDKCHDd4a iAzYSg0V9GnVC0wUZ3WwbnGHooUgbwuNQmijLnbx9l8FnRkxFa/mG9p5R9z6JMCVQAWE BvBb5Kie9z2FCs5iLX0h8e1koKiurDPklR7LNwjMlf6xsF+zOVjtk0/CeDoAlu2RCvXS WZog==
X-Gm-Message-State: AOAM533M8DJqEoJWhH9MZMXjYDreDWTy2J/Mk4ojV42xbOTvqwRMBrkv EhbgJSVg5kh6ZkOBBQvT0wmLTBc18GclS01l5ug=
X-Google-Smtp-Source: ABdhPJzbT93P79NaMNbsNZje85TMk5jZq/6PJIWznh69vurnJc4AoyH6qucl2CXdoC28iKvbz919hM4gwW4BFuKOEZE=
X-Received: by 2002:adf:fc81:: with SMTP id g1mr10590698wrr.31.1599492161165; Mon, 07 Sep 2020 08:22:41 -0700 (PDT)
MIME-Version: 1.0
References: <20200830152251.37CA9F4076B@rfc-editor.org> <bd82edbe82f83f7c92c6cb21924951d35132768f.camel@ericsson.com> <B09AFC19-A790-46C5-A97B-69572411A229@cisco.com> <7bbe51fd9a5a226752597825f276f6baad70add7.camel@ericsson.com> <f48eb512-5c17-20bd-dfd6-2d368e9fd4b9@petit-huguenin.org>
In-Reply-To: <f48eb512-5c17-20bd-dfd6-2d368e9fd4b9@petit-huguenin.org>
From: RenThraysk <renthraysk@gmail.com>
Date: Mon, 7 Sep 2020 16:22:30 +0100
Message-ID: <CABNgG1g3Tx1QroP+eo+WeQXxD2XPvf+n67pekBqRi8+QzgX8_Q@mail.gmail.com>
To: Marc Petit-Huguenin <marc@petit-huguenin.org>
Cc: Magnus Westerlund <magnus.westerlund@ericsson.com>, "gsalguei@cisco.com" <gsalguei@cisco.com>, "simon.perreault@logmein.com" <simon.perreault@logmein.com>, "martin.h.duke@gmail.com" <martin.h.duke@gmail.com>, "philip_matthews@magma.ca" <philip_matthews@magma.ca>, Gonzalo Camarillo <gonzalo.camarillo@ericsson.com>, "jdrosen@jdrosen.net" <jdrosen@jdrosen.net>, "dwing-ietf@fuggles.com" <dwing-ietf@fuggles.com>, "tram@ietf.org" <tram@ietf.org>, "rohan.ietf@gmail.com" <rohan.ietf@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000165f5905aebaca8f"
Archived-At: <https://mailarchive.ietf.org/arch/msg/tram/iIrW9Ldv4fRo-p-01AU4wzGcyPY>
X-Mailman-Approved-At: Tue, 08 Sep 2020 11:40:59 -0700
Subject: Re: [tram] [Technical Errata Reported] RFC8489 (6268)
X-BeenThere: tram@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Discussing the creation of a Turn Revised And Modernized \(TRAM\) WG, which goal is to consolidate the various initiatives to update TURN and STUN." <tram.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tram>, <mailto:tram-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tram/>
List-Post: <mailto:tram@ietf.org>
List-Help: <mailto:tram-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tram>, <mailto:tram-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Sep 2020 15:22:45 -0000

Hi

Why has the Userhash value changed from the original test vector?

Jared

On Mon, Sep 7, 2020 at 3:21 PM Marc Petit-Huguenin <marc@petit-huguenin.org>
wrote:

> Hi Magnus,
>
> Here's the corrected test-vector:
>
> <begins>
>       00 01 00 88      Request type and message length
>       21 12 a4 42      Magic cookie
>       78 ad 34 33   }
>       c6 ad 72 c0   }  Transaction ID
>       29 da 41 2e   }
>       00 1e 00 20      USERHASH attribute header
>       63 aa 09 fc   }
>       23 81 0a 46   }
>       c9 76 e9 59   }
>       23 10 ee 1e   }  Userhash value (32 bytes)
>       59 b7 06 e1   }
>       9d e1 bd 21   }
>       a9 f6 f7 40   }
>       28 d5 ba 71   }
>       00 15 00 29      NONCE attribute header
>       6f 62 4d 61   }
>       74 4a 6f 73   }
>       32 41 41 41   }
>       43 66 2f 2f   }
>       34 39 39 6b   }  Nonce value and padding (3 bytes)
>       39 35 34 64   }
>       36 4f 4c 33   }
>       34 6f 4c 39   }
>       46 53 54 76   }
>       79 36 34 73   }
>       41 00 00 00   }
>       00 14 00 0b      REALM attribute header
>       65 78 61 6d   }
>       70 6c 65 2e   }  Realm value (11 bytes) and padding (1 byte)
>       6f 72 67 00   }
>       00 1c 00 20      MESSAGE-INTEGRITY-SHA256 attribute header
>       8e 57 3d 97   }
>       75 33 21 ae   }
>       47 8c b6 a2   }
>       7b 8a 6b 3a   }  HMAC-SHA256 value
>       89 08 9e e1   }
>       5f 62 6b 38   }
>       40 9f 48 ed   }
>       47 a5 df 57   }
> <ends>
>
> Thanks.
>
> On 9/1/20 4:04 AM, Magnus Westerlund wrote:
> > Hi,
> >
> > I think it is reasonable that we do an RFC Errata for this error to
> provide a
> > corrected test vector.
> >
> > I can edit the Errata request to have a different text. So if you
> authors could
> > prepare and review a proposal that fixes this I will edit and approve it.
> >
> > So if you can provide the text that goes into the three parts:
> >
> > Original Text: (I assume the full message from B.1 here)
> >
> > Corrected Text: Full message with corrected message length and
> recomputed Hash
> > value.
> >
> > Notes: If there are any additional that was already written that you
> like to
> > remark about this error?
> >
> > Cheers
> >
> > Magnus
> >
> > On Mon, 2020-08-31 at 17:00 +0000, Gonzalo Salgueiro (gsalguei) wrote:
> >> Hi Magnus -
> >>
> >> Marc responded earlier so you may have missed it. Below is his response:
> >>
> >> +++++++++++
> >> This errata is correct, and there is nobody to blame for that mistake
> but me.
> >>
> >> Magnus, how to you want to proceed for the recomputed test vector?
> >>
> >> Thanks.
> >> +++++++++++
> >>
> >> Cheers,
> >>
> >> Gonzalo
> >>
> >>
> >>> On Aug 31, 2020, at 11:08 AM, Magnus Westerlund <
> >>> magnus.westerlund@ericsson.com> wrote:
> >>>
> >>> Hi,
> >>>
> >>> Author's can you please confirm if this is correct or not?
> >>>
> >>> Cheers
> >>>
> >>> Magnus
> >>>
> >>> On Sun, 2020-08-30 at 08:22 -0700, RFC Errata System wrote:
> >>>> The following errata report has been submitted for RFC8489,
> >>>> "Session Traversal Utilities for NAT (STUN)".
> >>>>
> >>>> --------------------------------------
> >>>> You may review the report below and at:
> >>>>
> >>>
> >>>
> https://protect2.fireeye.com/v1/url?k=99260d6d-c786cf2b-99264df6-86fc6812c361-2320f3daa9544fe5&q=1&e=c28eb099-e321-4447-80c3-942509fe0974&u=https%3A%2F%2Fwww.rfc-editor.org%2Ferrata%2Feid6268
> >>>> --------------------------------------
> >>>> Type: Technical
> >>>> Reported by: Jared Williams <renthraysk@gmail.com>
> >>>>
> >>>> Section: Appendix B.1
> >>>>
> >>>> Original Text
> >>>> -------------
> >>>> 00 01 00 9c      Request type and message length
> >>>>
> >>>>
> >>>> Corrected Text
> >>>> --------------
> >>>> 00 01 00 88      Request type and message length
> >>>>
> >>>> Notes
> >>>> -----
> >>>> The message length in the test vector (9c) is the absolute length of
> the
> >>>> whole
> >>>> test vector. However from section 5. STUN Message Structure
> >>>>
> >>>> "The message length MUST contain the size of the message in bytes, not
> >>>>   including the 20-byte STUN header."
> >>>>
> >>>> So the message length in the header should be 20 less than absolute
> length
> >>>> of
> >>>> the whole message.
> >>>>
> >>>> 0x9C - 20, 0x88.
> >>>>
> >>>> Also the MESSAGE-INTEGRITY-SHA256 HMAC-SHA256 value of the Test Vector
> >>>> will
> >>>> need recomputing.
> >>>>
> >>>> Instructions:
> >>>> -------------
> >>>> This erratum is currently posted as "Reported". If necessary, please
> >>>> use "Reply All" to discuss whether it should be verified or
> >>>> rejected. When a decision is reached, the verifying party
> >>>> can log in to change the status and edit the report, if necessary.
> >>>>
> >>>> --------------------------------------
> >>>> RFC8489 (draft-ietf-tram-stunbis-21)
> >>>> --------------------------------------
> >>>> Title               : Session Traversal Utilities for NAT (STUN)
> >>>> Publication Date    : February 2020
> >>>> Author(s)           : M. Petit-Huguenin, G. Salgueiro, J. Rosenberg,
> D.
> >>>> Wing,
> >>>> R. Mahy, P. Matthews
> >>>> Category            : PROPOSED STANDARD
> >>>> Source              : TURN Revised and Modernized
> >>>> Area                : Transport
> >>>> Stream              : IETF
> >>>> Verifying Party     : IESG
> >>>  --
> >>> Cheers
> >>>
> >>> Magnus Westerlund
> >>>
> >>>
>
> --
> Marc Petit-Huguenin
> Email: marc@petit-huguenin.org
> Blog: https://marc.petit-huguenin.org
> Profile: https://www.linkedin.com/in/petithug
>