Re: [trill] Alissa Cooper's Discuss on draft-ietf-trill-smart-endnodes-10: (withDISCUSS and COMMENT)

Donald Eastlake <d3e3e3@gmail.com> Wed, 07 March 2018 19:36 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3FC6112D0C3; Wed, 7 Mar 2018 11:36:03 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.448
X-Spam-Level:
X-Spam-Status: No, score=-2.448 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ookqQuxv5ZL9; Wed, 7 Mar 2018 11:36:00 -0800 (PST)
Received: from mail-io0-x22e.google.com (mail-io0-x22e.google.com [IPv6:2607:f8b0:4001:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 307F91200F1; Wed, 7 Mar 2018 11:36:00 -0800 (PST)
Received: by mail-io0-x22e.google.com with SMTP id f1so4338552iob.0; Wed, 07 Mar 2018 11:36:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zvIP/ynwoiJoyqqL3rtIpwwWEdPSxwBCOtbEj6F8wB4=; b=eQiaqtxPew0CQH/R2/AeJrdN+KxRtP1Sm5kEqejykuT2PG6GvPTmPhPza7YkssqAiN jwmPkrwnOuXD7Awictc6aoqOOMvIyK9cxmB9XNTrVEUJECsbuIN7sivTtbeyVSriCGVL OCBFqsZdLFDFSjjOh2DLGHWJj2R7SYnzYjdIwUhQrSzF4ZHtY0Kv3kUrQZuSB3/esNK+ JIim3FCtiETe6CUmsGwYoWEu3/p05LqwB2JU/wNK9+R4WOdna8J+fJHVPO4DOl9Jkji7 OOL3uGgPKiWaGZftRnmirup0hXQzieWu1yefqeAVI/YVfl2e9F8k8mdlZoOgI1wRb/kh xsKQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zvIP/ynwoiJoyqqL3rtIpwwWEdPSxwBCOtbEj6F8wB4=; b=Z+6sU76/nnVm1IUC+Gqg60Elmf2ejRMzX4feKIEyhzh5/csnQ2LiF4snX+dRhDDDwz avQ63c81j1cPbT3Zd7J/u7uS8QFjghhcYF3BSKg8xB5BkMxAaRELRCr2SAoe+Y2QzL3e QBWeGGsHzbFAvt6uHb8AdfyS+C27fWd6hgcYxFiUK8XQ0OR9Sn2DHI7K304QD9eEyGUH aW/vPFyhq8QoivBHuI0KKf8oKghGxOHI+IMClNmDjUb5zgQP4IQQkxEeky0qjFaldTsQ ub9oigOjnP7IOwgw7ncd54yerZAOWfKpKZGz+ybEOyr6PHgxWh7d8uoRNhcbf1VR8jHr 1nvA==
X-Gm-Message-State: APf1xPCIsXEAocjMmXNaKfWI344Sqo4+/ItJLZrDYdoQ9nFlxqseJ8pT UEQVntZdQ+dKD18x136INinCU/slLWk9LA3r8d4G9ZJH
X-Google-Smtp-Source: AG47ELv5xdDTCXcGLhNZT1mvhP4bdlTyjfuwTTIX06SHizkDZWyJCFZ4Oti+M4AHOrrS2QkxSvFjO6B9V3DgwAlGKM8=
X-Received: by 10.107.89.13 with SMTP id n13mr27802003iob.154.1520451359346; Wed, 07 Mar 2018 11:35:59 -0800 (PST)
MIME-Version: 1.0
Received: by 10.107.58.193 with HTTP; Wed, 7 Mar 2018 11:35:43 -0800 (PST)
In-Reply-To: <D51EDB30-A8C2-446E-B263-318E2A96A650@cooperw.in>
References: <152036910061.28346.1223384759329179194.idtracker@ietfa.amsl.com> <201803071355148877819@zte.com.cn> <D51EDB30-A8C2-446E-B263-318E2A96A650@cooperw.in>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Wed, 7 Mar 2018 14:35:43 -0500
Message-ID: <CAF4+nEHzE1E-qWQS=X2T+3EXyDKhg_f1p74SS1NZd-8j3G5eRA@mail.gmail.com>
To: Alissa Cooper <alissa@cooperw.in>
Cc: Hu Fangwei <hu.fangwei@zte.com.cn>, IESG <iesg@ietf.org>, draft-ietf-trill-smart-endnodes@ietf.org, trill-chairs@ietf.org, Susan Hares <shares@ndzh.com>, trill IETF mailing list <trill@ietf.org>
Content-Type: multipart/alternative; boundary="f4f5e803dce42c183f0566d7ab91"
Archived-At: <https://mailarchive.ietf.org/arch/msg/trill/1LozioMSdNJJ9q15V5Ncj8G6RdA>
Subject: Re: [trill] Alissa Cooper's Discuss on draft-ietf-trill-smart-endnodes-10: (withDISCUSS and COMMENT)
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Mar 2018 19:36:03 -0000

On Wed, Mar 7, 2018 at 10:01 AM, Alissa Cooper <alissa@cooperw.in>; wrote:
> Hi Fangwei,
>
> As I noted in response to the Gen-ART reviewer, I managed to ballot before
> reading the rest of this thread (sorry!), but I still think the diagram in
> 4.3 is confusing and not consistent with the text. To my eye row 3 shows
two
> bytes’ worth of fields but the label says “4 bytes.” RSV is depicted as 2
> bits but the text says it is 6 bits. The combination of these two
> inconsistencies makes it hard to know what the actual lengths are supposed
> to be.

I agree that the figure is a little confusing. I suggest the following:

    +-+-+-+-+-+-+-+-+
    |Type=Smart-MAC |          (1 byte)
    +-+-+-+-+-+-+-+-+
    |   Length      |          (1 byte)
    +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-...+-+-+-+-+
    |F|M|  RSV      |  VLAN/FGL Data Label         |  (4 bytes)
    +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-...+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
    |                          MAC (1)                (6 bytes)        |
    +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-...+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
    |                      .................                           |
    +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-...+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
    |                          MAC (N)                (6 bytes)        |
    +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-...+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

Thanks,
Donald
===============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 155 Beaver Street, Milford, MA 01757 USA
 d3e3e3@gmail.com

> Alissa
>
> On Mar 7, 2018, at 12:55 AM, hu.fangwei@zte.com.cn wrote:
>
> Hi,Alissa Cooper
>
> Thanks for your review and comments.
>
> The new version(version 10)  has updated to fix your comments.
>
> The format of Smart-MAC APP sub-TLV and the text  has been changed to the
> following:
>
> The length of F,M,RSV,VLAN/FGL data Label is 4 bytes. and the length of
> VLAN/FGL Data Label field is 24 bits.
>
>
>    +-+-+-+-+-+-+-+-+
>     |Type=Smart-MAC |                  (1 byte)
>     +-+-+-+-+-+-+-+-+
>     |   Length      |                  (1 byte)
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>     |F|M|RSV|  VLAN/FGL Data Label  |  (4 bytes)
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-...+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>     |                          MAC (1)       (6 bytes)                 |
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-...+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>     |                      .................                           |
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-...+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>     |                          MAC (N)       (6 bytes)                 |
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-...+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>
>                      Figure 3 Smart-MAC APPsub-TLV
>
>
>    o  VLAN/FGL Data Label: 24bits.  If F is 1, this field is a 24-bit
>       FGL Data Label for all subsequent MAC addresses in this APPsub-
>       TLV.  Otherwise, if F is 0, the lower 12 bits is the VLAN of all
>       subsequent MAC addresses in this APPsub-TLV, and the upper 12 bits
>       is not used(sent as zero and ignored on receipt).  If there is no
>       VLAN/FGL data label specified, the VLAN/FGL Data Label is zero.
>
>
>
>
> Regards.
>
> Fangwei.
>
> 原始邮件
> 发件人:AlissaCooper <alissa@cooperw.in>;
> 收件人:The IESG <iesg@ietf.org>;
> 抄送人:draft-ietf-trill-smart-endnodes@ietf.org
> <draft-ietf-trill-smart-endnodes@ietf.org>trill-chairs@ietf.org
> <trill-chairs@ietf.org>shares@ndzh.com <shares@ndzh.com>trill@ietf.org
> <trill@ietf.org>;
> 日 期 :2018年03月07日 04:45
> 主 题 :Alissa Cooper's Discuss on draft-ietf-trill-smart-endnodes-10:
> (withDISCUSS and COMMENT)
> Alissa Cooper has entered the following ballot position for
> draft-ietf-trill-smart-endnodes-10: Discuss
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-trill-smart-endnodes/
>
>
>
> ----------------------------------------------------------------------
> DISCUSS:
> ----------------------------------------------------------------------
>
> This should hopefully be easy to fix and was pointed out by the Gen-ART
> reviewer:
>
> All of section 4.3 is confusing as to what the length of the TLV really
is.
> Row 3 in the diagram says 2 bytes or 4 bytes, but the number of bits
called
> out
> in bullets 4 and 5 below it don't seem to add up to those things. Maybe it
> would
> be better to draw a diagram with F=0 and a separate diagram with F=1.
>
> Please make it clear both in the diagram and in the text what the expected
> lengths of the fields are -- I find it particularly confusing that the
> number
> of bits pictured doesn't align with the number of bits specified in the
text
> per field.
>
>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> Please also look at the Gen-ART reviewer's other comments.
>
>
>