[trill] Tsvart last call review of draft-ietf-trill-ecn-support-04

Michael Tüxen <tuexen@fh-muenster.de> Sun, 04 February 2018 18:54 UTC

Return-Path: <tuexen@fh-muenster.de>
X-Original-To: trill@ietf.org
Delivered-To: trill@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id E180C128954; Sun, 4 Feb 2018 10:54:04 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: =?utf-8?q?Michael_T=C3=BCxen?= <tuexen@fh-muenster.de>
To: <tsv-art@ietf.org>
Cc: draft-ietf-trill-ecn-support.all@ietf.org, ietf@ietf.org, trill@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.71.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <151777044483.12244.16174801155565406521@ietfa.amsl.com>
Date: Sun, 04 Feb 2018 10:54:04 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/trill/1smr0iDfks1bUfksesjpuEJLdpE>
Subject: [trill] Tsvart last call review of draft-ietf-trill-ecn-support-04
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.22
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Feb 2018 18:54:05 -0000

Reviewer: Michael Tüxen
Review result: Ready with Nits

I've reviewed this document as part of the transport area directorate's ongoing
effort to review key IETF documents. These comments were written primarily for
the transport area directors, but are copied to the document's authors for
their information and to allow them to address any issues raised.
When done at the time of IETF Last Call, the authors should consider this
review together with any other last-call comments they receive.
Please always CC tsv-art@ietf.org if you reply to or forward this review.

This draft is basically ready for publication, but has nits that should be fixed before publication.

Nits:

Section 1:

Old text:
This can improve network efficiency through better flow
control without packet drops.

New text:
This can improve network efficiency through better congestion
control without packet drops.

Old text:
This specification provides for any ECN marking in the traffic at the
ingress to be copied into the TRILL Extension Header Flags Word.

New Text:
This specification specifies for any ECN marking in the traffic at the
ingress to be copied into the TRILL Extension Header Flags Word.

Section 2:

Old text:
after the Extesnion Flags Word.

New text:
after the Extension Flags Word

Section 3.3

Please define "3-bit ECN codepoint" and refer to Table 3 BEFORE using it.
This might result in swapping Table 2 and Table 3.