[trill] Shepherd's report on draft-ietf-trill-ecn-support-04

"Susan Hares" <shares@ndzh.com> Mon, 22 January 2018 15:18 UTC

Return-Path: <shares@ndzh.com>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 51E4F124207 for <trill@ietfa.amsl.com>; Mon, 22 Jan 2018 07:18:34 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.946
X-Spam-Level:
X-Spam-Status: No, score=0.946 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DOS_OUTLOOK_TO_MX=2.845, HTML_MESSAGE=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TJm4BzeBLK8Z for <trill@ietfa.amsl.com>; Mon, 22 Jan 2018 07:18:32 -0800 (PST)
Received: from hickoryhill-consulting.com (50-245-122-97-static.hfc.comcastbusiness.net [50.245.122.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B6B80127286 for <trill@ietf.org>; Mon, 22 Jan 2018 07:18:31 -0800 (PST)
X-Default-Received-SPF: pass (skip=loggedin (res=PASS)) x-ip-name=166.176.249.181;
From: "Susan Hares" <shares@ndzh.com>
To: <trill@ietf.org>
Cc: "'Donald Eastlake'" <d3e3e3@gmail.com>, <ietf@bobbriscoe.net>
Date: Mon, 22 Jan 2018 10:18:29 -0500
Message-ID: <00e901d39394$423c0930$c6b41b90$@ndzh.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="----=_NextPart_000_00EA_01D3936A.596712A0"
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AdOTkqya25kunFIoRqyZp7TaCj59Vw==
Content-Language: en-us
X-Authenticated-User: skh@ndzh.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/trill/8L-hgWSUw4zrWyAq3MbSOlg8iI8>
Subject: [trill] Shepherd's report on draft-ietf-trill-ecn-support-04
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Jan 2018 15:18:35 -0000

As part of the shepherd's duties, I've review
draft-ietf-trill-ecn-support-04.txt to determine if it is ready for
publication. 

 

Status: Ready with editorial nits 

 

General comment:  I'm thrilled to see an RBridge specification enacting aids
for advanced congestion control mechanisms. 

What I've checked: normative references including
draft-ietf-twvwg-enc-encap-guidelines-01/txt

 

Editorial nits are below.  You can adopt or ignore the editorial nits. 

 

Sue Hares

===========

 

Editorial nits: 

 

General - it may be helpful to specify section in the [ECNencapGuide] -
document, and RFC7567.  While the way you specify it is correct, it may help
the reader to narrow down the scope within the document. 

 

#1 

   Explicit congestion notification (ECN [RFC3168
<https://tools.ietf.org/html/rfc3168> ]) allows a forwarding
   element, such as a router, to notify downstream devices, including
   the destination, of the onset of congestion without having to drop
   packets. 

 

The multiple commons in this sentence do not lend to easy reading of the
initial sentence. 

One alternative is: 

 

   Explicit congestion notification (ECN [RFC3168
<https://tools.ietf.org/html/rfc3168> ]) allows a forwarding
   Element (such as a router) to notify downstream devices, including
   the destination, of the onset of congestion without having to drop
   packets. 

 

However you may wish to revise the sentence in an alternative way. 

 

 

#2 - Section 2. Paragraph 2. Sentences 4 

Old/Extesnion Flags Word./

New/Extension Flags Word./

 

 

#3 - Section 3.3 is dense and thoughtful text.  I am not sure you can
improve it, but it too me several reads to make sure I understood it
correctly.