Re: [trill] TRILL OAM framework review (draft-ietf-trill-oam-framework-01)

"Samer Salam (ssalam)" <ssalam@cisco.com> Wed, 17 April 2013 17:33 UTC

Return-Path: <ssalam@cisco.com>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A6DBA21F8976 for <trill@ietfa.amsl.com>; Wed, 17 Apr 2013 10:33:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.599
X-Spam-Level:
X-Spam-Status: No, score=-10.599 tagged_above=-999 required=5 tests=[AWL=-0.000, BAYES_00=-2.599, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-8]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8YVmD0hsuj9a for <trill@ietfa.amsl.com>; Wed, 17 Apr 2013 10:33:26 -0700 (PDT)
Received: from rcdn-iport-1.cisco.com (rcdn-iport-1.cisco.com [173.37.86.72]) by ietfa.amsl.com (Postfix) with ESMTP id 542D921F896C for <trill@ietf.org>; Wed, 17 Apr 2013 10:33:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=17291; q=dns/txt; s=iport; t=1366220006; x=1367429606; h=from:to:cc:subject:date:message-id:in-reply-to: mime-version; bh=tZoWQUtfUtzvKRsahFEyKNCSmbQbuZ+crYEgVJpfmBQ=; b=dCd/Qjtx9ZPRilFLg8EgqZLx9tA8JOL0GF98NmWiLgVE0y6y1VnY82BE 2w2DZ7vEgRRSewL3vexn0rERcEzFMwCZljzicprAFkebly3FnpeqQD14e QSX/ElNNBFsnT7h+3AhzAC5qCRxx2fivp90Q1UKstTpvi44EqhucTBqQr s=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AjMFAK7bblGtJXG8/2dsb2JhbABQgkIjITbARIEEFnSCHwEBAQQtTBIBCA4DAwECCx0oERQJCAEBBAENBQgTh2cDDwGzdA2JXYxHgiIgEQcGgl9hA5UjjVuFHIMLgig
X-IronPort-AV: E=Sophos; i="4.87,495,1363132800"; d="scan'208,217"; a="199708904"
Received: from rcdn-core2-1.cisco.com ([173.37.113.188]) by rcdn-iport-1.cisco.com with ESMTP; 17 Apr 2013 17:33:25 +0000
Received: from xhc-rcd-x11.cisco.com (xhc-rcd-x11.cisco.com [173.37.183.85]) by rcdn-core2-1.cisco.com (8.14.5/8.14.5) with ESMTP id r3HHXPbB008670 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 17 Apr 2013 17:33:25 GMT
Received: from xmb-aln-x13.cisco.com ([fe80::5404:b599:9f57:834b]) by xhc-rcd-x11.cisco.com ([173.37.183.85]) with mapi id 14.02.0318.004; Wed, 17 Apr 2013 12:33:25 -0500
From: "Samer Salam (ssalam)" <ssalam@cisco.com>
To: Susan Hares <shares@ndzh.com>, "'Donald Eastlake'" <d3e3e3@gmail.com>, "sam.aldrin@gmail.com" <sam.aldrin@gmail.com>, "Tissa Senevirathne (tsenevir)" <tsenevir@cisco.com>
Thread-Topic: TRILL OAM framework review (draft-ietf-trill-oam-framework-01)
Thread-Index: Ac4xfGWYe5JQyIDFRvKvLvCLF+llFgKBH6OA
Date: Wed, 17 Apr 2013 17:33:25 +0000
Message-ID: <8F25FF8EA49D164EBE5F1B5AD33F3BC9123A0CC7@xmb-aln-x13.cisco.com>
In-Reply-To: <014e01ce317c$778f7880$66ae6980$@ndzh.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/14.2.3.120616
x-originating-ip: [161.44.210.96]
Content-Type: multipart/alternative; boundary="_000_8F25FF8EA49D164EBE5F1B5AD33F3BC9123A0CC7xmbalnx13ciscoc_"
MIME-Version: 1.0
Cc: "trill@ietf.org" <trill@ietf.org>
Subject: Re: [trill] TRILL OAM framework review (draft-ietf-trill-oam-framework-01)
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/trill>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Apr 2013 17:33:27 -0000

Hi Sue,

Thank you for the review comments. We will incorporate them in the updated revision of the draft.

Best Regards,
Samer

From: Susan Hares <shares@ndzh.com<mailto:shares@ndzh.com>>
Date: Thursday, April 4, 2013 2:36 PM
To: 'Donald Eastlake' <d3e3e3@gmail.com<mailto:d3e3e3@gmail.com>>, "sam.aldrin@gmail.com<mailto:sam.aldrin@gmail.com>" <sam.aldrin@gmail.com<mailto:sam.aldrin@gmail.com>>, "Tissa Senevirathne (tsenevir)" <tsenevir@cisco.com<mailto:tsenevir@cisco.com>>, "Samer Salam (ssalam)" <ssalam@cisco.com<mailto:ssalam@cisco.com>>
Cc: "trill@ietf.org<mailto:trill@ietf.org>" <trill@ietf.org<mailto:trill@ietf.org>>
Subject: TRILL OAM framework review (draft-ietf-trill-oam-framework-01)

Donald, Sam, Tissa, and Samer:

General comments: Nicely written and enjoyable to read after all of the debates.

Two technical issues concern me as underspecified in the document:


1.       Section 2.4 has maintenance Domains which can be “nested to form a hierarchy” (p. 12, para. 1)

a.       The nesting of Domains seems to be underspecified in this draft and it is unclear exactly how these domains would nest.

b.      There are mechanism for finding the hierarchy (Domain name and maintenance level (numeric ID), but it is not clear from the document how this works.

2.       Section 4.2.1.2 – Multicast prevention of reply storms from overwhelming the initiating RBridge.

a.       Staggering or Jittering responses  may or may not protect the initiating RBridge

b.      Again – this may be right or wrong, but the lack of additional details concerns me whether this solution has been written down correctly.  I suspect from Tissa’s comments that it is working.

Editorial comments:

1.       Replace TRILL-OAM-REQ with RFC6905 in all document,

2.       p. 4 TRILL in para. 2 has an extra space “-     TRILL” to “-TRILL”

3.       use of “multipathing” – has this been defined elsewhere? – it should be defined or referenced,

4.       page 6. Para. 2 beginning [RFC6371].  Please change /protection-switching management and/protection-switching management/

5.       page 8 sentence:  “The output ports on which TRILL OAM message are sent are determined by the TRILL routing function, which will only send on links that are in the up state and have been incorporated into the local view of the campus topology”  - Suggest

a.       “The output ports on which TRILL OAM messages are sent are determined by the TRILL routing function. The TRILL Routing function will only send on links that are in the up state and have been incorporated into the local view of the campus topology”.

6.       Page 11 – [TRILLML] – is not listed in the references –

7.       Page 16.  Suggest changing 1st sentence of paragraph into two parts.  /[RFC6325] and the Link Header/[RFC6325]. The Link header”

8.       Page 4.1.2.2 add at end of sentence 2 /section./ section (4.1.2.1).

Sue Hares
Reviewer