[trill] Genart telechat review of draft-ietf-trill-smart-endnodes-08

Robert Sparks <rjsparks@nostrum.com> Tue, 27 February 2018 20:24 UTC

Return-Path: <rjsparks@nostrum.com>
X-Original-To: trill@ietf.org
Delivered-To: trill@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id A688C1201FA; Tue, 27 Feb 2018 12:24:47 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Robert Sparks <rjsparks@nostrum.com>
To: <gen-art@ietf.org>
Cc: ietf@ietf.org, draft-ietf-trill-smart-endnodes.all@ietf.org, trill@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.73.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <151976308758.28489.12406772916405932448@ietfa.amsl.com>
Date: Tue, 27 Feb 2018 12:24:47 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/trill/GGngrSSXBMWZ-D6AKIMUIVKxLDc>
Subject: [trill] Genart telechat review of draft-ietf-trill-smart-endnodes-08
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.22
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Feb 2018 20:24:48 -0000

Reviewer: Robert Sparks
Review result: Ready with Issues

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair. Please wait for direction from your
document shepherd or AD before posting a new version of the draft.

For more information, please see the FAQ at


Document: draft-ietf-trill-smart-endnodes-08
Reviewer: Robert Sparks
Review Date: 2018-02-27
IETF LC End Date: 2018-03-06
IESG Telechat date: 2018-03-08

Summary: Ready with issues

Major issues

1) In section 4.3 the bullet describing the F bit does not parse. There are two
instances of "Otherwise" that do not work together.

2) All of section 4.3 is confusing as to what the length of the TLV really is.
Row 3 in the diagram says 2 bytes or 4 bytes, but the number of bits called out
in bullets 4 and 5 below it don't seem to add up to those things. Maybe it would
be better to draw a diagram with F=0 and a separate diagram with F=1

3) I think the security considerations section should call out again what an RB
should do if it gets message that looks like it's from a SE, containing the
right nickname, but the RB hasn't done the right Smart-Hello handshaking with
that SE already. What would keep a lazy implementation (or one driven by
product managers picking and choosing features) from just forwarding a message
from a malicious element that just happened to know the RB's nickname?


Terminology: The definition of Transit RBridge says it's also named as a
Transit Rbridge?