Re: [trill] TRILL OAM framework review (draft-ietf-trill-oam-framework-01)

"Samer Salam (ssalam)" <ssalam@cisco.com> Tue, 07 May 2013 01:09 UTC

Return-Path: <ssalam@cisco.com>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8BF7A21F93B3 for <trill@ietfa.amsl.com>; Mon, 6 May 2013 18:09:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.995
X-Spam-Level:
X-Spam-Status: No, score=-9.995 tagged_above=-999 required=5 tests=[AWL=0.603, BAYES_00=-2.599, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-8]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kfZwHR5VjqTZ for <trill@ietfa.amsl.com>; Mon, 6 May 2013 18:08:56 -0700 (PDT)
Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) by ietfa.amsl.com (Postfix) with ESMTP id DF63221F939C for <trill@ietf.org>; Mon, 6 May 2013 18:08:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=19945; q=dns/txt; s=iport; t=1367888933; x=1369098533; h=from:to:cc:subject:date:message-id:in-reply-to: mime-version; bh=/cRf8SKIJPYIR6TdJMAAzaj9xxRQ+79wcd96ilVo/Hk=; b=gpQYjlqsDQ/iX16/HciFD+zu3UMVJsI6lsiRl/RuQMCblQw+fSXHZmVM uRKkkMV+oIt3vMK8pAc2VunEzHRktDiDlVcswdtiWrJweZOlOhePukiER YokHGz4amRYcJGaYbJrf3yTlFe3qxe6QJa9RLeynWdMEhwrCQCniOATYG 8=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: Ag8FAMhTiFGtJXHB/2dsb2JhbABQgkMjITe/CYEKFnSCHwEBAQQtQQsSAQgOAwMBAgsWBygRFAkIAQEEAQ0FCBOHXwMPAbJUhhwNiBKMW4IlIBEHBoJsYQOTX4FrjXeFIYMNgic
X-IronPort-AV: E=Sophos; i="4.87,624,1363132800"; d="scan'208,217"; a="204148198"
Received: from rcdn-core2-6.cisco.com ([173.37.113.193]) by rcdn-iport-9.cisco.com with ESMTP; 07 May 2013 01:08:52 +0000
Received: from xhc-aln-x15.cisco.com (xhc-aln-x15.cisco.com [173.36.12.89]) by rcdn-core2-6.cisco.com (8.14.5/8.14.5) with ESMTP id r4718qdD001261 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Tue, 7 May 2013 01:08:52 GMT
Received: from xmb-aln-x13.cisco.com ([fe80::5404:b599:9f57:834b]) by xhc-aln-x15.cisco.com ([173.36.12.89]) with mapi id 14.02.0318.004; Mon, 6 May 2013 20:08:51 -0500
From: "Samer Salam (ssalam)" <ssalam@cisco.com>
To: Susan Hares <shares@ndzh.com>, "'Donald Eastlake'" <d3e3e3@gmail.com>, "sam.aldrin@gmail.com" <sam.aldrin@gmail.com>, "Tissa Senevirathne (tsenevir)" <tsenevir@cisco.com>
Thread-Topic: TRILL OAM framework review (draft-ietf-trill-oam-framework-01)
Thread-Index: Ac4xfGWYe5JQyIDFRvKvLvCLF+llFgZMjZEA
Date: Tue, 7 May 2013 01:08:51 +0000
Message-ID: <8F25FF8EA49D164EBE5F1B5AD33F3BC9123CC666@xmb-aln-x13.cisco.com>
In-Reply-To: <014e01ce317c$778f7880$66ae6980$@ndzh.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/14.2.3.120616
x-originating-ip: [161.44.210.112]
Content-Type: multipart/alternative; boundary="_000_8F25FF8EA49D164EBE5F1B5AD33F3BC9123CC666xmbalnx13ciscoc_"
MIME-Version: 1.0
Cc: "trill@ietf.org" <trill@ietf.org>
Subject: Re: [trill] TRILL OAM framework review (draft-ietf-trill-oam-framework-01)
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/trill>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 07 May 2013 01:09:01 -0000

Hi Sue,

Thank you for the review and comments. Please find comment resolution responses inline…

From: Susan Hares <shares@ndzh.com<mailto:shares@ndzh.com>>
Date: Thursday, April 4, 2013 2:36 PM
To: 'Donald Eastlake' <d3e3e3@gmail.com<mailto:d3e3e3@gmail.com>>, "sam.aldrin@gmail.com<mailto:sam.aldrin@gmail.com>" <sam.aldrin@gmail.com<mailto:sam.aldrin@gmail.com>>, "Tissa Senevirathne (tsenevir)" <tsenevir@cisco.com<mailto:tsenevir@cisco.com>>, "Samer Salam (ssalam)" <ssalam@cisco.com<mailto:ssalam@cisco.com>>
Cc: "trill@ietf.org<mailto:trill@ietf.org>" <trill@ietf.org<mailto:trill@ietf.org>>
Subject: TRILL OAM framework review (draft-ietf-trill-oam-framework-01)

Donald, Sam, Tissa, and Samer:

General comments: Nicely written and enjoyable to read after all of the debates.

Two technical issues concern me as underspecified in the document:


1.       Section 2.4 has maintenance Domains which can be “nested to form a hierarchy” (p. 12, para. 1)

a.       The nesting of Domains seems to be underspecified in this draft and it is unclear exactly how these domains would nest.

b.      There are mechanism for finding the hierarchy (Domain name and maintenance level (numeric ID), but it is not clear from the document how this works.

Have added text to expand and clarify.


2.       Section 4.2.1.2 – Multicast prevention of reply storms from overwhelming the initiating RBridge.

a.       Staggering or Jittering responses  may or may not protect the initiating RBridge

b.      Again – this may be right or wrong, but the lack of additional details concerns me whether this solution has been written down correctly.  I suspect from Tissa’s comments that it is working.

Have added more details to clarify. Basically this is following the same paradigm that CFM LinkTrace uses to stagger responses, in order to avoid overwhelming the initiating MEP.


Editorial comments:

All editorial comments below were incorporated. We will be sending the draft to the workgroup mailing list shortly.

Regards,
Samer


1.       Replace TRILL-OAM-REQ with RFC6905 in all document,

2.       p. 4 TRILL in para. 2 has an extra space “-     TRILL” to “-TRILL”

3.       use of “multipathing” – has this been defined elsewhere? – it should be defined or referenced,

4.       page 6. Para. 2 beginning [RFC6371].  Please change /protection-switching management and/protection-switching management/

5.       page 8 sentence:  “The output ports on which TRILL OAM message are sent are determined by the TRILL routing function, which will only send on links that are in the up state and have been incorporated into the local view of the campus topology”  - Suggest

a.       “The output ports on which TRILL OAM messages are sent are determined by the TRILL routing function. The TRILL Routing function will only send on links that are in the up state and have been incorporated into the local view of the campus topology”.

6.       Page 11 – [TRILLML] – is not listed in the references –

7.       Page 16.  Suggest changing 1st sentence of paragraph into two parts.  /[RFC6325] and the Link Header/[RFC6325]. The Link header”

8.       Page 4.1.2.2 add at end of sentence 2 /section./ section (4.1.2.1).

Sue Hares
Reviewer