Re: [trill] [RTG-DIR] RtgDir review: draft-ietf-trill-tree-selection-01

Liyizhou <liyizhou@huawei.com> Thu, 14 January 2016 07:22 UTC

Return-Path: <liyizhou@huawei.com>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3BE821B2C29; Wed, 13 Jan 2016 23:22:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.201
X-Spam-Level:
X-Spam-Status: No, score=-4.201 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id otibDa2lmAdf; Wed, 13 Jan 2016 23:22:49 -0800 (PST)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9D4FF1B2C2B; Wed, 13 Jan 2016 23:22:45 -0800 (PST)
Received: from 172.18.7.190 (EHLO lhreml401-hub.china.huawei.com) ([172.18.7.190]) by lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id CCX47557; Thu, 14 Jan 2016 07:22:21 +0000 (GMT)
Received: from NKGEML408-HUB.china.huawei.com (10.98.56.39) by lhreml401-hub.china.huawei.com (10.201.5.240) with Microsoft SMTP Server (TLS) id 14.3.235.1; Thu, 14 Jan 2016 07:22:20 +0000
Received: from NKGEML513-MBX.china.huawei.com ([169.254.1.112]) by nkgeml408-hub.china.huawei.com ([10.98.56.39]) with mapi id 14.03.0235.001; Thu, 14 Jan 2016 15:22:15 +0800
From: Liyizhou <liyizhou@huawei.com>
To: Susan Hares <shares@ndzh.com>, "'Daniele Ceccarelli'" <daniele.ceccarelli@ericsson.com>, "rtg-ads@ietf.org" <rtg-ads@ietf.org>
Thread-Topic: [trill] [RTG-DIR] RtgDir review: draft-ietf-trill-tree-selection-01
Thread-Index: AQHRTmm6kbI91y4dIE6d6RKNY28z/576mX9Q
Date: Thu, 14 Jan 2016 07:22:15 +0000
Message-ID: <D408889639FC5E4FADB4E00A3E01FA8F91514D5E@nkgeml513-mbx.china.huawei.com>
References: <4A1562797D64E44993C5CBF38CF1BE4812B20594@ESESSMB301.ericsson.se> <009101d14e69$a9af5df0$fd0e19d0$@ndzh.com>
In-Reply-To: <009101d14e69$a9af5df0$fd0e19d0$@ndzh.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.135.180.237]
Content-Type: multipart/alternative; boundary="_000_D408889639FC5E4FADB4E00A3E01FA8F91514D5Enkgeml513mbxchi_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090202.56974CC2.0077, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=169.254.1.112, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 88ac2b537cbe8f4c7ababa0207791232
Archived-At: <http://mailarchive.ietf.org/arch/msg/trill/JUJmttEOws_Fse5GwSCfbVmzbpc>
Cc: "draft-ietf-trill-tree-selection.all@tools.ietf.org" <draft-ietf-trill-tree-selection.all@tools.ietf.org>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "trill@ietf.org" <trill@ietf.org>
Subject: Re: [trill] [RTG-DIR] RtgDir review: draft-ietf-trill-tree-selection-01
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jan 2016 07:22:53 -0000

Daniele,
Thanks for the review.

I am going to update the document to reflect all the nits you pointed out.
For minor issues, proposed text change is as follow.

Minor Issues:

  *   Section 3.2 – A list of the 4 TLVs with their name and one sentence summarizing its use would improve readability. Same applies in the following to e.g. section 3.2.1 where the paragraph before the figure is not very clear on the usage of the TLV.
Text are modified as follows for section 3.2:
Two APPsub-TLVs supporting VLAN based tree selection are specified in Sections 3.2.1 and 3.2.2. They are used by the highest priority tree root to announce the allowed VLANs on each tree in the campus and by an ingress RBridge to announce the tree-VLAN correspondence it selects from the list announced by the highest priority tree root. Two APPsub-TLVs supporting FGL based tree selection are specified in Section 3.2.3 and 3.2.4 for the same purpose.

Add text to improve the readability of section 3.2.2 &3.2.4.
3.2.2: This APPsub-TLV is used by an ingress RBridge to distribute the tree-VLAN correspondence it selects from the list announced by the highest priority tree root.
3.2.4: This APPsub-TLV is used by an ingress RBridge to distribute the tree-FGL correspondence it selects from the list announced by the highest priority tree root.

  *   Section 3.5 – Section 3.5 defines a fifth TLV, why not listing it with the other 4 ?
It was an extension proposed in relatively late versions. You are right. I will move it to section 3.2.5 to make the document neat. And add one sentence in section 3.2 to introduce this TLV: Section 3.2.5 defines an APPsub-TLVs to support the finer granularity in selecting trees on multicast group base rather than data label base.


Thanks,
Yizhou

From: trill [mailto:trill-bounces@ietf.org] On Behalf Of Susan Hares
Sent: Thursday, January 14, 2016 9:20 AM
To: 'Daniele Ceccarelli'; rtg-ads@ietf.org
Cc: draft-ietf-trill-tree-selection.all@tools.ietf.org; rtg-dir@ietf.org; trill@ietf.org
Subject: Re: [trill] [RTG-DIR] RtgDir review: draft-ietf-trill-tree-selection-01

Daniele:

Thank you for this review.

Sue Hares

From: rtg-dir [mailto:rtg-dir-bounces@ietf.org] On Behalf Of Daniele Ceccarelli
Sent: Wednesday, January 13, 2016 3:52 PM
To: <rtg-ads@ietf.org<mailto:rtg-ads@ietf.org>> (rtg-ads@ietf.org<mailto:rtg-ads@ietf.org>)
Cc: draft-ietf-trill-tree-selection.all@tools.ietf.org<mailto:draft-ietf-trill-tree-selection.all@tools.ietf.org>; rtg-dir@ietf.org<mailto:rtg-dir@ietf.org>; trill@ietf.org<mailto:trill@ietf.org>
Subject: [RTG-DIR] RtgDir review: draft-ietf-trill-tree-selection-01


Hello,

I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir<http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir>

Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.

Document: draft-ietf-trill-tree-selection-01
Reviewer: Daniele Ceccarelli
Review Date: Jan 07 2015
IETF LC End Date: September 2015
Intended Status: Standard Track
Summary:

  *   This document is basically ready for publication, but has nits that should be considered prior to publication.
Comments:

  *   Overall the draft if well written and easy to understand. I found it quite difficult to go through section 1 but I guess it’s due to my lack of knowledge of the technology. A rearrangement accordingly to the minor issues IMO would improve readability of the document.
Major Issues:

  *   No major issues found
Minor Issues:

  *   Section 3.2 – A list of the 4 TLVs with their name and one sentence summarizing its use would improve readability. Same applies in the following to e.g. section 3.2.1 where the paragraph before the figure is not very clear on the usage of the TLV.
  *   Section 3.5 – Section 3.5 defines a fifth TLV, why not listing it with the other 4 ?
Nits:

  *   Section 1.1: s/ the ingress RBridge use/the ingress RBridge uses
  *   Section 2: s/campus/Campus
  *   Section 3.1 s/is/has ??
  *   Section 3.3 s/rfc7180bis/RFC7180bis
BR
Daniele