Return-Path: X-Original-To: trill@ietfa.amsl.com Delivered-To: trill@ietfa.amsl.com Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2CDE41B29F6 for ; Wed, 5 Aug 2015 18:11:12 -0700 (PDT) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -4.21 X-Spam-Level: X-Spam-Status: No, score=-4.21 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a9UFyR0GB1np for ; Wed, 5 Aug 2015 18:11:09 -0700 (PDT) Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A2DDA1B29F4 for ; Wed, 5 Aug 2015 18:11:08 -0700 (PDT) Received: from 172.18.7.190 (EHLO lhreml403-hub.china.huawei.com) ([172.18.7.190]) by lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id BZN67089; Thu, 06 Aug 2015 01:11:07 +0000 (GMT) Received: from nkgeml405-hub.china.huawei.com (10.98.56.36) by lhreml403-hub.china.huawei.com (10.201.5.217) with Microsoft SMTP Server (TLS) id 14.3.235.1; Thu, 6 Aug 2015 02:11:06 +0100 Received: from NKGEML503-MBX.china.huawei.com ([169.254.5.180]) by nkgeml405-hub.china.huawei.com ([10.98.56.36]) with mapi id 14.03.0235.001; Thu, 6 Aug 2015 09:10:59 +0800 From: Liyizhou To: gayle noble , "trill@ietf.org" Thread-Topic: [trill] draft-ietf-trill-tree-selection - WG LC (2nd call) - 8/4 to 8/18 Thread-Index: AQHQz58G1AsENhGLdUqAdurlAIa0NJ3+KfdA Date: Thu, 6 Aug 2015 01:10:59 +0000 Message-ID: References: <01da01d0ceb5$ae763810$0b62a830$@ndzh.com> <201508051651.t75GpIAK079557@skyhighway.com> In-Reply-To: <201508051651.t75GpIAK079557@skyhighway.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.135.180.237] Content-Type: multipart/alternative; boundary="_000_D408889639FC5E4FADB4E00A3E01FA8F838CF372nkgeml503mbxchi_" MIME-Version: 1.0 X-CFilter-Loop: Reflected Archived-At: Subject: Re: [trill] draft-ietf-trill-tree-selection - WG LC (2nd call) - 8/4 to 8/18 X-BeenThere: trill@ietf.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Developing a hybrid router/bridge." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Aug 2015 01:11:12 -0000 --_000_D408889639FC5E4FADB4E00A3E01FA8F838CF372nkgeml503mbxchi_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks, Gayle. I will update the text as per your suggestions. Thanks for = your careful review. Yizhou From: trill [mailto:trill-bounces@ietf.org] On Behalf Of gayle noble Sent: Thursday, August 06, 2015 12:51 AM To: trill@ietf.org Subject: Re: [trill] draft-ietf-trill-tree-selection - WG LC (2nd call) - 8= /4 to 8/18 I support this draft advancing. I do have the following suggestions acronyms used but not defined - I'd like to see them defined in the documen= t APPsub-TLV - Application sub-TLV E-L1FS - Extended Level 1 Scope FS-LSP - Flooding Scoped Label Switched Paths RPF - Reverse Path Forward Sub-TLV - Link-type sub-Type-Length-Values corrections: 1. page 4 - first paragraph - forth sentence ["multi-destiantion" should be spelt "multi-destination"] (as written) Every RBridge can specify the trees it will use for multi-destiantion TRILL= data packets it originated in the Trees Used Identifiers (TREE-USE-IDs) su= b-TLV and the VLANs or fine grained labels (FGLs [RFC7172]) it is intereste= d in are specified in Interested VLANs and/or Interested Labels sub-TLVs [R= FC7176]. (should be) Every RBridge can specify the trees it will use for multi-destination TRILL= data packets it originated in the Trees Used Identifiers (TREE-USE-IDs) su= b-TLV and the VLANs or fine grained labels (FGLs [RFC7172]) it is intereste= d in are specified in Interested VLANs and/or Interested Labels sub-TLVs [R= FC7176]. 2. page 4 second paragraph first sentence [Comma missing after "provided"] (as written) Defaults are provided but it is implementation dependent how many trees to = calculate, where the tree roots are located, and which tree(s) are to be us= ed by an ingress RBridge. (I think it should be) Defaults are provided, but it is implementation dependent how many trees to= calculate, where the tree roots are located, and which tree(s) are to be u= sed by an ingress RBridge. 3. page 5 fourth paragraph first sentence ["to an index to a list of ports" reads weird. Probably should be "to an in= dex of a list of ports" (as written) A multicast forwarding table at an RBridge is normally used to map the key = of (distribution tree nickname + VLAN) to an index to a list of ports for m= ulticast packet replication. (probably should be) A multicast forwarding table at an RBridge is normally used to map the key = of (distribution tree nickname + VLAN) to an index of a list of ports for m= ulticast packet replication. 4. page 8 section 3.1 second paragraph - second sentence ["as example" should be "as an example"] (as written) Take Figure 1 as example, two trees rooted at RB1 and RB2 respectively. (should be) Take Figure 1 as an example, two trees rooted at RB1 and RB2 respectively. 5. page 12 section 3.3 first paragraph - first sentence [I am totally confused by use of the word "usual" in "defined in [RFC7176] = as usual in its E-L1FS FS-LSP". Should "usual" be "used"??] (as written) The highest priority tree root RBridge MUST include all the necessary tree = related sub-TLVs defined in [RFC7176] as usual in its E-L1FS FS-LSP and MAY= include the Tree and VLANs Sub-TLV (TREE-VLANs) and/or Tree and FGLs Sub-T= LV (TREE-FGLs) in its E-L1FS FS-LSP [rfc7180bis]. (probably should be??) The highest priority tree root RBridge MUST include all the necessary tree = related sub-TLVs defined in [RFC7176] as used in its E-L1FS FS-LSP and MAY = include the Tree and VLANs Sub-TLV (TREE-VLANs) and/or Tree and FGLs Sub-TL= V (TREE-FGLs) in its E-L1FS FS-LSP [rfc7180bis]. 6. page 12 section 3.3 second paragraph - second sentence ["choose" should be "chooses"] (as written) If there were multiple tree nicknames announced in TREE-VLANs Sub-TLV for a= VLAN x, ingress RBridge choose one of them if it supports this feature. (should be) If there were multiple tree nicknames announced in TREE-VLANs Sub-TLV for a= VLAN x, ingress RBridge chooses one of them if it supports this feature. 7. page 16 #6 IANA considerations - first paragraph - first sentence ["assigne" should be "assign" :)] (as written) IANA is requested to assigne five new TRILL APPsub-TLV type codes from the = range less than 255 as specified in Section 3 and update the TRILL Paramete= rs registry as shown below. (should be) IANA is requested to assign five new TRILL APPsub-TLV type codes from the r= ange less than 255 as specified in Section 3 and update the TRILL Parameter= s registry as shown below. suggestions: 1. page 4 section: 1.1. Background Description - first paragraph sixth se= ntence [two things: (one) The sentence is really long and I think it could be brok= en into two sentences. (two) "used for reverse path forwarding check" reads= really weird - should be either "used for the reverse path forward check" = or "used for checking reverse path forwarding"] (as written) Trees Used Identifiers sub-TLVs are used to build the RPF Check table that = is used for reverse path forwarding check; Interested VLANs and Interested = Labels sub-TLVs are used for distribution tree pruning and the multi-destin= ation forwarding table with pruning info is built based on that. (I'd like it better) Trees Used Identifiers sub-TLVs are used to build the RPF Check table that = is used for checking reverse path forwarding. Interested VLANs and Interest= ed Labels sub-TLVs are used for distribution tree pruning and the multi-des= tination forwarding table with pruning info is built based on that. gayle --_000_D408889639FC5E4FADB4E00A3E01FA8F838CF372nkgeml503mbxchi_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Thanks, Ga= yle. I will update  the text as per your suggestions. Thanks for your = careful review.

 = ;

Yizhou

 = ;

From: trill [mailto:trill-bounces@ietf.org] On Behalf Of gayle noble
Sent: Thursday, August 06, 2015 12:51 AM
To: trill@ietf.org
Subject: Re: [trill] draft-ietf-trill-tree-selection - WG LC (2nd ca= ll) - 8/4 to 8/18

 

I support this draft advancing.=
I do have the following suggestions

acronyms used but not defined - I'd like to see them defined in the documen= t
APPsub-TLV - Application sub-TLV
E-L1FS           - Extended Level 1= Scope
FS-LSP         - Flooding Scoped La= bel Switched Paths
RPF             &nbs= p; - Reverse Path Forward
Sub-TLV         - Link-type sub-Type-Length-V= alues
 
corrections:
1.   page 4 - first paragraph - forth sentence
["multi-destiantion" should be spelt "multi-destination"= ;]
(as written)
Every RBridge can specify the trees it will use for multi-destiantion TRILL data packets it originated in the Trees U= sed Identifiers (TREE-USE-IDs) sub-TLV and the VLANs or fine grained labels= (FGLs [RFC7172]) it is interested in are specified in Interested VLANs and/or Interested Labels sub-TLVs [RF= C7176].
(should be)
Every RBridge can specify the trees it will use for multi-destination TRILL data packets it originated in the Trees = Used Identifiers (TREE-USE-IDs) sub-TLV and the VLANs or fine grained label= s (FGLs [RFC7172]) it is interested in are specified in Interested VLANs and/or Interested Labels sub-TLVs [RF= C7176].
 
2.   page 4 second paragraph first sentence
[Comma missing after "provided"]
(as written)
Defaults are provided but it is implementa= tion dependent how many trees to calculate, where the tree roots are locate= d, and which tree(s) are to be used by an ingress RBridge.
(I think it should be)
Defaults are provided, but it is implemen= tation dependent how many trees to calculate, where the tree roots are loca= ted, and which tree(s) are to be used by an ingress RBridge.
 
3.   page 5 fourth paragraph first sentence
["to an index to a list of ports" reads weird. Probably should be= "to an index of a list of ports"
(as written)
A multicast forwarding table at an RBridge is normally used to map the key = of (distribution tree nickname + VLAN) to an index to a list of ports for multica= st packet replication.
(probably should be)
A multicast forwarding table at an RBridge is normally used to map the key = of (distribution tree nickname + VLAN) to an index of a list of ports for multic= ast packet replication.
 
4.   page 8 section 3.1 second paragraph - second sentence
["as example" should be "as an example"]
(as written)
Take Figure 1 as example, two trees rooted= at RB1 and RB2 respectively.
(should be)
Take Figure 1 as an example, two trees ro= oted at RB1 and RB2 respectively.
 
5.   page 12 section 3.3  first paragraph - first sentence [I am totally confused by use of the word "usual" in "define= d in [RFC7176] as usual in its E-L1FS FS-LSP". Should "usual"= ; be "used"??]
(as written)
The highest priority tree root RBridge MUST include all the necessary tree = related sub-TLVs defined in [RFC7176] as usual in its E-L1FS FS-LSP and MAY incl= ude the Tree and VLANs Sub-TLV (TREE-VLANs) and/or Tree and FGLs Sub-TLV (T= REE-FGLs) in its E-L1FS FS-LSP [rfc7180bis].
(probably should be??)
The highest priority tree root RBridge MUST include all the necessary tree = related sub-TLVs defined in [RFC7176] as used in its E-L1FS FS-LSP and MAY incl= ude the Tree and VLANs Sub-TLV (TREE-VLANs) and/or Tree and FGLs Sub-TLV (T= REE-FGLs) in its E-L1FS FS-LSP [rfc7180bis].
 
6.   page 12 section 3.3 second paragraph - second sentence
["choose" should be "chooses"]
(as written)
If there were multiple tree nicknames announced in TREE-VLANs Sub-TLV for a= VLAN x, ingress RBridge choose one of them if it supports this fea= ture.
(should be)
If there were multiple tree nicknames announced in TREE-VLANs Sub-TLV for a= VLAN x, ingress RBridge chooses one of them if it supports this f= eature.
 
7.   page 16 #6 IANA considerations - first paragraph - first sen= tence
["assigne" should be "assign" :)]
(as written)
IANA is requested to assigne five new TRIL= L APPsub-TLV type codes from the range less than 255 as specified in Sectio= n 3 and update the TRILL Parameters registry as shown below.
(should be)
IANA is requested to assign five new TRIL= L APPsub-TLV type codes from the range less than 255 as specified in Sectio= n 3 and update the TRILL Parameters registry as shown below.
 
suggestions:
1.   page 4 section: 1.1. Background Description - first paragrap= h sixth sentence
[two things: (one) The sentence is really long and I think it could be brok= en into two sentences. (two) "used for reverse path forwarding check&q= uot; reads really weird - should be either "used for the reverse path = forward check" or "used for checking reverse path forwarding"]
(as written)
Trees Used Identifiers sub-TLVs are used to build the RPF Check table that = is used for reverse path forwarding check; Interested VLANs and Interested = Labels sub-TLVs are used for distribution tree pruning and the multi-destin= ation forwarding table with pruning info is built based on that.
 
(I'd like it better)
Trees Used Identifiers sub-TLVs are used to build the RPF Check table that = is used for checking reverse path forwarding. Interested VLANs and Interest= ed Labels sub-TLVs are used for distribution tree pruning and the multi-des= tination forwarding table with pruning info is built based on that.
 
 
gayle

--_000_D408889639FC5E4FADB4E00A3E01FA8F838CF372nkgeml503mbxchi_--