[trill] Genart telechat review of draft-ietf-trill-transport-over-mpls-07

Stewart Bryant <stewart.bryant@gmail.com> Fri, 02 March 2018 20:25 UTC

Return-Path: <stewart.bryant@gmail.com>
X-Original-To: trill@ietf.org
Delivered-To: trill@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id E2C2E124217; Fri, 2 Mar 2018 12:25:17 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Stewart Bryant <stewart.bryant@gmail.com>
To: <gen-art@ietf.org>
Cc: ietf@ietf.org, draft-ietf-trill-transport-over-mpls.all@ietf.org, trill@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.73.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <152002231785.15775.13618527763271574655@ietfa.amsl.com>
Date: Fri, 02 Mar 2018 12:25:17 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/trill/LhAQxnHb8UMCEcNoL01SoxRxAe8>
Subject: [trill] Genart telechat review of draft-ietf-trill-transport-over-mpls-07
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.22
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Mar 2018 20:25:18 -0000

Reviewer: Stewart Bryant
Review result: Ready with Issues

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair. Please wait for direction from your
document shepherd or AD before posting a new version of the draft.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-trill-transport-over-mpls-07
Reviewer: Stewart Bryant
Review Date: 2018-03-02
IETF LC End Date: 2018-03-06
IESG Telechat date: 2018-03-08

Summary: An understandable document. The only comment of note is the conflation
of PW headers and MPLS headers. There are a couple of easy to fix nits.

Major issues: None

Minor issues:

6. Packet Processing Between Pseudowires

 In this section you conflate PW headers and MPLS headers.
The PW label is a type of  MPLS label, although it has its own forwarding
instruction, but the control word is not part of MPLS.

Nits/editorial comments:

There is an ASCII art error in Fig 1 on the line containing Tenant1 Site1

The terms PE device and PE router seem to be used interchangeably.  Is this an
error, or are they distinct devices.

The VTSD must be capable of forming TRILL adjacency with the
SB> Should be "forming a TRILL adjacency"