Re: [trill] AD review of draft-ietf-trill-multilevel-unique-nickname-03

"Zhangmingui (Martin)" <zhangmingui@huawei.com> Thu, 22 February 2018 06:43 UTC

Return-Path: <zhangmingui@huawei.com>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E51F5126FDC; Wed, 21 Feb 2018 22:43:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.229
X-Spam-Level:
X-Spam-Status: No, score=-4.229 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nVx-KdTG7Xtt; Wed, 21 Feb 2018 22:43:32 -0800 (PST)
Received: from huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DE17712702E; Wed, 21 Feb 2018 22:43:31 -0800 (PST)
Received: from lhreml706-cah.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id 668FEE494EDAD; Thu, 22 Feb 2018 06:43:28 +0000 (GMT)
Received: from NKGEML411-HUB.china.huawei.com (10.98.56.70) by lhreml706-cah.china.huawei.com (10.201.108.47) with Microsoft SMTP Server (TLS) id 14.3.361.1; Thu, 22 Feb 2018 06:43:29 +0000
Received: from NKGEML515-MBX.china.huawei.com ([fe80::a54a:89d2:c471:ff]) by nkgeml411-hub.china.huawei.com ([10.98.56.70]) with mapi id 14.03.0361.001; Thu, 22 Feb 2018 14:43:22 +0800
From: "Zhangmingui (Martin)" <zhangmingui@huawei.com>
To: Alia Atlas <akatlas@gmail.com>, "trill@ietf.org" <trill@ietf.org>, "draft-ietf-trill-multilevel-unique-nickname@ietf.org" <draft-ietf-trill-multilevel-unique-nickname@ietf.org>
Thread-Topic: AD review of draft-ietf-trill-multilevel-unique-nickname-03
Thread-Index: AQHTqnLrWnYdUw+AhEqia+5nsJssRqOvtk0g
Date: Thu, 22 Feb 2018 06:43:22 +0000
Message-ID: <4552F0907735844E9204A62BBDD325E7AAFD6525@NKGEML515-MBX.china.huawei.com>
References: <CAG4d1re5R9LndciSgFzf68tGGFaLfExxfHzTxknsdn=guaQ64Q@mail.gmail.com>
In-Reply-To: <CAG4d1re5R9LndciSgFzf68tGGFaLfExxfHzTxknsdn=guaQ64Q@mail.gmail.com>
Accept-Language: en-US, zh-CN
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.111.146.93]
Content-Type: multipart/alternative; boundary="_000_4552F0907735844E9204A62BBDD325E7AAFD6525NKGEML515MBXchi_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/trill/MsBQEaalPZWMrQn_nCyR4vZW9QY>
Subject: Re: [trill] AD review of draft-ietf-trill-multilevel-unique-nickname-03
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Feb 2018 06:43:34 -0000

Hi Alia,

Thanks for the review. Please refer the response inline below. The 05 version incorporated those comments and has been uploaded.

From: Alia Atlas [mailto:akatlas@gmail.com]
Sent: Wednesday, February 21, 2018 1:47 AM
To: trill@ietf.org; draft-ietf-trill-multilevel-unique-nickname@ietf.org
Subject: AD review of draft-ietf-trill-multilevel-unique-nickname-03

As is traditional, I have done my AD review of draft-ietf-trill-multilevel-unique-nickname-03.  First, I would like to thank the authors - Margaret, Donald, Mingui, and Dacheng - as well as the reviewers and shepherd, Sue, for their work on this document.

I do have some minor comments, but these can be addressed ASAP while the draft is in IETF Last Call.  I will request that to start and place this on the IESG telechat on March 8.


Minor:

a) In Sec 3.1, it says "
      1) RB27 and RB3 have learned that D is connected to nickname 44.
      2) RB27 has learned that nickname 44 is accessible through RB3."

Given that RB2 is the local area's Level Border Router, I think that is RB2 not RB3. Granted, RB3 needs to know also - but that is info from its local area.

[Mingui] While it’s correct to say both RB2 and RB3 know D is connected to nickname 44 beforehand, it’s not a necessary condition. Consider this: RB27 learned D is connected to nickname 44, it will set the egress nickname to 44. RB2 and RB3 can acquire this info from the TRILL header rather than the local MAC table.  So the accurate sentence is “RB27 has learned that D is connected to nickname 44.”

b) In Sec 4.3:
" For nicknames in these ranges, other RBridges will deem that they are owned by the originating border RBridge. The paths to nicknames that fall in these ranges will be calculated to reach the originating border RBridge. TRILL Data packets with egress nicknames that are neither in these ranges nor announced by any RBridge in the area MUST be discarded. "

I think this only applies if OK = 0 - and that needs to be restated as part of the condition.

[Mingui]  Correct. The “OK=1” bullet does not apply here. So, this paragraph is now merged into the “OK=0” bullet.

Thanks,
Mingui

Regards,
Alia