Re: [trill] Alissa Cooper's Discuss on draft-ietf-trill-smart-endnodes-10: (withDISCUSS and COMMENT)

Donald Eastlake <d3e3e3@gmail.com> Tue, 13 March 2018 20:20 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 50C51126C3D; Tue, 13 Mar 2018 13:20:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.449
X-Spam-Level:
X-Spam-Status: No, score=-2.449 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G4_JiCyEHgzg; Tue, 13 Mar 2018 13:20:49 -0700 (PDT)
Received: from mail-io0-x231.google.com (mail-io0-x231.google.com [IPv6:2607:f8b0:4001:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 01DA01201FA; Tue, 13 Mar 2018 13:20:49 -0700 (PDT)
Received: by mail-io0-x231.google.com with SMTP id d71so1643170iog.4; Tue, 13 Mar 2018 13:20:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=lZ9msN2xi9EKZv3ZmCqNJ0tE5sZTSL9uzl93F8xjoew=; b=Gz0NtrTHC0hNjwVjmsexhyjp1nZSnuIOStNqCXJeP31n5Guch32LyPSBFpoArt8qu7 R0J6O4V+qvTWJvRd6xU+BYLCM+5YkmmsRd8hALcAgmb4pWnx/8GrKm/+C1YaANgqEYrX W+KjzKsSbe5nKHeTNFsM4nLq6TcCBHeO77qXlhsnpzjvamF83yx/KC8K8v1yIwjg+cxW +qPzDX0RuvjzQvQEB0SGXR1f5nZudosqtjt4PeTqJArZdPnXcIGkNfIrIE40pRkJ7EeJ YXw7pniJ7ADSyP3um8z0TrP91yXRRIpbrJss2P+DPXSVcXuNdZr2VgLiS3sp+WBp5dM9 HJLQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=lZ9msN2xi9EKZv3ZmCqNJ0tE5sZTSL9uzl93F8xjoew=; b=ADytj8liCh7l6UCKRvquIrGASvBqPHnBYlTNBD7L3TFG5TYdu+1wzWA03pmA3KH+9f Kk3FhHPq5OyFPdsUaaIiy8QnrO8dlpDKFLZRe7MNneCJ4mI3/CCt2wdaqsN6L/vhwAWy TaZrFPZSGu+McqPKdU3gKChKiJNyeJ2uivLBQxbikKBKsR9CPl0m4QgM291JCVPL8Xyg DGGnRInZhgCdFynwVqMjr3nxAVmt6XbJCWPfBpkX6g7en2Nv7m9VKfTnu/SxA+P09Zh8 6874NmUoCFC/hdLV8nT7KhbWZZf77X3vrOaOgWTHkFnRPhNjD64rxGCVcCQrM+JMhPlS UAzQ==
X-Gm-Message-State: AElRT7GEiEAbe3Vxamatk4hWXX3eH/GP7bsNUDO/FkLo9sAzDFJ9nwZ/ iKp2fEPuzMISYMQnOofOg41bqksKoRryGsUNFY4=
X-Google-Smtp-Source: AG47ELvV88mNHwmHRaOhpFEV66tMvsibp7Cu7YqXMa/0Yv6NAS/lebMRm3iQ1SKLq09bjgRoAwCdYTamcYehjrWXe/U=
X-Received: by 10.107.3.71 with SMTP id 68mr2352009iod.66.1520972448050; Tue, 13 Mar 2018 13:20:48 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.107.58.193 with HTTP; Tue, 13 Mar 2018 13:20:32 -0700 (PDT)
In-Reply-To: <CAF4+nEHzE1E-qWQS=X2T+3EXyDKhg_f1p74SS1NZd-8j3G5eRA@mail.gmail.com>
References: <152036910061.28346.1223384759329179194.idtracker@ietfa.amsl.com> <201803071355148877819@zte.com.cn> <D51EDB30-A8C2-446E-B263-318E2A96A650@cooperw.in> <CAF4+nEHzE1E-qWQS=X2T+3EXyDKhg_f1p74SS1NZd-8j3G5eRA@mail.gmail.com>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Tue, 13 Mar 2018 16:20:32 -0400
Message-ID: <CAF4+nEHMWfWdiE45dESoOb52VKeAn3_1_=9uw3VW2wk4WmaHcA@mail.gmail.com>
To: Alissa Cooper <alissa@cooperw.in>
Cc: Hu Fangwei <hu.fangwei@zte.com.cn>, IESG <iesg@ietf.org>, draft-ietf-trill-smart-endnodes@ietf.org, trill-chairs@ietf.org, Susan Hares <shares@ndzh.com>, trill IETF mailing list <trill@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/trill/NNJL41q4q6LeYRZoxCjcuxnVupA>
Subject: Re: [trill] Alissa Cooper's Discuss on draft-ietf-trill-smart-endnodes-10: (withDISCUSS and COMMENT)
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Mar 2018 20:20:51 -0000

Hi Alissa,

A -11 version of draft-ietf-trill-smart-endnodes has been uploaded
with the intent of resolving your discuss. Please look at it and see
if you can clear.

Thanks,
Donald
===============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 155 Beaver Street, Milford, MA 01757 USA
 d3e3e3@gmail.com


On Wed, Mar 7, 2018 at 2:35 PM, Donald Eastlake <d3e3e3@gmail.com>; wrote:
> On Wed, Mar 7, 2018 at 10:01 AM, Alissa Cooper <alissa@cooperw.in>; wrote:
>> Hi Fangwei,
>>
>> As I noted in response to the Gen-ART reviewer, I managed to ballot before
>> reading the rest of this thread (sorry!), but I still think the diagram in
>> 4.3 is confusing and not consistent with the text. To my eye row 3 shows
>> two
>> bytes’ worth of fields but the label says “4 bytes.” RSV is depicted as 2
>> bits but the text says it is 6 bits. The combination of these two
>> inconsistencies makes it hard to know what the actual lengths are supposed
>> to be.
>
> I agree that the figure is a little confusing. I suggest the following:
>
>     +-+-+-+-+-+-+-+-+
>     |Type=Smart-MAC |          (1 byte)
>     +-+-+-+-+-+-+-+-+
>     |   Length      |          (1 byte)
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-...+-+-+-+-+
>     |F|M|  RSV      |  VLAN/FGL Data Label         |  (4 bytes)
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-...+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>     |                          MAC (1)                (6 bytes)        |
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-...+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>     |                      .................                           |
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-...+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>     |                          MAC (N)                (6 bytes)        |
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-...+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>
> Thanks,
> Donald
> ===============================
>  Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
>  155 Beaver Street, Milford, MA 01757 USA
>  d3e3e3@gmail.com
>
>
>> Alissa
>>
>> On Mar 7, 2018, at 12:55 AM, hu.fangwei@zte.com.cn wrote:
>>
>> Hi,Alissa Cooper
>>
>> Thanks for your review and comments.
>>
>> The new version(version 10)  has updated to fix your comments.
>>
>> The format of Smart-MAC APP sub-TLV and the text  has been changed to the
>> following:
>>
>> The length of F,M,RSV,VLAN/FGL data Label is 4 bytes. and the length of
>> VLAN/FGL Data Label field is 24 bits.
>>
>>
>>    +-+-+-+-+-+-+-+-+
>>     |Type=Smart-MAC |                  (1 byte)
>>     +-+-+-+-+-+-+-+-+
>>     |   Length      |                  (1 byte)
>>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>>     |F|M|RSV|  VLAN/FGL Data Label  |  (4 bytes)
>>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-...+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>>     |                          MAC (1)       (6 bytes)                 |
>>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-...+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>>     |                      .................                           |
>>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-...+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>>     |                          MAC (N)       (6 bytes)                 |
>>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-...+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>>
>>                      Figure 3 Smart-MAC APPsub-TLV
>>
>>
>>    o  VLAN/FGL Data Label: 24bits.  If F is 1, this field is a 24-bit
>>       FGL Data Label for all subsequent MAC addresses in this APPsub-
>>       TLV.  Otherwise, if F is 0, the lower 12 bits is the VLAN of all
>>       subsequent MAC addresses in this APPsub-TLV, and the upper 12 bits
>>       is not used(sent as zero and ignored on receipt).  If there is no
>>       VLAN/FGL data label specified, the VLAN/FGL Data Label is zero.
>>
>>
>>
>>
>> Regards.
>>
>> Fangwei.
>>
>> 原始邮件
>> 发件人:AlissaCooper <alissa@cooperw.in>;
>> 收件人:The IESG <iesg@ietf.org>;
>> 抄送人:draft-ietf-trill-smart-endnodes@ietf.org
>> <draft-ietf-trill-smart-endnodes@ietf.org>trill-chairs@ietf.org
>> <trill-chairs@ietf.org>shares@ndzh.com <shares@ndzh.com>trill@ietf.org
>> <trill@ietf.org>;
>> 日 期 :2018年03月07日 04:45
>> 主 题 :Alissa Cooper's Discuss on draft-ietf-trill-smart-endnodes-10:
>> (withDISCUSS and COMMENT)
>> Alissa Cooper has entered the following ballot position for
>> draft-ietf-trill-smart-endnodes-10: Discuss
>>
>> When responding, please keep the subject line intact and reply to all
>> email addresses included in the To and CC lines. (Feel free to cut this
>> introductory paragraph, however.)
>>
>>
>> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
>> for more information about IESG DISCUSS and COMMENT positions.
>>
>>
>> The document, along with other ballot positions, can be found here:
>> https://datatracker.ietf.org/doc/draft-ietf-trill-smart-endnodes/
>>
>>
>>
>> ----------------------------------------------------------------------
>> DISCUSS:
>> ----------------------------------------------------------------------
>>
>> This should hopefully be easy to fix and was pointed out by the Gen-ART
>> reviewer:
>>
>> All of section 4.3 is confusing as to what the length of the TLV really
>> is.
>> Row 3 in the diagram says 2 bytes or 4 bytes, but the number of bits
>> called
>> out
>> in bullets 4 and 5 below it don't seem to add up to those things. Maybe it
>> would
>> be better to draw a diagram with F=0 and a separate diagram with F=1.
>>
>> Please make it clear both in the diagram and in the text what the expected
>> lengths of the fields are -- I find it particularly confusing that the
>> number
>> of bits pictured doesn't align with the number of bits specified in the
>> text
>> per field.
>>
>>
>> ----------------------------------------------------------------------
>> COMMENT:
>> ----------------------------------------------------------------------
>>
>> Please also look at the Gen-ART reviewer's other comments.
>>
>>
>>
>