[trill] Secdir last call review of draft-ietf-trill-centralized-replication-10

Joseph Salowey <joe@salowey.net> Sun, 10 December 2017 21:32 UTC

Return-Path: <joe@salowey.net>
X-Original-To: trill@ietf.org
Delivered-To: trill@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 99DE81241F5; Sun, 10 Dec 2017 13:32:37 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Joseph Salowey <joe@salowey.net>
To: <secdir@ietf.org>
Cc: trill@ietf.org, iesg@ietf.org, draft-ietf-trill-centralized-replication.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.67.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <151294155757.21877.6840749517796253347@ietfa.amsl.com>
Date: Sun, 10 Dec 2017 13:32:37 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/trill/Ny2imR_hk7_4Hu0vsg9HbCgkbX0>
Subject: [trill] Secdir last call review of draft-ietf-trill-centralized-replication-10
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.22
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Dec 2017 21:32:37 -0000

Reviewer: Joseph Salowey
Review result: Has Issues

I have reviewed this document as part of the security directorate's
ongoing effort to review all IETF documents being processed by the
IESG.  These comments were written primarily for the benefit of the
security area directors.  Document editors and WG chairs should treat
these comments just like any other last call comments.

Document is ready with issues.

I think the document has appropriate security considerations.

One issue I see in the document is that in the intro it states:
"The basic idea is that all ingress RBridges send BUM traffic to a centralized
node, which SHOULD be a distribution tree root, using unicast TRILL 
encapsulation." In section 3 it states : "The centralized node MUST be a
distribution tree root."

The MUST and SHOULD seem to be at odds here.