Re: [trill] [Gen-art] Genart telechat review of draft-ietf-trill-smart-endnodes-08

Alissa Cooper <alissa@cooperw.in> Tue, 06 March 2018 20:51 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DA88312D7E4; Tue, 6 Mar 2018 12:51:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.72
X-Spam-Level:
X-Spam-Status: No, score=-2.72 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=oZdNIHg2; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=bvibUetm
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CimbbTSWzmKo; Tue, 6 Mar 2018 12:51:12 -0800 (PST)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EA2C912AF84; Tue, 6 Mar 2018 12:51:11 -0800 (PST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 0B70220DF6; Tue, 6 Mar 2018 15:51:11 -0500 (EST)
Received: from frontend1 ([10.202.2.160]) by compute7.internal (MEProxy); Tue, 06 Mar 2018 15:51:11 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=6sCCv69bqa4F5gMsPqQi7yd9+ou/iEq8luNbMXAfEPg=; b=oZdNIHg2 TUmFSymMDGmo8ybn6Jr+GcN2NR2tKkeIO86fiMSWG1P4o2d6tohi+GvHBnTDjk2d EDyJ3zZjJMyTw4f8aFHrkQKHlLIiW/mTPjI8bTfo8O/tXAiPt9FB11+zD4r6NO4X 7vf++GoBxWzW6JU09ZmgSjnWZ9XGUSBanezD4Np9r3OaM4I1bP9pDIPvUc076Axt P/1Ue2hZu8exuzjOIiO1JnTnp525fiY8rTeaEZ1Ryb8o3Qp4PuSKGkhktD90mFBF F4j8dvTM9YbRfZYuFexHtmWF4l/uxK9LR1k0Nze70cXwrt1rVep8kfOGFXnKYOXk tDx0WG/reg2N0g==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=6sCCv69bqa4F5gMsPqQi7yd9+ou/i Eq8luNbMXAfEPg=; b=bvibUetmDr+/TwRkrXCE4JLOFXbKn75PZe+O4PJ9SHbZe audFfAXm5286aO5zffNmEbbcHuwCW22cPHQ5M0H2AwhXh/B/x1bxq6Kh4g6Hy/kl NMOCDJZm4Y235jpTsG9WIIUli/N6RB6Ns4pj3eA/TGK1Pr8y+mcxQ7e10j119wlJ GwWwBjOjfi60SLrPxML1h+zlXOuwl8YX29LstSe8mMtyfcBdmQoSMHT5ZqSrs9OZ JJ1QTe913DwYAiqqUwwONcDpwWjS0uYX0ujYsTvB/5ULCvzsVAc7S8Lcf5pKfnQ3 87g3wRa3aHJEBj/11r0K69Tefv3xXi9zq9ZVyN0xQ==
X-ME-Sender: <xms:Pv-eWvN5nmTKRUTGH5xmCIx2hkvE_UthcvpfTuOL14PiRll009uJ8g>
Received: from rtp-vpn3-1053.cisco.com (unknown [173.38.117.86]) by mail.messagingengine.com (Postfix) with ESMTPA id 3F4E27E3DC; Tue, 6 Mar 2018 15:51:10 -0500 (EST)
Content-Type: multipart/alternative; boundary="Apple-Mail=_24F88E49-1CB9-44DC-A57B-7383A583D40F"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <201803021146131973242@zte.com.cn>
Date: Tue, 6 Mar 2018 15:51:09 -0500
Cc: "gen-art@ietf.org Review Team" <gen-art@ietf.org>, draft-ietf-trill-smart-endnodes.all@ietf.org, trill IETF mailing list <trill@ietf.org>
Message-Id: <3F6C4422-014F-43C9-93BF-0CB33B1CC3AB@cooperw.in>
References: <151976308758.28489.12406772916405932448@ietfa.amsl.com> <201803021146131973242@zte.com.cn>
To: hu.fangwei@zte.com.cn, Robert Sparks <rjsparks@nostrum.com>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/trill/QgJjkZ38Q90knsVVf2dfPeqXbSI>
Subject: Re: [trill] [Gen-art] Genart telechat review of draft-ietf-trill-smart-endnodes-08
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Mar 2018 20:51:15 -0000

Robert, thanks for your review.

I managed to ballot before reading the rest of this thread (sorry!), but I still think the diagram in 4.3 is confusing and not consistent with the text. To my eye row 3 shows two bytes’ worth of fields but the label says “4 bytes.” RSV is depicted as 2 bits but the text says it is 6 bits. The combination of these two inconsistencies makes it hard to know what the actual lengths are supposed to be.

Thanks,
Alissa


> On Mar 1, 2018, at 10:46 PM, hu.fangwei@zte.com.cn wrote:
> 
> Hi, Sparks
> 
> Thanks for your review and comments.
> 
> A new version(version 10) draft is submitted to fix the issues.
> 
> Regards
> 
> Fangwei.
> 
> 
> 
> 
> 
> A new version of I-D, draft-ietf-trill-smart-endnodes-10.txt
> has been successfully submitted by Fangwei Hu and posted to the
> IETF repository.
> 
> Name:        draft-ietf-trill-smart-endnodes
> Revision:    10
> Title:        TRILL Smart Endnodes
> Document date:    2018-03-01
> Group:        trill
> Pages:        15
> URL:            https://www.ietf.org/internet-drafts/draft-ietf-trill-smart-endnodes-10.txt <https://www.ietf.org/internet-drafts/draft-ietf-trill-smart-endnodes-10.txt>
> Status:         https://datatracker.ietf.org/doc/draft-ietf-trill-smart-endnodes/ <https://datatracker.ietf.org/doc/draft-ietf-trill-smart-endnodes/>
> Htmlized:       https://tools.ietf.org/html/draft-ietf-trill-smart-endnodes-10 <https://tools.ietf.org/html/draft-ietf-trill-smart-endnodes-10>
> Htmlized:       https://datatracker.ietf.org/doc/html/draft-ietf-trill-smart-endnodes-10 <https://datatracker.ietf.org/doc/html/draft-ietf-trill-smart-endnodes-10>
> Diff:           https://www.ietf.org/rfcdiff?url2=draft-ietf-trill-smart-endnodes-10 <https://www.ietf.org/rfcdiff?url2=draft-ietf-trill-smart-endnodes-10>
> 
> Abstract:
>    This draft addresses the problem of the size and freshness of the
>    endnode learning table in edge RBridges, by allowing endnodes to
>    volunteer for endnode learning and encapsulation/decapsulation.  Such
>    an endnode is known as a "Smart Endnode".  Only the attached edge
>    RBridge can distinguish a "Smart Endnode" from a "normal endnode".
>    The smart endnode uses the nickname of the attached edge RBridge, so
>    this solution does not consume extra nicknames.  The solution also
>    enables Fine Grained Label aware endnodes.
> 
> 
> 
> 
> 原始邮件
> 发件人:RobertSparks <rjsparks@nostrum.com <mailto:rjsparks@nostrum.com>>
> 收件人:gen-art@ietf.org <mailto:gen-art@ietf.org> <gen-art@ietf.org <mailto:gen-art@ietf.org>>
> 抄送人:ietf@ietf.org <mailto:ietf@ietf.org> <ietf@ietf.org <mailto:ietf@ietf.org>>draft-ietf-trill-smart-endnodes.all@ietf.org <mailto:draft-ietf-trill-smart-endnodes.all@ietf.org> <draft-ietf-trill-smart-endnodes.all@ietf.org <mailto:draft-ietf-trill-smart-endnodes.all@ietf.org>>trill@ietf.org <mailto:trill@ietf.org> <trill@ietf.org <mailto:trill@ietf.org>>
> 日 期 :2018年02月28日 04:24
> 主 题 :[trill] Genart telechat review of draft-ietf-trill-smart-endnodes-08
> Reviewer: Robert Sparks
> Review result: Ready with Issues
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair. Please wait for direction from your
> document shepherd or AD before posting a new version of the draft.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>;.
> 
> Document: draft-ietf-trill-smart-endnodes-08
> Reviewer: Robert Sparks
> Review Date: 2018-02-27
> IETF LC End Date: 2018-03-06
> IESG Telechat date: 2018-03-08
> 
> Summary: Ready with issues
> 
> Major issues
> 
> 1) In section 4.3 the bullet describing the F bit does not parse. There are two
> instances of "Otherwise" that do not work together.
> 
> 2) All of section 4.3 is confusing as to what the length of the TLV really is.
> Row 3 in the diagram says 2 bytes or 4 bytes, but the number of bits called out
> in bullets 4 and 5 below it don't seem to add up to those things. Maybe it would
> be better to draw a diagram with F=0 and a separate diagram with F=1
> 
> 3) I think the security considerations section should call out again what an RB
> should do if it gets message that looks like it's from a SE, containing the
> right nickname, but the RB hasn't done the right Smart-Hello handshaking with
> that SE already. What would keep a lazy implementation (or one driven by
> product managers picking and choosing features) from just forwarding a message
> from a malicious element that just happened to know the RB's nickname?
> 
> Nits
> 
> Terminology: The definition of Transit RBridge says it's also named as a
> Transit Rbridge?
> 
> 
> _______________________________________________
> trill mailing list
> trill@ietf.org <mailto:trill@ietf.org>
> https://www.ietf.org/mailman/listinfo/trill <https://www.ietf.org/mailman/listinfo/trill>
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org <mailto:Gen-art@ietf.org>
> https://www.ietf.org/mailman/listinfo/gen-art <https://www.ietf.org/mailman/listinfo/gen-art>