Re: [trill] draft-ietf-trill-ia-appsubtlv-05.txt - Shepherd's review

Donald Eastlake <d3e3e3@gmail.com> Sun, 20 December 2015 18:06 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7299E1B2F4A for <trill@ietfa.amsl.com>; Sun, 20 Dec 2015 10:06:07 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.149
X-Spam-Level:
X-Spam-Status: No, score=0.149 tagged_above=-999 required=5 tests=[BAYES_20=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SLYeGk1h_T3W for <trill@ietfa.amsl.com>; Sun, 20 Dec 2015 10:06:06 -0800 (PST)
Received: from mail-ob0-x22d.google.com (mail-ob0-x22d.google.com [IPv6:2607:f8b0:4003:c01::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 122831B2F49 for <trill@ietf.org>; Sun, 20 Dec 2015 10:06:06 -0800 (PST)
Received: by mail-ob0-x22d.google.com with SMTP id iw8so109591080obc.1 for <trill@ietf.org>; Sun, 20 Dec 2015 10:06:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=C/MNxUkOOdSDOXVoZUaUqx0qGIuuB5nrilBjIag8ffI=; b=N2BQOpZeZ/hGh+lTOUNgJfBpenPSal8EPcr7vZuHB0YHXY1POuudbmf9UJfWjWGkZg /ybhwadxAzSj7+qeCY9o0yrfUv6mdfJhqwFQycs6FzD6OJjM++bErdSwv6WsmKJ0qiUx d/sCokqT79IeSta5h1cFZKmEoWLBO8g3dps1mlz+RrIxrui+E3jKeMo1lDSVxg7G/a53 ZRH+4ISIkOfGy68EOrcWfTxfMhWZbQI4Umur6WKM8zirCqb9AK+58RpQh8swFHy66n+8 Q6rfaJVZpHWL+koFrR0BPWMLzpQ6imOxCbbT/lVvtds5JZnp1TZbqvm7J6aTFNShH3j4 ELiQ==
X-Received: by 10.60.77.34 with SMTP id p2mr5612703oew.21.1450634765342; Sun, 20 Dec 2015 10:06:05 -0800 (PST)
MIME-Version: 1.0
Received: by 10.76.12.1 with HTTP; Sun, 20 Dec 2015 10:05:50 -0800 (PST)
In-Reply-To: <00a801d0fd57$0c2c5b40$248511c0$@ndzh.com>
References: <00a801d0fd57$0c2c5b40$248511c0$@ndzh.com>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Sun, 20 Dec 2015 13:05:50 -0500
Message-ID: <CAF4+nEGMdnjqgKyBgKksGfXBarEQ+RdzzGk++7iJtaO_LZu6Ug@mail.gmail.com>
To: Susan Hares <shares@ndzh.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Archived-At: <http://mailarchive.ietf.org/arch/msg/trill/RnbMobG6zI1aV8ViTKbOA1QM8q8>
Cc: Jon Hudson <jon.hudson@gmail.com>, "trill-chairs@tools.ietf.org" <trill-chairs@tools.ietf.org>, "trill@ietf.org" <trill@ietf.org>
Subject: Re: [trill] draft-ietf-trill-ia-appsubtlv-05.txt - Shepherd's review
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Dec 2015 18:06:07 -0000

Hi Sue,

Thanks for the comments.

On Fri, Oct 2, 2015 at 5:12 PM, Susan Hares <shares@ndzh.com>; wrote:
> Shepherd’s review:  draft-ietf-trill-ia-appsubtlv-05
>
> Authors: Donald Eastlake and Yizhou Li
>
> Status: Major concern on complexity of AFN template concepts. This
> concern has been expressed to authors who will revise the draft. The
> text for the AFN Template is covered in Section 2 and section 3.

The draft has been simplified.

> Note: IANA previewed section 5, and agreed to it.
>
> Minor Technical issues: none
>
> Editorial issues
>
> #1 Abstract:
>
> Current
>    This document specifies a TRILL (Transparent Interconnection of
>    Lots of Links) IS-IS application sub-TLV that enables the
>    reporting by a TRILL switch of sets of addresses such that all of
>    the addresses in each set designate the same interface (port) and
>    the reporting for such a set of the TRILL switch by which it is
>    reachable.
>
> New suggested:
>    This document specifies a TRILL (Transparent Interconnection of
>    Lots of Links) IS-IS application sub-TLV that enables the
>    reporting by a TRILL switch of sets of addresses. Each set of
>    addresses reports addresses the same interface (port) and the
>    TRILL switch by which it reachable.

A change along those lines has been made.

> #2 – Section 2 – paragraph 1 p. 5
>
> Please enumerate or point to where the enumeration of the types of
> addresses.

The current text lists IPv4, IPv6, and 48-bit MAC addresses. The
following sentence has been added: "While those three types of address
are likely to be the only types of interest, any address type for
which an AFN (Address Family Number) has been assigned by IANA can be
represented."

> #3 Section 2 – page 6
>
> Current:
>
>  Addr Sets End: The unsigned integer offset of the byte, within the  IA
> APPsub-TLV value part, of the last byte of the last Address  Set. This will
> be the byte just before the first sub-sub-TLV if  any sub-sub-TLVs are
> present (see Section 3). If this is equal to  Length, there are no
> sub-sub-TLVs. If this is greater than Length or points to before the end of
> the Template, the IA APPsub-TLV is corrupt and MUST be discarded. This field
> is always two bytes in size.
>
> New
>
> Addr Sets End: The unsigned integer offset of the byte, within the IA
> APPsub-TLV value part, of the last byte of the last Address  Set. This byte
> will be the byte just before the first sub-sub-TLV if  any sub-sub-TLVs are
> present (see Section 3). The processing is as follows:
>
> ·         If this is equal to  Length, there are no sub-sub-TLVs.
>
> ·         If this is greater than Length or points to before the end of the
> Template, the IA APPsub-TLV is corrupt and MUST be discarded.
>
> ·         Note: This field is always two bytes in size.

OK.

> #3 – page 7 paragraph 3
>
>         N: Notify flag: When a TRILL switch receives a new IA APPsub-
>             TLV (one in an ESADI-LSP fragment with a higher sequence
>             number or a new message of some other type) and the N bit is
>             one, the TRILL switch then checks the contents of the
>             APPsub-TLV for address sets including both an IP address and
>             a MAC address.  For each such address set it finds, a
>             gratuitous ARP [RFC826] or spontaneous Neighbor
>             Advertisement [RFC4861], depending on whether the IP address
>             is IPv4 or IPv6 respectively, may be sent. In both cases,
>             these are sent out all the ports of the TRILL switch
>             offering end station service and are in the VLAN or FGL of
>             the address set information, that is, are Appointed
>             Forwarder for the VLAN or for the VLAN to which the FGL
>             maps.
>
> What needs changing:
>
> Old: /and are in the VLAN or FGL of/
> New: /which are in the VLAN or FGL of/  - I believe the dependent “which”
> clause is more appropriate here.

OK.

A new version -06 has been posted.

Thanks,
Donald
=============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 155 Beaver Street, Milford, MA 01757 USA
 d3e3e3@gmail.com