[trill] Nits on draft-ietf-trill-rbridge-extension
Erik Nordmark <nordmark@acm.org> Sun, 29 April 2012 03:37 UTC
Return-Path: <nordmark@acm.org>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E202921F855F for <trill@ietfa.amsl.com>; Sat, 28 Apr 2012 20:37:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.599
X-Spam-Level:
X-Spam-Status: No, score=-102.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sIvi8TDGa4Te for <trill@ietfa.amsl.com>; Sat, 28 Apr 2012 20:37:46 -0700 (PDT)
Received: from a.mail.sonic.net (a.mail.sonic.net [64.142.16.245]) by ietfa.amsl.com (Postfix) with ESMTP id 65F2321F8555 for <trill@ietf.org>; Sat, 28 Apr 2012 20:37:46 -0700 (PDT)
Received: from [10.21.77.4] (128-107-239-233.cisco.com [128.107.239.233]) (authenticated bits=0) by a.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with ESMTP id q3T3bhBt008772 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 28 Apr 2012 20:37:44 -0700
Message-ID: <4F9CB786.4090603@acm.org>
Date: Sat, 28 Apr 2012 20:37:42 -0700
From: Erik Nordmark <nordmark@acm.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20120420 Thunderbird/12.0
MIME-Version: 1.0
To: trill@ietf.org
References: <4F9A342F.8050608@acm.org>
In-Reply-To: <4F9A342F.8050608@acm.org>
X-Forwarded-Message-Id: <4F9A342F.8050608@acm.org>
Content-Type: text/plain; charset="ISO-8859-1"; format="flowed"
Content-Transfer-Encoding: 7bit
Subject: [trill] Nits on draft-ietf-trill-rbridge-extension
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/trill>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Apr 2012 03:37:47 -0000
I have a few nits from reading the document as part of preparing to send it to the IESG. Would it make sense to fix these before we send it in? Section 2 says: If Op-Length is zero there is no header extension present; else, this area follows immediately after the Ingress Rbridge Nickname field of the TRILL Header. That is a bit confusing, since "area" isn't used earlier in the text. Either the prior sentence should say "extensions area", or the above should say "the extensions follows". I think it would be useful to mention that these two are specified in 6325 (but without the 'S' being part of their names): 0-3 Crit.: Critical summary bits. 0 CHbHS: Critical Hop-by-Hop extension(s) are present. 1 CItES: Critical Ingress-to-Egress extension(s) are present. Typo in section 2.3.1: Should be "CHbHS" critical hop-by-hop extensions, MUST drop the frame. If the CHbH And many more lines have missing 'S': CItES: If the CItE (Critical Ingress to Egress Summary) bit is a one, extensions area. If the CItE bit is zero, no such extensions are present. If either CHbH or CItE is non-zero, egress RBridges that If both CHbH and CItE are zero, the frame is safe, from the point Section 2.3.2 seems to just repeat what is in section 2.3. The document seems to use two different names for the 32 bits: "Extension Header Flags" and "Extended Header Flags". I don't know by what name other draft refer to this field. Thanks, Erik
- [trill] Nits on draft-ietf-trill-rbridge-extension Erik Nordmark
- Re: [trill] Nits on draft-ietf-trill-rbridge-exte… Donald Eastlake