Re: [trill] Tsvart last call review of draft-ietf-trill-ecn-support-04

Donald Eastlake <d3e3e3@gmail.com> Mon, 05 February 2018 02:44 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8A27912422F; Sun, 4 Feb 2018 18:44:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.45
X-Spam-Level:
X-Spam-Status: No, score=-2.45 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EyVyTlSFujo1; Sun, 4 Feb 2018 18:44:31 -0800 (PST)
Received: from mail-oi0-x233.google.com (mail-oi0-x233.google.com [IPv6:2607:f8b0:4003:c06::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 07C781200C1; Sun, 4 Feb 2018 18:44:28 -0800 (PST)
Received: by mail-oi0-x233.google.com with SMTP id j15so17029706oii.5; Sun, 04 Feb 2018 18:44:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=QkoRyU5WLtLUt+P+4+//sCISe6tTKn7d8Pcoekk1ViU=; b=clxkT89AhINiW8KE1nClM4oLYDp5WIKKHcec8lq3PKdvpLqU8E8e7C9h6HIWzGCGIG FVtFUC972YKpcqgzkdmuGi+WHXslWd/wFGPumiyjC/1FqzTVdxHV5G5HDC3dl3RAoqMH xpggCKND8MR8C9kdzLz2nvVJ7h2zcJHt2Jy10Ks92J4yx6bL/QhglT0lPxpRviN//Ps/ /QYDljnCtJYoTxZejUu88zzmVmeV3O+1YqzlREJcW/3Wb2/Fal0AQEt3an3kyjw2Pb/D nwQKxGfbMa9dr+2LRzaRenuiVPznU3tTLUi9qOCsKdn2NNV9orXoxPeobVfh+Z0YPT2n WOHg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=QkoRyU5WLtLUt+P+4+//sCISe6tTKn7d8Pcoekk1ViU=; b=fEas1T7ae9Vzr+AMoOaIq6b4QuqNKk0/NILDGAFMDrhNxIpts5TqNK/aPme0IAs7QG mpc8d07MGub2R5vJ7V4E5ak8nnN+2wYD1CTafLHWS8BoB/PHodVY0eAlyppXkz45Uf29 kDnU1rG644qyrc8e3AwfvKdFpF+hG1SRLS7GZBXVslLfEcsq63+oVprPpbLJtVOtyTPR 75GrtdVZ0Eve54MC8JEn6gIM11uJaow76tbXyRWnFPd5YMsOsSyzrhk06jOUfzBNgLwO PeA9+piVIgiOOrDvcmrdc9VG1VygaI+mxoYsCVtAlUjrzHCloSvqgI7naGPkgKAgze0j zeAA==
X-Gm-Message-State: AKwxytfUMnsY90MWhj0fg+o4xrjRIOjHyzgSD8ob//v4sMVu9n8SpVmD EVkifIFiRVtpI1xMTUl0UKjYO6MrdncSn+gYZGc=
X-Google-Smtp-Source: AH8x225UT9KnAtTk6ZU8zqpb24MopxGs5+TolvNhkOCMheWD1vB/RAM8+3/TSv0+7LztaOacbOO72XK6pGNBD5LPwjk=
X-Received: by 10.202.80.79 with SMTP id e76mr19948319oib.304.1517798667315; Sun, 04 Feb 2018 18:44:27 -0800 (PST)
MIME-Version: 1.0
Received: by 10.168.67.205 with HTTP; Sun, 4 Feb 2018 18:44:11 -0800 (PST)
In-Reply-To: <151777044483.12244.16174801155565406521@ietfa.amsl.com>
References: <151777044483.12244.16174801155565406521@ietfa.amsl.com>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Sun, 4 Feb 2018 21:44:11 -0500
Message-ID: <CAF4+nEESTEEHCpPwT20Yw6vmj-36sqQXRj6-JC0=uxqr4Q6how@mail.gmail.com>
To: =?UTF-8?Q?Michael_T=C3=BCxen?= <tuexen@fh-muenster.de>
Cc: tsv-art@ietf.org, draft-ietf-trill-ecn-support.all@ietf.org, IETF Discussion <ietf@ietf.org>, trill@ietf.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/trill/T71Khhg_4rC_taRO1PsOMSXIRz4>
Subject: Re: [trill] Tsvart last call review of draft-ietf-trill-ecn-support-04
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Feb 2018 02:44:34 -0000

Hi Michael,

Thanks for the comments, see below.

On Sun, Feb 4, 2018 at 1:54 PM, Michael Tüxen <tuexen@fh-muenster.de> wrote:
> Reviewer: Michael Tüxen
> Review result: Ready with Nits
>
> I've reviewed this document as part of the transport area directorate's ongoing
> effort to review key IETF documents. These comments were written primarily for
> the transport area directors, but are copied to the document's authors for
> their information and to allow them to address any issues raised.
> When done at the time of IETF Last Call, the authors should consider this
> review together with any other last-call comments they receive.
> Please always CC tsv-art@ietf.org if you reply to or forward this review.
>
> This draft is basically ready for publication, but has nits that should be fixed before publication.
>
> Nits:
>
> Section 1:
>
> Old text:
> This can improve network efficiency through better flow
> control without packet drops.
>
> New text:
> This can improve network efficiency through better congestion
> control without packet drops.

OK.

> Old text:
> This specification provides for any ECN marking in the traffic at the
> ingress to be copied into the TRILL Extension Header Flags Word.
>
> New Text:
> This specification specifies for any ECN marking in the traffic at the
> ingress to be copied into the TRILL Extension Header Flags Word.

Well, it specifies how to copy the ECN marking for any traffic and it
mandates that it be copied from IP traffic but it doesn't and can't
mandate that it be copied from all arbitrary protocols that might have
ECN marking...  Also, I don't like "... specification specifies ..."

How about:
"This document specifies how ECN marking in traffic at the ingress is
copied into the TRILL Extension Header Flags Word and requires such
copying for IP traffic."

> Section 2:
>
> Old text:
> after the Extesnion Flags Word.
>
> New text:
> after the Extension Flags Word

OK.

> Section 3.3
>
> Please define "3-bit ECN codepoint" and refer to Table 3 BEFORE using it.
> This might result in swapping Table 2 and Table 3.

We'll look into doing that.

Thanks,
Donald
===============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 155 Beaver Street, Milford, MA 01757 USA
 d3e3e3@gmail.com