Re: [trill] Tsvart last call review of draft-ietf-trill-ecn-support-04

Michael Tuexen <tuexen@fh-muenster.de> Mon, 05 February 2018 11:19 UTC

Return-Path: <tuexen@fh-muenster.de>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 580011201F2; Mon, 5 Feb 2018 03:19:18 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GILwC6ytjOFu; Mon, 5 Feb 2018 03:19:15 -0800 (PST)
Received: from drew.franken.de (mail-n.franken.de [193.175.24.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D6E23129C6F; Mon, 5 Feb 2018 03:19:14 -0800 (PST)
Received: from [IPv6:2a02:c6a0:4015:12:6de3:5070:7645:f98a] (unknown [IPv6:2a02:c6a0:4015:12:6de3:5070:7645:f98a]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTPSA id 3F8F1721E281A; Mon, 5 Feb 2018 12:19:11 +0100 (CET)
From: Michael Tuexen <tuexen@fh-muenster.de>
Message-Id: <0E05A4D3-C551-4C95-B89D-8D6F9A4CE844@fh-muenster.de>
Content-Type: multipart/signed; boundary="Apple-Mail=_AD80341A-C5A8-4519-8984-269AC14F50BD"; protocol="application/pkcs7-signature"; micalg=sha1
Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\))
Date: Mon, 5 Feb 2018 12:19:03 +0100
In-Reply-To: <CAF4+nEESTEEHCpPwT20Yw6vmj-36sqQXRj6-JC0=uxqr4Q6how@mail.gmail.com>
Cc: tsv-art@ietf.org, draft-ietf-trill-ecn-support.all@ietf.org, IETF Discussion <ietf@ietf.org>, trill@ietf.org
To: Donald Eastlake <d3e3e3@gmail.com>
References: <151777044483.12244.16174801155565406521@ietfa.amsl.com> <CAF4+nEESTEEHCpPwT20Yw6vmj-36sqQXRj6-JC0=uxqr4Q6how@mail.gmail.com>
X-Mailer: Apple Mail (2.3445.5.20)
Archived-At: <https://mailarchive.ietf.org/arch/msg/trill/XvoYHIxoR1DW1lzIUkelSVFYrWE>
Subject: Re: [trill] Tsvart last call review of draft-ietf-trill-ecn-support-04
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Feb 2018 11:19:18 -0000

> On 5. Feb 2018, at 03:44, Donald Eastlake <d3e3e3@gmail.com> wrote:
> 
> Hi Michael,
> 
> Thanks for the comments, see below.
> 
> On Sun, Feb 4, 2018 at 1:54 PM, Michael Tüxen <tuexen@fh-muenster.de> wrote:
>> Reviewer: Michael Tüxen
>> Review result: Ready with Nits
>> 
>> I've reviewed this document as part of the transport area directorate's ongoing
>> effort to review key IETF documents. These comments were written primarily for
>> the transport area directors, but are copied to the document's authors for
>> their information and to allow them to address any issues raised.
>> When done at the time of IETF Last Call, the authors should consider this
>> review together with any other last-call comments they receive.
>> Please always CC tsv-art@ietf.org if you reply to or forward this review.
>> 
>> This draft is basically ready for publication, but has nits that should be fixed before publication.
>> 
>> Nits:
>> 
>> Section 1:
>> 
>> Old text:
>> This can improve network efficiency through better flow
>> control without packet drops.
>> 
>> New text:
>> This can improve network efficiency through better congestion
>> control without packet drops.
> 
> OK.
> 
>> Old text:
>> This specification provides for any ECN marking in the traffic at the
>> ingress to be copied into the TRILL Extension Header Flags Word.
>> 
>> New Text:
>> This specification specifies for any ECN marking in the traffic at the
>> ingress to be copied into the TRILL Extension Header Flags Word.
> 
> Well, it specifies how to copy the ECN marking for any traffic and it
> mandates that it be copied from IP traffic but it doesn't and can't
> mandate that it be copied from all arbitrary protocols that might have
> ECN marking...  Also, I don't like "... specification specifies ..."
> 
> How about:
> "This document specifies how ECN marking in traffic at the ingress is
> copied into the TRILL Extension Header Flags Word and requires such
> copying for IP traffic."
OK.
> 
>> Section 2:
>> 
>> Old text:
>> after the Extesnion Flags Word.
>> 
>> New text:
>> after the Extension Flags Word
> 
> OK.
> 
>> Section 3.3
>> 
>> Please define "3-bit ECN codepoint" and refer to Table 3 BEFORE using it.
>> This might result in swapping Table 2 and Table 3.
> 
> We'll look into doing that.
Great. Thanks.

Best regards
Michael
> 
> Thanks,
> Donald
> ===============================
> Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
> 155 Beaver Street, Milford, MA 01757 USA
> d3e3e3@gmail.com