Re: [trill] [Lime] Adoption call for draft-deepak-trill-yang-pm (12/15/2014 to 12/30/2014)

Qin Wu <bill.wu@huawei.com> Mon, 22 December 2014 06:57 UTC

Return-Path: <bill.wu@huawei.com>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 430A91A89E1; Sun, 21 Dec 2014 22:57:59 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.76
X-Spam-Level:
X-Spam-Status: No, score=-1.76 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, MIME_CHARSET_FARAWAY=2.45, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2FQYf7dQJp1X; Sun, 21 Dec 2014 22:57:56 -0800 (PST)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CD8021A89E9; Sun, 21 Dec 2014 22:57:55 -0800 (PST)
Received: from 172.18.7.190 (EHLO lhreml404-hub.china.huawei.com) ([172.18.7.190]) by lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id BNE06517; Mon, 22 Dec 2014 06:57:54 +0000 (GMT)
Received: from NKGEML406-HUB.china.huawei.com (10.98.56.37) by lhreml404-hub.china.huawei.com (10.201.5.218) with Microsoft SMTP Server (TLS) id 14.3.158.1; Mon, 22 Dec 2014 06:57:53 +0000
Received: from NKGEML501-MBS.china.huawei.com ([169.254.2.169]) by nkgeml406-hub.china.huawei.com ([10.98.56.37]) with mapi id 14.03.0158.001; Mon, 22 Dec 2014 14:57:46 +0800
From: Qin Wu <bill.wu@huawei.com>
To: "Deepak Kumar (dekumar)" <dekumar@cisco.com>
Thread-Topic: [Lime] Adoption call for draft-deepak-trill-yang-pm (12/15/2014 to 12/30/2014)
Thread-Index: AQHQGUF6/WOP1Fhje0+CoFsx+BCs6pyR3n+AgAlRgjA=
Date: Mon, 22 Dec 2014 06:57:45 +0000
Message-ID: <B8F9A780D330094D99AF023C5877DABA84697A5E@nkgeml501-mbs.china.huawei.com>
References: <C242F93D-D95C-4612-B565-357D21EC2382@cisco.com> <D0B59A2C.A1134%dekumar@cisco.com>
In-Reply-To: <D0B59A2C.A1134%dekumar@cisco.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.138.41.180]
Content-Type: multipart/alternative; boundary="_000_B8F9A780D330094D99AF023C5877DABA84697A5Enkgeml501mbschi_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: http://mailarchive.ietf.org/arch/msg/trill/_Jn_YCuOtWg3lt-mN6dD_Tk3v1A
Cc: "lime@ietf.org" <lime@ietf.org>, "trill@ietf.org" <trill@ietf.org>
Subject: Re: [trill] [Lime] Adoption call for draft-deepak-trill-yang-pm (12/15/2014 to 12/30/2014)
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Dec 2014 06:57:59 -0000

Hi, Deepak:
Additional comments from my side:

1.       Abstract
The reference [TRILLOAMPM] doesn’t exist, suggest to remove it or reference to RFC7174.

2.       Abstract

Is this model a extension to TRILL OAM YANG model or Generic YANG model provided by [GENYANGOAM]?

3.       Introduction section, last paragraph said the model is defined by defining the YANG model in [GENYANGOAM], the abstract said

This model defined in this document extends from TRILL OAM YANG model, which one is correct, please make sure the consistency between texts in different places.



4.       Introduction section

This reference [TRILLOAMFM] is outdated, are you referred to RFC7174? Also this referenced is missed in the references section.
The [TRILLOAMPM] doesn’t exist



5.       Section 4.4

How is grouping statements in the second paragraph are related to rpc command? It seems the second paragraph in the section 4.4 is disconnected from the first paragraph and the last paragraph?



6.       Section 4 said, the 1st paragraph said:

“

TRILL OAM PM Yang is extended to augment MEP Configuration with

Performance Management configuration and statistics for Delay

Measurement and Performance Measurement.

”

What is extended? TRILL OAM PM YANG or TRILL OAM YANG?



7. Section 4 TRILL PM data hierarchy

The section number should be section 5.

Regards!
-Qin
发件人: Lime [mailto:lime-bounces@ietf.org] 代表 Deepak Kumar (dekumar)
发送时间: 2014年12月17日 0:16
收件人: Carlos Pignataro (cpignata); Susan Hares
抄送: Donald Eastlake; trill@ietf.org; lime@ietf.org; jon.hudson@gmail.com
主题: Re: [Lime] Adoption call for draft-deepak-trill-yang-pm (12/15/2014 to 12/30/2014)

Thanks for comments. I will fix them and submit new version of draft for review.

Thanks,
Deepak

From: "Carlos Pignataro (cpignata)" <cpignata@cisco.com<mailto:cpignata@cisco.com>>
Date: Tuesday, December 16, 2014 7:03 AM
To: Susan Hares <shares@ndzh.com<mailto:shares@ndzh.com>>
Cc: "d3e3e3@gmail.com<mailto:d3e3e3@gmail.com>" <d3e3e3@gmail.com<mailto:d3e3e3@gmail.com>>, "jon.hudson@gmail.com<mailto:jon.hudson@gmail.com>" <jon.hudson@gmail.com<mailto:jon.hudson@gmail.com>>, "lime@ietf.org<mailto:lime@ietf.org>" <lime@ietf.org<mailto:lime@ietf.org>>, "trill@ietf.org<mailto:trill@ietf.org>" <trill@ietf.org<mailto:trill@ietf.org>>
Subject: Re: [Lime] Adoption call for draft-deepak-trill-yang-pm (12/15/2014 to 12/30/2014)

Sue, Jon,

I have a few concerns with this document:

  *   The Abstract says “It extends Yang Data Model for TRILL OAM [TRILLOAMYANG]”, however, [TRILLOAMYANG] is listed as an Informative reference ― I believe it should be Normative (all the definitions are coming from it, and this doc extends that model)

     *   It seems the same issue exists with draft-ietf-trill-yang-oam and [GENYANGOAM], which should be Normative there.
     *   By the way, a nit as well (the Abstract includes citations).

  *   Ditto for [GENYANGOAM], as the text says “In this document we extend the YANG model defined in [GENYANGOAM]”
  *   There’s a non-insignificant set of Nits which frankly should be taken care of before this call for adoption (see http://www.ietf.org/tools/idnits?url=http://www.ietf.org/archive/id/draft-deepak-trill-yang-pm-00.txt)

     *   This severely detracts from readability.

I believe these are blocking for adoption.

Thanks,

Carlos.

On Dec 15, 2014, at 11:05 PM, Susan Hares <shares@ndzh.com<mailto:shares@ndzh.com>> wrote:

This begins a 2 week WG adoption call for draft-deepak-trill-yang-pm-00 which can be found at:

http://datatracker.ietf.org/doc/draft-deepak-trill-yang-pm/

This draft will be reviewed along with other yang modules at the 12/17/2014 interim of trill held from 9-10pm ET (6-7pm PT, 10-11am Beijing on 12/18/2014).  In your review, please indicate the following:  a) if this yang module provides information necessary to manage or monitor TRILL, and b) if you support adoption this work into the TRILL WG.

Sue Hares and Jon Hudson
Co-chairs


_______________________________________________
Lime mailing list
Lime@ietf.org<mailto:Lime@ietf.org>
https://www.ietf.org/mailman/listinfo/lime