Re: [trill] [RTG-DIR] Routing directorate QA review of draft-ietf-trill-rbridge-multilevel

Donald Eastlake <d3e3e3@gmail.com> Thu, 26 May 2016 04:23 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B70D812D597; Wed, 25 May 2016 21:23:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.45
X-Spam-Level:
X-Spam-Status: No, score=-2.45 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cMHU52ozyigk; Wed, 25 May 2016 21:23:38 -0700 (PDT)
Received: from mail-oi0-x22e.google.com (mail-oi0-x22e.google.com [IPv6:2607:f8b0:4003:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BD31812D583; Wed, 25 May 2016 21:23:38 -0700 (PDT)
Received: by mail-oi0-x22e.google.com with SMTP id w184so99666908oiw.2; Wed, 25 May 2016 21:23:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8vMX3CT74DO7+kK2o4bSSppsLnQb9KpBysYMQqMH/ns=; b=TtbdfYN1a2IB51EjBA1sDL3EWvHuMAYNRrOIUl3jNvNV5bbZZzTDPWQV5Gxtpm8IfD iW12ymDgk19GUhihD2h3NVRm9CTr6rWO/3+lBnYv//dize2QCP2S4HoMJcZijjOrHgOe yy8aSS2BNDq8FBPlDGXLmAX5UmO4CncqMAmvI3iYmsd7gQe42dME9uWTzu8BQkhKJIFm fNwiPScUFphkAPkK2wA9pig+1pEn/SGuWvTQLR/heQw9CuJ1ggpbaAUwcginObtY7/6L 2fhQneQQwVIJ31DDHPlERsyB41MMdRYZsRWWhocy8qct6FF4VFposGNlJ8/3uhUTvtI6 Ym+A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8vMX3CT74DO7+kK2o4bSSppsLnQb9KpBysYMQqMH/ns=; b=HD0eq3vwm31V0G25DxA3nZPJwGb9mKrC6k6SDKyL9x2xGZZVOGCX2kQfRvc1WQkFFq tNXRyb1x7mTCLlRu1ekUU70A2UzbVlAOBoEgCztMBbXdVoT9wgXF6/jrykoP4Q3B8oqH 0mx3E+nggJUh3YKJIdLpLpTRAkvU6iBN3XkZMTOcfjgbq8VkHC4QE/rMgJUTO+UN9Vb4 mDMsEyre9u43kMxLQTdNet643cx0qrvtqGNJcXOgFHn3H7p06Y2p+uX1kJ+SSggSd8qQ TukUxfH465pGZkkXUkRF8NHr3Plz4PRw3udNFbJf91HxluXvM86wlvEzYt/GxhyDjUlH m/Ag==
X-Gm-Message-State: ALyK8tKtIttHHvN8bBAN1mYlcns1p3uLHp8lLbthbwu5QWXyKU+/r0XN4hpWqZSC9CaUCD7/vqfY/X7meqwARA==
X-Received: by 10.202.65.133 with SMTP id o127mr4799138oia.43.1464236618065; Wed, 25 May 2016 21:23:38 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.157.22.249 with HTTP; Wed, 25 May 2016 21:23:23 -0700 (PDT)
In-Reply-To: <CAG4d1rfmtXrv2sgJ5XDANy+y3vUR0n1Wojr67fN=Asq0CFOseQ@mail.gmail.com>
References: <BY2PR0201MB19102373A5380FF07B9F5899847C0@BY2PR0201MB1910.namprd02.prod.outlook.com> <CAHANBtJHFOngQB5+uzray94YvL4=47ddpoVGM1kW0tdsS-_W1A@mail.gmail.com> <CAG4d1rfmtXrv2sgJ5XDANy+y3vUR0n1Wojr67fN=Asq0CFOseQ@mail.gmail.com>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Thu, 26 May 2016 00:23:23 -0400
Message-ID: <CAF4+nEH-gXsOMvwtOPzJ-077Fmjt3Rm75m_FfcGfWiVXHT=UxA@mail.gmail.com>
To: Stig Venaas <stig@venaas.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <http://mailarchive.ietf.org/arch/msg/trill/a4ONtfL_5TsQZt_muasT47TAFj0>
Cc: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "Zhangxian (Xian)" <zhang.xian@huawei.com>, Alia Atlas <akatlas@gmail.com>, "trill@ietf.org" <trill@ietf.org>, Jonathan Hardwick <Jonathan.Hardwick@metaswitch.com>, Susan Hares <shares@ndzh.com>, Jon Hudson <jon.hudson@gmail.com>
Subject: Re: [trill] [RTG-DIR] Routing directorate QA review of draft-ietf-trill-rbridge-multilevel
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 26 May 2016 04:23:41 -0000

Hi Stig,

On Wed, May 25, 2016 at 3:26 PM, Alia Atlas <akatlas@gmail.com> wrote:
> Stig,
>
> Thank you very much for your review.  I'm also forwarding it to trill so
> that the WG can see it.
>
> Regards,
> Alia
>
> On Wed, May 25, 2016 at 2:28 PM, Stig Venaas <stig@venaas.com> wrote:
>>
>> Hi
>>
>> Sorry for being a bit late with this review. At least the document is
>> well written and easy to understand. There are no significant issues.
>>
>> I am wondering about the security considerations though. Are there
>> really no differences between the multi-level alternatives when it
>> comes to security?

Well, I guess a couple sentences could be added that the choice of
using aggregated nicknames, and the resulting possible duplication of
nicknames between areas, increases the possibility of a TRILL Data
packet being delivered to the wrong egress RBridge if areas are
suddenly merged. However, is many cases the data would be discarded at
that egress because it would not match a known end station data label
/ MAC address.

>> I have two tiny editorial comments.
>>
>> Section 1.4 typo
>> RBridge - Routing Bridge, an alterntive name for a TRILL switch
>>                                                ^^^^^^^^^

OK,

>> Also, several places it says "non-zero" which is correct, but there
>> are some instances of "nonzero".

Apparently both of those are correct but I agree the draft should use
one of them consistently. I'll replace the two instances of nonzero
with the hyphenated form.

Thanks,
Donald
===============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 155 Beaver Street, Milford, MA 01757 USA
 d3e3e3@gmail.com

>> Stig
>>
>>
>> On Wed, May 4, 2016 at 11:52 PM, Jonathan Hardwick
>> <Jonathan.Hardwick@metaswitch.com> wrote:
>> > Hi Stig
>> >
>> >
>> >
>> > Please would you do a routing directorate QA review of
>> > draft-ietf-trill-rbridge-multilevel?
>> >
>> > https://datatracker.ietf.org/doc/draft-ietf-trill-rbridge-multilevel/
>> >
>> >
>> >
>> > Note that this is a “QA review.” The document is still being worked on
>> > by
>> > the TRILL working group.  The goal of this review is to provide a
>> > different
>> > perspective on the work and to improve its quality. Hence, your comments
>> > will be provided primarily for the benefit of the TRILL chairs and the
>> > document authors.
>> >
>> >
>> >
>> > Please could you provide your comments by May 20 and copy your comments
>> > to
>> > the rtg-dir list?
>> >
>> >
>> >
>> > The following web page contains a briefing on the QA process, and
>> > guidance
>> > for the QA reviewer.
>> >
>> > https://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDirDocQa
>> >
>> >
>> >
>> > Please let me know whether you can do it, or not.
>> >
>> >
>> >
>> > Many thanks
>> >
>> > Jon
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>>
>
>
> _______________________________________________
> trill mailing list
> trill@ietf.org
> https://www.ietf.org/mailman/listinfo/trill
>