Re: [trill] [Gen-art] Genart telechat review of draft-ietf-trill-over-ip-15

Alissa Cooper <alissa@cooperw.in> Thu, 08 March 2018 18:22 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 45B3A12706D; Thu, 8 Mar 2018 10:22:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=YDrWeUF+; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=Ek3NT0t4
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DXvvfnQu_Vs6; Thu, 8 Mar 2018 10:22:27 -0800 (PST)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1BA061243F6; Thu, 8 Mar 2018 10:22:27 -0800 (PST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 17A8D21004; Thu, 8 Mar 2018 13:22:23 -0500 (EST)
Received: from frontend2 ([10.202.2.161]) by compute7.internal (MEProxy); Thu, 08 Mar 2018 13:22:23 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=h/tdmLyDeGRWKERovb02sAl+r2rVH ONZOymgNDvRypg=; b=YDrWeUF+hss37Xd6pGo/dQK+pacTxBC/uxFSqQ6rkhVmX GnHB0yzEg+YRa/POqTl+hYXBWN5HB3JUojmIGtJFNemS71bmMgwVlx87SNIZjeiA q8Ep9RCjuZt5pxbSYRqIXMqmiHVk8ufYv3t3b1/7PQKw3geOFCtAWnp3wNiJuOsO aUk3vgjseZJF+mGf/iWYJ8Ovf9M3VgYuW5vdfGLmKUeV3V0LYrfe8AApm3Gzl+bX Ix/uTLVecTMDmtIm/BY1w7ZTp4qMAjiJWLe9gm7ilivZ8iaa88CZgaRfMdgdgsEP CLXUTMNaxZ+ebyCmjACSq2S+SBKpKXWyufv87hiLw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=h/tdmL yDeGRWKERovb02sAl+r2rVHONZOymgNDvRypg=; b=Ek3NT0t4J7rGmOhRpqLZMw 2yLRefaUA/a2qZ7FjJorjHkvslICI1MvwUYveqxQ8Q+lvGZ2jsmEnD1GQNfqGmd4 5SfPow42jwHsS7QrfKSw8cUfPaVbA2WywHcWX8u7PguKjXfNJLuRDFYLfpi1DUBB 6BKg4e6S90GpbGaGJwYKYOnEE9gheGUkcZaVimpSjn109haX6YKCijy7Y2tjtzig mk4HFIA9KJ5ZNv45MZemB7b4gnxnYaa2s9Q6zlo1waTjAnS5mWSABpjBwv1Z2uEc xcalpTWXk4CWNlf3i1ONomSoMxo/IObUpCD+VJLSmAXdkRX/AxaoAkLMnrC1Eslg ==
X-ME-Sender: <xms:X3-hWvgAhdg79GH5F6GZOFiY4kKLs_NhsLRfzW9ki7ZCsG5_FaWTLg>
Received: from alcoop-m-mx19.fios-router.home (pool-71-114-59-41.washdc.fios.verizon.net [71.114.59.41]) by mail.messagingengine.com (Postfix) with ESMTPA id AEF4324636; Thu, 8 Mar 2018 13:22:22 -0500 (EST)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <152049237626.21252.6359780771523317094@ietfa.amsl.com>
Date: Thu, 8 Mar 2018 13:22:22 -0500
Cc: General Area Review Team <gen-art@ietf.org>, draft-ietf-trill-over-ip.all@ietf.org, trill IETF mailing list <trill@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <5A7B9786-6E92-4C10-90A7-14F52354FCF3@cooperw.in>
References: <152049237626.21252.6359780771523317094@ietfa.amsl.com>
To: Matthew Miller <linuxwolf+ietf@outer-planes.net>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/trill/c1lFM0CiEwHOvoom2Pm-hmaiB_I>
Subject: Re: [trill] [Gen-art] Genart telechat review of draft-ietf-trill-over-ip-15
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Mar 2018 18:22:29 -0000

Matt, thanks for your review. I have entered a No Objection ballot.

Alissa

> On Mar 8, 2018, at 1:59 AM, Matthew Miller <linuxwolf+ietf@outer-planes.net> wrote:
> 
> Reviewer: Matthew Miller
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-trill-over-ip-15
> Reviewer: Matthew A. Miller
> Review Date: 2018-03-07
> IETF LC End Date: 2018-03-06
> IESG Telechat date: 2018-03-08
> 
> Summary:  Ready with nits
> 
> Major issues: NONE
> 
> Minor issues: NONE
> 
> Nits/editorial comments:
> 
> * In Section 4.5. "TRILL Over IP Transport IS-IS SubNetwork Point
> of Attachment", the word "of" between ""
> 
> """
> The Hellos transmitted out [of] a port indicate what neighbor ports
> that port can see on the link by listing what IS-IS refers to as the
> neighbor port's SubNetwork Point of Attachment (SNPA)
> """
> 
> * In Section 5.2. "Encapsulation Agreement", the first sentence is
> difficult to understand; I think it is missing the word "on" between
> "sent out" and "a TRILL over IP":
> 
> """
> TRILL Hellos sent out [on] a TRILL over IP transport port indicate the
> encapsulations for which that port is offering full support through a
> mechanism initially specified in [RFC7178] and [RFC7176] that is
> hereby extended.
> """
> 
> * In Section 5.4. "Native Encapsulation", the word "he" should be
> "the" in the sentence "Where he UDP Header is as follows".
> 
> * In Section 5.6.1. "TCP Connection Establishment", the word
> "connections" should be singular (or the leading "a" dropped) in the
> fragment "try to establish a TCP connections to each of them".
> 
> * In Section 5.6.1. "TCP Connection Establishment", the occurrence of
> "P!" should be changed to "P1".
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art