Re: [trill] [RTG-DIR] Routing directorate QA review of draft-ietf-trill-rbridge-multilevel

Stig Venaas <stig@venaas.com> Wed, 03 August 2016 21:08 UTC

Return-Path: <stig@venaas.com>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 87E1612B010 for <trill@ietfa.amsl.com>; Wed, 3 Aug 2016 14:08:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=venaas-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o2b5TxmHEhbb for <trill@ietfa.amsl.com>; Wed, 3 Aug 2016 14:08:46 -0700 (PDT)
Received: from mail-lf0-x22d.google.com (mail-lf0-x22d.google.com [IPv6:2a00:1450:4010:c07::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EFE4E12D0FB for <trill@ietf.org>; Wed, 3 Aug 2016 14:08:45 -0700 (PDT)
Received: by mail-lf0-x22d.google.com with SMTP id f93so170169294lfi.2 for <trill@ietf.org>; Wed, 03 Aug 2016 14:08:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=venaas-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=gD2ushcNcCz3atFT2LlevjSudNJQdKsyYX/6Sd9V6lI=; b=s09jX6kRlcVmKPoHQniiQoT30Zd7bTmbcggayryxCSxjZB9+gyguAMTwV536qp6sRr ByXiX3bxuTUbFhvev/5Y+QuxBbduE3apAryVJ/skbsI2qktKCorTHPNOVO2qKD8WLsC6 IzYkeXhoWrScI1UqQiLVbSL1enooHIMPmo1gkEhGRw/DZKHSgizSvJCDdKsj+/F3KNpc Vs4268hK/3How8pl71ycwNIJLYlmd34jDGxLoyoJnstBu3T8jS7BPeWFHTGtWfNAvGVl 9hgRklqKJrooiPJh9lHEytV1wAb16tfFbsJZ9B6eT8Ht7yL8YP0YbbGJUCfgXRXxnyO4 ZslQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=gD2ushcNcCz3atFT2LlevjSudNJQdKsyYX/6Sd9V6lI=; b=bCOqjtg+zrfT8GgvwDNAqnSXWzTl9XsYlWj6JpToXPmo93QJ8+yFP2dkOuxSJzaFLJ Z6NGMaJYMa5CvRh5H4s98GYVmNcFJQEGUqVTxf4W5bBG+OxTZYH8zl17dkWGokAfkRhU cA1He+lWhfxv2IzZgOZS6THkACdytJKOlhPomL6HG+ioOkeWlCC8NSLfbibCHgOnJTzd tx7i9f9cHULB7I2U/AyGGHpQa+I9mM0VzbbGkXEKqGNP3h6xS+oX6+VXVglGo1p3A0c0 WGOv9CZVMeIG4UagFZkl2TBCrW9Q6n8C4U/apDA7xa0jqwz8pvdj3YH9Sl5x4TTc0qEy RhHw==
X-Gm-Message-State: AEkoouu3wdcij6gJjfEj28m7hMY1TFlYNLThk/UwCH9piTH7SolRps5NDUaOAK+37B7ZKoYrDw4CibqYanr0bQ==
X-Received: by 10.25.80.84 with SMTP id e81mr18362408lfb.96.1470258523996; Wed, 03 Aug 2016 14:08:43 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.25.165.72 with HTTP; Wed, 3 Aug 2016 14:08:43 -0700 (PDT)
In-Reply-To: <CAF4+nEFzGVAu1V=0yH81pZ5om7WNhHi1Qkd515qZhRE+EAyzeg@mail.gmail.com>
References: <BY2PR0201MB19102373A5380FF07B9F5899847C0@BY2PR0201MB1910.namprd02.prod.outlook.com> <CAHANBtJHFOngQB5+uzray94YvL4=47ddpoVGM1kW0tdsS-_W1A@mail.gmail.com> <CAG4d1rfmtXrv2sgJ5XDANy+y3vUR0n1Wojr67fN=Asq0CFOseQ@mail.gmail.com> <CAF4+nEH-gXsOMvwtOPzJ-077Fmjt3Rm75m_FfcGfWiVXHT=UxA@mail.gmail.com> <CAF4+nEEJc-otjWgnyorrB9S5n=64YwN0haDF4OyPtomo2zo=bg@mail.gmail.com> <CAF4+nEFzGVAu1V=0yH81pZ5om7WNhHi1Qkd515qZhRE+EAyzeg@mail.gmail.com>
From: Stig Venaas <stig@venaas.com>
Date: Wed, 3 Aug 2016 14:08:43 -0700
Message-ID: <CAHANBtKNZz1G+bFKF_+G0OTUsH91b8ZUg5+6d90qepWizET2pg@mail.gmail.com>
To: Donald Eastlake <d3e3e3@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/trill/dOHfnwcHN6Yx182S1z3Wn27fPio>
Cc: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "Zhangxian \(Xian\)" <zhang.xian@huawei.com>, Alia Atlas <akatlas@gmail.com>, "trill@ietf.org" <trill@ietf.org>, Jonathan Hardwick <Jonathan.Hardwick@metaswitch.com>, Susan Hares <shares@ndzh.com>, Jon Hudson <jon.hudson@gmail.com>
Subject: Re: [trill] [RTG-DIR] Routing directorate QA review of draft-ietf-trill-rbridge-multilevel
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Aug 2016 21:08:49 -0000

Hi

The new version looks good to me. It addresses my comments and I see
the draft has been improved further with additional changes.

Stig


On Tue, Aug 2, 2016 at 7:02 PM, Donald Eastlake <d3e3e3@gmail.com> wrote:
> Hi Stig,
>
> As below, could you look at this draft to see if your comments have been
> resolved?
>
> Thanks,
> Donald
> ===============================
>  Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
>  155 Beaver Street, Milford, MA 01757 USA
>  d3e3e3@gmail.com
>
> On Sat, Jun 4, 2016 at 6:36 PM, Donald Eastlake <d3e3e3@gmail.com> wrote:
>>
>> Hi Stig,
>>
>> https://tools.ietf.org/html/draft-ietf-trill-rbridge-multilevel-03 has
>> been uploaded with the comment resolutions below incorporated.
>>
>> Thanks,
>> Donald
>> ===============================
>>  Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
>>  155 Beaver Street, Milford, MA 01757 USA
>>  d3e3e3@gmail.com
>>
>>
>> On Thu, May 26, 2016 at 12:23 AM, Donald Eastlake <d3e3e3@gmail.com>
>> wrote:
>> > Hi Stig,
>> >
>> > On Wed, May 25, 2016 at 3:26 PM, Alia Atlas <akatlas@gmail.com> wrote:
>> >> Stig,
>> >>
>> >> Thank you very much for your review.  I'm also forwarding it to trill
>> >> so
>> >> that the WG can see it.
>> >>
>> >> Regards,
>> >> Alia
>> >>
>> >> On Wed, May 25, 2016 at 2:28 PM, Stig Venaas <stig@venaas.com> wrote:
>> >>>
>> >>> Hi
>> >>>
>> >>> Sorry for being a bit late with this review. At least the document is
>> >>> well written and easy to understand. There are no significant issues.
>> >>>
>> >>> I am wondering about the security considerations though. Are there
>> >>> really no differences between the multi-level alternatives when it
>> >>> comes to security?
>> >
>> > Well, I guess a couple sentences could be added that the choice of
>> > using aggregated nicknames, and the resulting possible duplication of
>> > nicknames between areas, increases the possibility of a TRILL Data
>> > packet being delivered to the wrong egress RBridge if areas are
>> > suddenly merged. However, is many cases the data would be discarded at
>> > that egress because it would not match a known end station data label
>> > / MAC address.
>> >
>> >>> I have two tiny editorial comments.
>> >>>
>> >>> Section 1.4 typo
>> >>> RBridge - Routing Bridge, an alterntive name for a TRILL switch
>> >>>                                                ^^^^^^^^^
>> >
>> > OK,
>> >
>> >>> Also, several places it says "non-zero" which is correct, but there
>> >>> are some instances of "nonzero".
>> >
>> > Apparently both of those are correct but I agree the draft should use
>> > one of them consistently. I'll replace the two instances of nonzero
>> > with the hyphenated form.
>> >
>> > Thanks,
>> > Donald
>> > ===============================
>> >  Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
>> >  155 Beaver Street, Milford, MA 01757 USA
>> >  d3e3e3@gmail.com
>> >
>> >>> Stig
>> >>>
>> >>>
>> >>> On Wed, May 4, 2016 at 11:52 PM, Jonathan Hardwick
>> >>> <Jonathan.Hardwick@metaswitch.com> wrote:
>> >>> > Hi Stig
>> >>> >
>> >>> >
>> >>> >
>> >>> > Please would you do a routing directorate QA review of
>> >>> > draft-ietf-trill-rbridge-multilevel?
>> >>> >
>> >>> >
>> >>> > https://datatracker.ietf.org/doc/draft-ietf-trill-rbridge-multilevel/
>> >>> >
>> >>> >
>> >>> >
>> >>> > Note that this is a “QA review.” The document is still being worked
>> >>> > on
>> >>> > by
>> >>> > the TRILL working group.  The goal of this review is to provide a
>> >>> > different
>> >>> > perspective on the work and to improve its quality. Hence, your
>> >>> > comments
>> >>> > will be provided primarily for the benefit of the TRILL chairs and
>> >>> > the
>> >>> > document authors.
>> >>> >
>> >>> >
>> >>> >
>> >>> > Please could you provide your comments by May 20 and copy your
>> >>> > comments
>> >>> > to
>> >>> > the rtg-dir list?
>> >>> >
>> >>> >
>> >>> >
>> >>> > The following web page contains a briefing on the QA process, and
>> >>> > guidance
>> >>> > for the QA reviewer.
>> >>> >
>> >>> > https://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDirDocQa
>> >>> >
>> >>> >
>> >>> >
>> >>> > Please let me know whether you can do it, or not.
>> >>> >
>> >>> >
>> >>> >
>> >>> > Many thanks
>> >>> >
>> >>> > Jon
>> >>> >
>> >>> >
>> >>> >
>> >>> >
>> >>> >
>> >>> >
>> >>> >
>> >>> >
>> >>>
>> >>
>> >>
>> >> _______________________________________________
>> >> trill mailing list
>> >> trill@ietf.org
>> >> https://www.ietf.org/mailman/listinfo/trill
>> >>
>
>