Re: [trill] Mail Shepherd's comments on draft-ietf-trill-oam-fm-03.txt
Liyizhou <liyizhou@huawei.com> Thu, 19 June 2014 08:51 UTC
Return-Path: <liyizhou@huawei.com>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8B77C1A0040 for <trill@ietfa.amsl.com>; Thu, 19 Jun 2014 01:51:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.851
X-Spam-Level:
X-Spam-Status: No, score=-3.851 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RP_MATCHES_RCVD=-0.651, SPF_PASS=-0.001, TVD_BODY_END_STAR=1] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FlK24qgXL4Qp for <trill@ietfa.amsl.com>; Thu, 19 Jun 2014 01:51:10 -0700 (PDT)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5071C1A035D for <trill@ietf.org>; Thu, 19 Jun 2014 01:51:09 -0700 (PDT)
Received: from 172.18.7.190 (EHLO lhreml404-hub.china.huawei.com) ([172.18.7.190]) by lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id BFP04564; Thu, 19 Jun 2014 08:51:07 +0000 (GMT)
Received: from NKGEML404-HUB.china.huawei.com (10.98.56.35) by lhreml404-hub.china.huawei.com (10.201.5.218) with Microsoft SMTP Server (TLS) id 14.3.158.1; Thu, 19 Jun 2014 09:49:49 +0100
Received: from NKGEML503-MBX.china.huawei.com ([169.254.5.160]) by nkgeml404-hub.china.huawei.com ([10.98.56.35]) with mapi id 14.03.0158.001; Thu, 19 Jun 2014 16:49:45 +0800
From: Liyizhou <liyizhou@huawei.com>
To: "Tissa Senevirathne (tsenevir)" <tsenevir@cisco.com>, Susan Hares <shares@ndzh.com>, "trill@ietf.org" <trill@ietf.org>
Thread-Topic: [trill] Mail Shepherd's comments on draft-ietf-trill-oam-fm-03.txt
Thread-Index: AQHPeeY2PbeGBTBCuUa4BhJmzDFFmJt4QI1g
Date: Thu, 19 Jun 2014 08:49:45 +0000
Message-ID: <D408889639FC5E4FADB4E00A3E01FA8F5E8ADB11@nkgeml503-mbx.china.huawei.com>
References: <013e01cf79e4$e2bfaab0$a83f0010$@ndzh.com> <FBEA3E19AA24F847BA3AE74E2FE193562B003D7B@xmb-rcd-x08.cisco.com>
In-Reply-To: <FBEA3E19AA24F847BA3AE74E2FE193562B003D7B@xmb-rcd-x08.cisco.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.138.136.126]
Content-Type: multipart/alternative; boundary="_000_D408889639FC5E4FADB4E00A3E01FA8F5E8ADB11nkgeml503mbxchi_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: http://mailarchive.ietf.org/arch/msg/trill/gLThjkY9ZjW-SNH_qPm8etCqXsU
Cc: 'Donald Eastlake' <d3e3e3@gmail.com>
Subject: Re: [trill] Mail Shepherd's comments on draft-ietf-trill-oam-fm-03.txt
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jun 2014 08:51:14 -0000
Hi Tissa, " Upstream RBridge nickname" which occurred twice in 8.4.8 & 10.1.2 respectively should be "Previous RBridge nickname" in the document. Yizhou From: trill [mailto:trill-bounces@ietf.org] On Behalf Of Tissa Senevirathne (tsenevir) Sent: Wednesday, May 28, 2014 3:59 AM To: Susan Hares; draft-ietf-trill-oam-fm@tools.ietf.org; trill@ietf.org Cc: 'Donald Eastlake' Subject: Re: [trill] Mail Shepherd's comments on draft-ietf-trill-oam-fm-03.txt Thanks Sue, will include the comments suggested. From: trill [mailto:trill-bounces@ietf.org] On Behalf Of Susan Hares Sent: Tuesday, May 27, 2014 12:50 PM To: draft-ietf-trill-oam-fm@tools.ietf.org<mailto:draft-ietf-trill-oam-fm@tools.ietf.org>; trill@ietf.org<mailto:trill@ietf.org> Cc: 'Donald Eastlake' Subject: [trill] Mail Shepherd's comments on draft-ietf-trill-oam-fm-03.txt Authors and working group: I respectfully submit the following shepherd's review below on the document quality. I found no technical issues with the draft, but I would suggest the editorial changes below (required and suggested). The full shepherd's report can be access via the draft's web page on the data tracker at: https://datatracker.ietf.org/doc/draft-ietf-trill-oam-fm/ Please let me know if there are questions. I want to thank Donald Eastlake for his early review of my comments. Sue Hares ------------- Document Quality The TRILL OAM FM has implementations begun in the Cisco, Huawei, and other router companies (2-3). The co-authors on this draft are in touch with the implementation teams at Cisco and Huawei, and in-touch with the 802.1 Task group within the IEEE. The document's text and logic is excellent. Even with the ~60 page length, the shepherd found very few editorial issues. A few minor nits listed below, the authors will address promptly. (3) Briefly describe the review of this document that was performed by the Document Shepherd. If this version of the document is not ready for publication, please explain why the document is being forwarded to the IESG. Editorial issues: Fix regerences: ISIS - mentioned (line 1483, 2203) - change to [IS-IS] and adjust. Outdated references: RFC7172 draft-ietf-trill-fine-labeling has been published as RFC 7172 draft-ietf-trill-clear-correct has been published as RFC 7180 draft-ietf-trill-oam-framework has been published as RFC 7174 Outdated reference: draft-ietf-trill-rbridge-extension has been published as RFC 7179 Section 15.4 - requests return code for PTR request messages. It is unclear which registry this section applies to. Please fix. Shepherd's Editorial suggestions [This will be deleted after revision] ------------------- section 2.0 add references to: LBR - Loop Back Reply Message MTVM - Multi-destination Tree Verification Message MTVR - Multi-destination Tree Verification Reply Message PT - Path Trace PTR - Path Trace Message Reply Messaage 4.2.1 section page 11 change /or derive them from port defaults or the like/ to /or derive them from port defaults or other defaults/ 4.3.1 p. 12 change /<- This is the TRILL ingress function/ to /This is the TRILL ingress function./ 4.3.2 p. 12 Change /<- This is the TRILL egress funciton/ to / This is the TRILL Egress Function./ 4.3.3 p. 13 Change / If the EtherType is TRILL but the multicast DA is not ALL-RBridge or if the EhterType is L2-IS-IS but the multicast Da/ to / If the Ethertype is TRILL but the mutlicast DA is not ALL-Rbridge; or if the Ethertype is L2-IS-ISIS but the multicast DA/ 6.0 p. 19 Change / NOTE: LBM, MTV, PT are not subject to MA de-multipliexers./ to / Note: LBM, MTV*, PT* are not subject to MA de-multiplixers./ 6.1 p. 21 change in figure /PT MTV/ to /PT* MTV*/ 7. p. 22 - section 12. is odd in the text. Either use 12.0 or section 12 Change / section 12. below for the theory/ to /change 12 below for the theory/ 9.2.1 p. 37 change /Assign/Assigns/ 11.2.1 p. 42 para 3 change /the originating RBridge/ to /the originating RBridges does the following/ indent para 4-10 para 4 change /obtain/obtains/ para 5 change /construct/constructs/ para 6 change /TRILL OAM Application Identifier TLV MUST BE INCLUDED/ to /INCLUDES the TRILL OAM Application Identifier TLV which MUST BE INCLUDED/ para 7 change /Op-code MUST/ to /incorporates Op-Code which MUST/ para 8 change /Include/Includes/ para 10 change /user./to /user; and/ 12. para 1: change /Section 7./ to /Section 7/ 16.2 [RFCclcorrect] to RFC7180 [TRILLEXT] to RFC7179
- [trill] Mail Shepherd's comments on draft-ietf-tr… Susan Hares
- Re: [trill] Mail Shepherd's comments on draft-iet… Tissa Senevirathne (tsenevir)
- Re: [trill] Mail Shepherd's comments on draft-iet… Liyizhou
- Re: [trill] Mail Shepherd's comments on draft-iet… Donald Eastlake