Re: [trill] Tsvart last call review of draft-ietf-trill-ecn-support-04

Donald Eastlake <d3e3e3@gmail.com> Mon, 05 February 2018 05:30 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 552F9126CD6; Sun, 4 Feb 2018 21:30:18 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.75
X-Spam-Level:
X-Spam-Status: No, score=-1.75 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y7p6iN4c27tk; Sun, 4 Feb 2018 21:30:16 -0800 (PST)
Received: from mail-ot0-x229.google.com (mail-ot0-x229.google.com [IPv6:2607:f8b0:4003:c0f::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BC6BE1205D3; Sun, 4 Feb 2018 21:30:16 -0800 (PST)
Received: by mail-ot0-x229.google.com with SMTP id l10so335568oth.1; Sun, 04 Feb 2018 21:30:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5mzXgd7tLPWiVeeFNHPDj0AthgZJJUfDxD8aZtia0iw=; b=pcjclJL3Grq0DSDX2bYhVCJcourTgqG5Whre+81aX+O2/k4Q0tcwpudlmi6c7a4Jvw Q83BUc6fjxemIs9JQc9pVKCLuFSHmCOha4DOYg7N0Rb4hcTt51kpEiLoAgaL3XUNUKgr 7fvD7kllMUn4N70nTRKgs4IC4WL6OPkzfoQhQvaHp5DttT0Necdm5HLFzCjLenUO5DAI 3LhA6rYq3+TyUC1NIw/by6Bt6E+w+UcLBvPWeXzeKJ4QYmov/BSqnsJELzU/Jlz7QfRr hA/zPK3DcBJZQFkFTgF2meBpVB2LGpEH54Mnjc4Rtso+DSvYDNT+5j47P+bWv5ZVORq3 lFXA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5mzXgd7tLPWiVeeFNHPDj0AthgZJJUfDxD8aZtia0iw=; b=dHjkCe75U06Yy9K7ca8UjSYs/T6KQg+ax6kqHhNgUkJ43X8XHFXUdbTNBsGI3fzE5B C+BqsgX/cs5GGykE/048gcCtRJ34wLMupzm+P7zzIi0/umDfrQRIoAfdooWZtydTEv/o xTgZgLEI2uonRjR7lMv1nOFnAUkoCfcNhnzBoVaubV91xxMRfftv7q9K+/B4o3XHWeAm j64n4UeiIj4/Ncenw+DBf4C0VXW+avSeI/MD2A7gEaqyKriItLylBl6Dwt3ZQqyiDKXj wuvpK2n6NK9oncWIx8TFoEIIIUrQwK47IuGiRRPHmI7B90Usi5NBUNo+ZwhXWd6DShap v54Q==
X-Gm-Message-State: AKwxytfLKALSJTfiXmxBGm2L6L9G9NJKCIQDkVZNkHc2FwMLdebsRCCa EcRSUDbnRnehi6HS+bmztnK4ZlMPMtrUhVN+nIM=
X-Google-Smtp-Source: AH8x226KOV11A+Rp2hPGGoToJZ6PHFl/MYOSlpxn0LJ7lthTECmVyPnrYbDALlVPQk6Xgn5aSAvGrK+g0Ydp51B9Pro=
X-Received: by 10.157.19.46 with SMTP id f43mr35103965ote.139.1517808615914; Sun, 04 Feb 2018 21:30:15 -0800 (PST)
MIME-Version: 1.0
Received: by 10.168.67.205 with HTTP; Sun, 4 Feb 2018 21:30:00 -0800 (PST)
In-Reply-To: <CAF4+nEESTEEHCpPwT20Yw6vmj-36sqQXRj6-JC0=uxqr4Q6how@mail.gmail.com>
References: <151777044483.12244.16174801155565406521@ietfa.amsl.com> <CAF4+nEESTEEHCpPwT20Yw6vmj-36sqQXRj6-JC0=uxqr4Q6how@mail.gmail.com>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Mon, 5 Feb 2018 00:30:00 -0500
Message-ID: <CAF4+nEGCOhFQvaaeuLE7RuXdebwg5piU4zgYvXYZx5g8WMdpzw@mail.gmail.com>
To: =?UTF-8?Q?Michael_T=C3=BCxen?= <tuexen@fh-muenster.de>
Cc: tsv-art@ietf.org, draft-ietf-trill-ecn-support.all@ietf.org, IETF Discussion <ietf@ietf.org>, trill@ietf.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/trill/gdXWsVdfQfGYLq5zpF0nGwSoCjU>
Subject: Re: [trill] Tsvart last call review of draft-ietf-trill-ecn-support-04
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Feb 2018 05:30:18 -0000

Hi Michael,

I've fixed these nits and posted a -05 version.

Thanks,
Donald
===============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 155 Beaver Street, Milford, MA 01757 USA
 d3e3e3@gmail.com


On Sun, Feb 4, 2018 at 9:44 PM, Donald Eastlake <d3e3e3@gmail.com> wrote:
> Hi Michael,
>
> Thanks for the comments, see below.
>
> On Sun, Feb 4, 2018 at 1:54 PM, Michael Tüxen <tuexen@fh-muenster.de> wrote:
>> Reviewer: Michael Tüxen
>> Review result: Ready with Nits
>>
>> I've reviewed this document as part of the transport area directorate's ongoing
>> effort to review key IETF documents. These comments were written primarily for
>> the transport area directors, but are copied to the document's authors for
>> their information and to allow them to address any issues raised.
>> When done at the time of IETF Last Call, the authors should consider this
>> review together with any other last-call comments they receive.
>> Please always CC tsv-art@ietf.org if you reply to or forward this review.
>>
>> This draft is basically ready for publication, but has nits that should be fixed before publication.
>>
>> Nits:
>>
>> Section 1:
>>
>> Old text:
>> This can improve network efficiency through better flow
>> control without packet drops.
>>
>> New text:
>> This can improve network efficiency through better congestion
>> control without packet drops.
>
> OK.
>
>> Old text:
>> This specification provides for any ECN marking in the traffic at the
>> ingress to be copied into the TRILL Extension Header Flags Word.
>>
>> New Text:
>> This specification specifies for any ECN marking in the traffic at the
>> ingress to be copied into the TRILL Extension Header Flags Word.
>
> Well, it specifies how to copy the ECN marking for any traffic and it
> mandates that it be copied from IP traffic but it doesn't and can't
> mandate that it be copied from all arbitrary protocols that might have
> ECN marking...  Also, I don't like "... specification specifies ..."
>
> How about:
> "This document specifies how ECN marking in traffic at the ingress is
> copied into the TRILL Extension Header Flags Word and requires such
> copying for IP traffic."
>
>> Section 2:
>>
>> Old text:
>> after the Extesnion Flags Word.
>>
>> New text:
>> after the Extension Flags Word
>
> OK.
>
>> Section 3.3
>>
>> Please define "3-bit ECN codepoint" and refer to Table 3 BEFORE using it.
>> This might result in swapping Table 2 and Table 3.
>
> We'll look into doing that.
>
> Thanks,
> Donald
> ===============================
>  Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
>  155 Beaver Street, Milford, MA 01757 USA
>  d3e3e3@gmail.com