Re: [trill] AD review of draft-ietf-trill-pseudonode-nickname-04

Mingui Zhang <zhangmingui@huawei.com> Tue, 18 August 2015 03:08 UTC

Return-Path: <zhangmingui@huawei.com>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F01C81B311F for <trill@ietfa.amsl.com>; Mon, 17 Aug 2015 20:08:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.21
X-Spam-Level:
X-Spam-Status: No, score=-4.21 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sWNOFNHUpVPK for <trill@ietfa.amsl.com>; Mon, 17 Aug 2015 20:08:17 -0700 (PDT)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CB10A1B3117 for <trill@ietf.org>; Mon, 17 Aug 2015 20:08:15 -0700 (PDT)
Received: from 172.18.7.190 (EHLO lhreml404-hub.china.huawei.com) ([172.18.7.190]) by lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id BZZ68184; Tue, 18 Aug 2015 03:08:14 +0000 (GMT)
Received: from nkgeml409-hub.china.huawei.com (10.98.56.40) by lhreml404-hub.china.huawei.com (10.201.5.218) with Microsoft SMTP Server (TLS) id 14.3.235.1; Tue, 18 Aug 2015 04:08:12 +0100
Received: from NKGEML512-MBX.china.huawei.com ([169.254.7.33]) by nkgeml409-hub.china.huawei.com ([10.98.56.40]) with mapi id 14.03.0235.001; Tue, 18 Aug 2015 11:08:09 +0800
From: Mingui Zhang <zhangmingui@huawei.com>
To: Alia Atlas <akatlas@gmail.com>
Thread-Topic: [trill] AD review of draft-ietf-trill-pseudonode-nickname-04
Thread-Index: AQHQyxdMwlqv6LDvGkeIt5RtbF9LPZ35iaNwgAREOQCACQFHAIACbvIggAawrgCAAS/V8A==
Date: Tue, 18 Aug 2015 03:08:08 +0000
Message-ID: <4552F0907735844E9204A62BBDD325E787196720@nkgeml512-mbx.china.huawei.com>
References: <CAG4d1rc_zjEkSU+zyvEGR76hmnqbi363-p=frsK192qapCGrDA@mail.gmail.com> <4552F0907735844E9204A62BBDD325E787164186@nkgeml512-mbx.china.huawei.com> <CAF4+nEHxs5L3xjZJwC83MockLsj0tUu_bppWNZ6ej0RckjxOcg@mail.gmail.com> <CAF4+nEF-Bx8jT1S6FtXAUJpwc4=K1pyMiKnAg5am5hHV4WRB6w@mail.gmail.com> <4552F0907735844E9204A62BBDD325E787192DFF@nkgeml512-mbx.china.huawei.com> <CAG4d1rcG5OGLjjhRcyukYGiSmsqoGRC=2-tUi2DXOc8a70vO0g@mail.gmail.com>
In-Reply-To: <CAG4d1rcG5OGLjjhRcyukYGiSmsqoGRC=2-tUi2DXOc8a70vO0g@mail.gmail.com>
Accept-Language: en-US, zh-CN
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.111.146.93]
Content-Type: multipart/alternative; boundary="_000_4552F0907735844E9204A62BBDD325E787196720nkgeml512mbxchi_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <http://mailarchive.ietf.org/arch/msg/trill/k-cycjpAF2JDNBeNv2LXLKEnlgk>
Cc: Donald Eastlake <d3e3e3@gmail.com>, Tissa Senevirathne <tsenevir@gmail.com>, "draft-ietf-trill-pseudonode-nickname@tools.ietf.org" <draft-ietf-trill-pseudonode-nickname@tools.ietf.org>, "trill@ietf.org" <trill@ietf.org>
Subject: Re: [trill] AD review of draft-ietf-trill-pseudonode-nickname-04
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Aug 2015 03:08:21 -0000

Hi Alia,

Sorry for the delay.
I agree that Donald has cleared out the inconsistency. The updated version has been uploaded.

Thanks,
Mingui

From: Alia Atlas [mailto:akatlas@gmail.com]
Sent: Monday, August 17, 2015 11:58 PM
To: Mingui Zhang
Cc: Donald Eastlake; draft-ietf-trill-pseudonode-nickname@tools.ietf.org; Tissa Senevirathne; trill@ietf.org
Subject: Re: [trill] AD review of draft-ietf-trill-pseudonode-nickname-04

Hi Mingui,

I need the updated version ASAP.  If I don't see it today, I will have to put off reviewing the draft on the IESG telechat for another 2 weeks.

Donald's suggested text does clear up my concern about the inconsistency around the non-DF behavior.

Thanks,
Alia

On Wed, Aug 12, 2015 at 9:55 PM, Mingui Zhang <zhangmingui@huawei.com<mailto:zhangmingui@huawei.com>> wrote:
Hi Donald,

Appreciate the review. The suggested changes are fine. Authors will incorporate them and send out the updated draft for your review. If it will be OK. The new version will be uploaded by tomorrow.

Thanks,
Mingui

> -----Original Message-----
> From: trill [mailto:trill-bounces@ietf.org<mailto:trill-bounces@ietf.org>] On Behalf Of Donald Eastlake
> Sent: Wednesday, August 12, 2015 4:39 AM
> To: draft-ietf-trill-pseudonode-nickname@tools.ietf.org<mailto:draft-ietf-trill-pseudonode-nickname@tools.ietf.org>
> Cc: Tissa Senevirathne; trill@ietf.org<mailto:trill@ietf.org>
> Subject: Re: [trill] AD review of draft-ietf-trill-pseudonode-nickname-04
>
> Hi,
>
> I believe the mark ups in the attached resolve the AD comments on
> draft-ietf-trill-pseudonode-nickname and also update some author info.
> Could the authors please incorporate changes along these lines and post a new
> draft or, alternatively, point out my errors and propose different changes.
>
> Thanks,
> Donald (document Shepherd)
> =============================
>  Donald E. Eastlake 3rd   +1-508-333-2270<tel:%2B1-508-333-2270> (cell)
>  155 Beaver Street, Milford, MA 01757 USA  d3e3e3@gmail.com<mailto:d3e3e3@gmail.com>
>
>
> On Wed, Aug 5, 2015 at 11:07 PM, Donald Eastlake <d3e3e3@gmail.com<mailto:d3e3e3@gmail.com>>
> wrote:
> > See below
> >
> > On Sun, Aug 2, 2015 at 11:45 PM, Mingui Zhang <zhangmingui@huawei.com<mailto:zhangmingui@huawei.com>>
> wrote:
> >> Hi Alia,
> >>
> >> Please see comments inline with [mingui].
> >>
> >> From: trill [mailto:trill-bounces@ietf.org<mailto:trill-bounces@ietf.org>] On Behalf Of Alia Atlas
> >> Sent: Friday, July 31, 2015 6:30 AM
> >> To: trill@ietf.org<mailto:trill@ietf.org>;
> >> draft-ietf-trill-pseudonode-nickname@tools.ietf.org<mailto:draft-ietf-trill-pseudonode-nickname@tools.ietf.org>; Don Eastlake
> >> Subject: [trill] AD review of draft-ietf-trill-pseudonode-nickname-04
> >>
> >> ...
> >>
> >> Here are the details of my review:
> >>
> >> Minor concerns:
> >>
> >> 1) On p. 15 & 16: I'm a bit confused because on p. 15, it says "The
> >> basic idea of DF is to elect one RBridge per VLAN from an RBv to
> >> egress multi-destination TRILL Data traffic and replicate
> >> locally-received multi-destination native frames to the CEs served by
> >> the RBv."  but then on p. 16 in Step 4 part 1), it says: "RBv ports
> >> associated with the same pseudo-nickname as that of the incoming
> >> port, no matter whether RBi is the DF for the frame's VLAN on the
> >> outgoing ports except that the frame MUST NOT be replicated back to
> >> the incoming port".  This seems to be contradictory.
> >>
> >> [mingui] Let me explain the logic. If the RBridge in a RBv group
> >> receives a BUM packet from a locally connected CE.  Other CEs will
> >> receive the packet replicated by the DF only. Other RBridges will refrain from
> replicating.
> >>    Having said that, it is also important that the DF never
> >> replicates the BUM packet back to the incoming port (Say CE1 sends
> >> the BUM packet to the DF RB1 via port 1, then RB1 does not send the
> >> replicated BUM packet back to CE1 via port 1.)
> >>
> >> Moreover, if one say CE1,
> >>
> >> CE2, and CE3 all in the same RBv, when CE1 sends a packet to RB2 and
> >> RB1 is the DF for the particularly VLAN, then wouldn't RB2 forward
> >> the packet to CE1 and CE2 while RB1 would also do so as the DF?
> >>
> >> [mingui] As explained above, RB2 will refrain from replicating since
> >> it is not the DF.
> >
> > Probably the wording can be clarified.
> >
> >> Could you
> >> please clarify what is causing the inconsistency and problem?  Maybe
> >> the text in 6.1 on p. 18 helps describe that there are actually two
> >> cases to the text on p. 16?
> >>
> >> [mingui] Yes, I agree.
> >>
> >> 2) On p.23 in Sec 9.1: There is no way of identifying what the type
> >> of the LAALP ID is.  Assuming it is a number and meaning doesn't
> >> matter, it would be really good to clarify that.
> >>
> >> [mingui] Agree.
> >
> > The general requirement is that the LAALP ID identify the
> > active-active edge group of end stations and the LAALP for a
> > particular group must be unique across the TRILL campus. As far as I
> > know, currently the only type of value used for the LAALP ID is an
> > 8-byte MC-LAG/DRNI ID. Perhaps the document should (1) indicate the
> > general requirement, (2) state that if the length is 8 it MUST be an
> > MC-LAG/DRNI ID, and (3) say that the type of LAALP ID value for any
> > other length will be specified in a future document.
> >
> >> 3) In Sec 9.2: How can an LAALP ID be withdrawn from PN-RBv
> >> APPsub-TLV?  Could you please describe that sequence?
> >>
> >> [mingui] I think, if RBx needs to just withdraw one LAALP ID, it will
> >> refresh the previous announced LSP by omitting that LAALP ID from the
> >> LAALP ID list in the PN-RBv APPsub-TLV.
> >
> > The APPsub-TLV (which is inside a TRILL GENINFO IS-IS TLV) is link
> > state although it is not part of the base routing information LSP. It
> > is distributed in E-L1FS FS-LSPs (support for which is required by
> > draft-ietf-trill-rfc7180bis which is also in publication requested
> > state). So the contents of the APPsub-TLV can be changed or it can be
> > withdrawn by changing the FS-LSP fragment in which it occurs.
> >
> >> Thanks,
> >> Mingui
> >>
> >> Thanks,
> >> Alia
> >
> > Thanks,
> > Donald
> > =============================
> >  Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
> >  155 Beaver Street, Milford, MA 01757 USA  d3e3e3@gmail.com<mailto:d3e3e3@gmail.com>
_______________________________________________
trill mailing list
trill@ietf.org<mailto:trill@ietf.org>
https://www.ietf.org/mailman/listinfo/trill