[trill] Fwd: Nits on draft-ietf-trill-rbridge-channel

Erik Nordmark <nordmark@acm.org> Fri, 11 May 2012 16:30 UTC

Return-Path: <nordmark@acm.org>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9226221F8638 for <trill@ietfa.amsl.com>; Fri, 11 May 2012 09:30:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.599
X-Spam-Level:
X-Spam-Status: No, score=-102.599 tagged_above=-999 required=5 tests=[AWL=0.000, BAYES_00=-2.599, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lFpln1GQ0DSi for <trill@ietfa.amsl.com>; Fri, 11 May 2012 09:30:04 -0700 (PDT)
Received: from b.mail.sonic.net (b.mail.sonic.net [64.142.19.5]) by ietfa.amsl.com (Postfix) with ESMTP id AC82C21F8606 for <trill@ietf.org>; Fri, 11 May 2012 09:30:04 -0700 (PDT)
Received: from [10.33.22.63] (128-107-239-233.cisco.com [128.107.239.233]) (authenticated bits=0) by b.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with ESMTP id q4BGU2ae007295 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 11 May 2012 09:30:02 -0700
Message-ID: <4FAD3E8A.3010206@acm.org>
Date: Fri, 11 May 2012 09:30:02 -0700
From: Erik Nordmark <nordmark@acm.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To: "trill@ietf.org" <trill@ietf.org>
References: <4F9A2DDA.1070009@acm.org>
In-Reply-To: <4F9A2DDA.1070009@acm.org>
X-Forwarded-Message-Id: <4F9A2DDA.1070009@acm.org>
Content-Type: text/plain; charset="ISO-8859-1"; format="flowed"
Content-Transfer-Encoding: 7bit
Subject: [trill] Fwd: Nits on draft-ietf-trill-rbridge-channel
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/trill>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 May 2012 16:30:05 -0000

FYI: I had sent these nits to the authors a while back.
I think it makes sense to revise the draft to take care of the nits 
below, and then send it to the IESG.

The "verbatim reproduction of the Inner Ethernet Header" should probably 
be left alone at this point in time.

Regards,
    Erik

-------- Original Message --------
Subject: Nits on draft-ietf-trill-rbridge-channel
Date: Thu, 26 Apr 2012 22:25:46 -0700
From: Erik Nordmark <nordmark@acm.org>
To: draft-ietf-trill-rbridge-channel@tools.ietf.org


Shouldn't this say something slightly different than MUST be zero?
       CHV: A 4-bit field that gives the RBridge Channel Header Version
             and MUST be zero.
Something like "This document specifies version zero."


The verbatim reproduction of the Inner Ethernet Header in section 2.1
means that this document would need to be revised as a result of things
like fine grained labels. Wouldn't it make sense to instead do this by
reference to RFC6325 instead of reproducing the exact header? That gives
us the flexibility to have documents which update RFC6325 without
touching this document.


Section 2.2 tries to rename the Op-len field in the base protocol to be
Ext-len. I think I commented on this being confusing and not worth-while
for the extensions draft, thus I think the channel draft can use the
same wording as the extensions draft (which does not attempt to rename
the field.)


Section 6.2 says
    The IEEE Registration Authority has been assigned the Ethertype <TBD>
    for RBridge-Channel.

"has been assigned" should probably be "has assigned".
Do we already have an allocated number to replace the TBD?

Typo: "particuclar"

    Erik