Re: [trill] Genart last call review of draft-ietf-trill-rbridge-multilevel-06

Donald Eastlake <d3e3e3@gmail.com> Wed, 28 June 2017 20:19 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CBC9212EB00; Wed, 28 Jun 2017 13:19:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.45
X-Spam-Level:
X-Spam-Status: No, score=-2.45 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MSMSNhDNlL2Q; Wed, 28 Jun 2017 13:19:07 -0700 (PDT)
Received: from mail-it0-x232.google.com (mail-it0-x232.google.com [IPv6:2607:f8b0:4001:c0b::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A2E8C12EB05; Wed, 28 Jun 2017 13:19:05 -0700 (PDT)
Received: by mail-it0-x232.google.com with SMTP id v202so35569875itb.0; Wed, 28 Jun 2017 13:19:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=xAUGIIhww8QT0s6y90rqIPdu3xXAMovnCzTIixHqShU=; b=WqpyuUXOeGDkXoY6II/66v6y+m+G/j1rNPxWN6BLH4VLErWPy3WYiD9UCnv/ldWjrl SR4TysPO6O74N6u6gEreIqM3r+eEWans51sCl7N9HQSdBnXwMXPl5Ka3IA4IyJKVlEKO TAf0L0AYzj12aMZnqmDylEy9EsuWdVvQpo5Lcuks1zUO2YE6QbRJr1nXkGNlsOLijI/I Om+2G0/D4tkWqfN69FlQil5WnQ3i2trRlBfZZYMdtEVEMe69zh17Gcgqu2aWq8CXnEcC cGpGKvRjPejjy2Eu0UHtDwwjFuEm4kuuMJDiCUmGhdMGH/6iouM8/panVLcVYqNqsw7c azvQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xAUGIIhww8QT0s6y90rqIPdu3xXAMovnCzTIixHqShU=; b=gFTerYevfzo8Xc1gz0ehQ9Wz/xT1dKvRecnI18B5/oeacfwQuvYyCOiBPVv2FDhFkm FhXlrDw4dmPuw2dYOOdqoJlK7G564fC3G6X7EFOhgHDEFP7V5qrelybnzdwvkIkdHQ4A vVlf6yqTPlkbTm0nSO1eb+bmzE8eW5mJYQvnBYBG6x4kxHWjhqYV5ij/1P0yUnZfYv2J 3GGpTy/Zw9C8No9Tj/jCOmbsQu34Y5aoJjFPcR0T3vCxje2t5euP4/9BifXm89vOQjQY iuOctLye8mWw9sqBfvUoyHe8bXZB0KIxQbChViL6VvOOVeY0aOMm/ZkmyOb/MYz9rPA3 GcwQ==
X-Gm-Message-State: AKS2vOyyIpakUjOMR1DWykScecMPhLcN0HSsJhUyqYpFXpLR4xpaLGKV LEwZFTINuTwUAG0WU8z1PNkhm8sv+g==
X-Received: by 10.36.3.11 with SMTP id e11mr8808369ite.79.1498681144981; Wed, 28 Jun 2017 13:19:04 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.107.17.221 with HTTP; Wed, 28 Jun 2017 13:18:49 -0700 (PDT)
In-Reply-To: <149867317753.7558.8752757743866337364@ietfa.amsl.com>
References: <149867317753.7558.8752757743866337364@ietfa.amsl.com>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Wed, 28 Jun 2017 16:18:49 -0400
Message-ID: <CAF4+nEFkM+T_CkO_4UgYMoNYJ3xjOLZWfg1k11sv15dP+HJ-zA@mail.gmail.com>
To: Stewart Bryant <stewart.bryant@gmail.com>
Cc: "gen-art@ietf.org Review Team" <gen-art@ietf.org>, draft-ietf-trill-rbridge-multilevel.all@ietf.org, IETF Discussion <ietf@ietf.org>, "trill@ietf.org" <trill@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/trill/pG-jBDyvwhiKcN_0M5GY2yvcrKc>
Subject: Re: [trill] Genart last call review of draft-ietf-trill-rbridge-multilevel-06
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Jun 2017 20:19:10 -0000

Hi Stewart,

Thanks for the comments. See below.

On Wed, Jun 28, 2017 at 2:06 PM, Stewart Bryant
<stewart.bryant@gmail.com> wrote:
> Reviewer: Stewart Bryant
> Review result: Ready
>
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
>
> For more information, please see the FAQ at
>
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>
> Document: draft-ietf-trill-rbridge-multilevel-??
> Reviewer: Stewart Bryant
> Review Date: 2017-06-28
> IETF LC End Date: 2017-06-28
> IESG Telechat date: 2017-07-06
>
> Summary:
>
> This is a well written document. I do however have a concern with the scaling
> text in section 1.2.x, as I think this could be more accessible and ought to
> include discussion of MAC Address scaling. More information below.
>
> Major issues: None
>
> Minor issues: The key justification for multi-area is scaling. The scene is set
> in Section 1.2.x. However there are no references, the design size parameters
> are not articulated for each case, and the equations are not derived. I think
> that it would be helpful if the draft either provided some more explanation of
> the scaling equations and the associated input assumptions, or provided the
> assumptions and  directed the reader to an accessible text to understand the
> equations.

A reference and some further exposition of the assumptions made with
the way the equations were arrived at could be added.

>                     Although there is some discussion on it later there is no discussion
> of the number of addresses to be learned in the single and multi-area cases and
> the impact this has on the LSDB. The number of addresses to be learned will
> impact the ingress RBridge FIB and the FIB update time so this is just as
> significant in understanding the benefit of multi-level as understanding the
> link-state convergence time is.

The number of MAC (actually MAC/VLAN or MAC/FGL) addresses to be
learned by an edge TRILL switch is not affected by whether the TRILL
campus uses single or multilevel IS-IS. This number of MAC address
learned is the seventh scaling problem listed in Section 1.1 which
states that multilevel TRILL IS-IS helps only with the other six
problems. This point, that multilevel doesn't help here, could be
emphasized more but I don't think I see much point in this document in
going into details such as the scaling considerations of data plane
MAC address learning (which is the default in TRILL) or control plan
MAC address learning (which does not use the core LSDB but rather Data
Label scoped ESADI link stat databases).

Thanks,
Donald
===============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 155 Beaver Street, Milford, MA 01757 USA
 d3e3e3@gmail.com

> Nits/editorial comments: None
>
>