Re: [trill] AD review of draft-ietf-trill-pseudonode-nickname-04

Donald Eastlake <d3e3e3@gmail.com> Thu, 06 August 2015 03:08 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 684831B36B3 for <trill@ietfa.amsl.com>; Wed, 5 Aug 2015 20:08:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.75
X-Spam-Level:
X-Spam-Status: No, score=-1.75 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RSTYsNwSr0Xp for <trill@ietfa.amsl.com>; Wed, 5 Aug 2015 20:08:06 -0700 (PDT)
Received: from mail-ob0-x235.google.com (mail-ob0-x235.google.com [IPv6:2607:f8b0:4003:c01::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0B1541B36B0 for <trill@ietf.org>; Wed, 5 Aug 2015 20:08:06 -0700 (PDT)
Received: by obnw1 with SMTP id w1so46330482obn.3 for <trill@ietf.org>; Wed, 05 Aug 2015 20:08:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=KKJnw4df6jbYSyck03Kf/MhxKe0OTF1n8rSrJX25wXM=; b=aLE58keamL5qYvgKLd732cmn4dffAhweNVckkwVo3beIAVuDehRr/+8Fk43HcCNmYP S2ifTFhdfzLoUZ+r8BLrhZLj0SOYV8cgYfg/llmNP8dUsUTpKUp/S8xdy0Sa8TXc3Fnb ZKs/iWcX4gm0Ura+GRMQ/PPwZmDMjdjZkz2YKeowk5pSukp0+nSxKhNnsjvvuZ3hFXx7 O/bCZM69++tzANipUZ5ZlyAtrekQChWP3H7fIckNH2bSRtj2xGP/oekJiZ4qmDXJG1O6 +/MeWojlIW3Y8Vv9ETGGl1yYRXy3FLBFIgG4MEFL2WVPLu8L+hOoMM38+0KEc9h62RmM 5Yvg==
X-Received: by 10.182.196.72 with SMTP id ik8mr10903109obc.36.1438830485410; Wed, 05 Aug 2015 20:08:05 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.76.173.3 with HTTP; Wed, 5 Aug 2015 20:07:50 -0700 (PDT)
In-Reply-To: <4552F0907735844E9204A62BBDD325E787164186@nkgeml512-mbx.china.huawei.com>
References: <CAG4d1rc_zjEkSU+zyvEGR76hmnqbi363-p=frsK192qapCGrDA@mail.gmail.com> <4552F0907735844E9204A62BBDD325E787164186@nkgeml512-mbx.china.huawei.com>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Wed, 05 Aug 2015 23:07:50 -0400
Message-ID: <CAF4+nEHxs5L3xjZJwC83MockLsj0tUu_bppWNZ6ej0RckjxOcg@mail.gmail.com>
To: Mingui Zhang <zhangmingui@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <http://mailarchive.ietf.org/arch/msg/trill/pHkbm8JxrXowWMDJZGYXmVWqK8I>
Cc: "trill@ietf.org" <trill@ietf.org>, "draft-ietf-trill-pseudonode-nickname@tools.ietf.org" <draft-ietf-trill-pseudonode-nickname@tools.ietf.org>, Alia Atlas <akatlas@gmail.com>
Subject: Re: [trill] AD review of draft-ietf-trill-pseudonode-nickname-04
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Aug 2015 03:08:07 -0000

See below

On Sun, Aug 2, 2015 at 11:45 PM, Mingui Zhang <zhangmingui@huawei.com> wrote:
> Hi Alia,
>
> Please see comments inline with [mingui].
>
> From: trill [mailto:trill-bounces@ietf.org] On Behalf Of Alia Atlas
> Sent: Friday, July 31, 2015 6:30 AM
> To: trill@ietf.org; draft-ietf-trill-pseudonode-nickname@tools.ietf.org; Don
> Eastlake
> Subject: [trill] AD review of draft-ietf-trill-pseudonode-nickname-04
>
> ...
>
> Here are the details of my review:
>
> Minor concerns:
>
> 1) On p. 15 & 16: I'm a bit confused because on p. 15, it says "The basic
> idea of DF is to elect one RBridge per VLAN from an RBv to egress
> multi-destination TRILL Data traffic and replicate locally-received
> multi-destination native frames to the CEs served by the RBv."  but
> then on p. 16 in Step 4 part 1), it says: "RBv ports associated with
> the same pseudo-nickname as that of the incoming port, no matter
> whether RBi is the DF for the frame's VLAN on the outgoing ports
> except that the frame MUST NOT be replicated back to the incoming
> port".  This seems to be contradictory.
>
> [mingui] Let me explain the logic. If the RBridge in a RBv group receives a
> BUM packet from a locally connected CE.  Other CEs will receive the packet
> replicated by the DF only. Other RBridges will refrain from replicating.
>    Having said that, it is also important that the DF never replicates the BUM
> packet back to the incoming port (Say CE1 sends the BUM packet to the DF RB1
> via port 1, then RB1 does not send the replicated BUM packet back to CE1 via
> port 1.)
>
> Moreover, if one say CE1,
>
> CE2, and CE3 all in the same RBv, when CE1 sends a packet to RB2 and
> RB1 is the DF for the particularly VLAN, then wouldn't RB2 forward the
> packet to CE1 and CE2 while RB1 would also do so as the DF?
>
> [mingui] As explained above, RB2 will refrain from replicating since it is
> not the DF.

Probably the wording can be clarified.

> Could you
> please clarify what is causing the inconsistency and problem?  Maybe
> the text in 6.1 on p. 18 helps describe that there are actually two
> cases to the text on p. 16?
>
> [mingui] Yes, I agree.
>
> 2) On p.23 in Sec 9.1: There is no way of identifying what the type of
> the LAALP ID is.  Assuming it is a number and meaning doesn't matter,
> it would be really good to clarify that.
>
> [mingui] Agree.

The general requirement is that the LAALP ID identify the
active-active edge group of end stations and the LAALP for a
particular group must be unique across the TRILL campus. As far as I
know, currently the only type of value used for the LAALP ID is an
8-byte MC-LAG/DRNI ID. Perhaps the document should (1) indicate the
general requirement, (2) state that if the length is 8 it MUST be an
MC-LAG/DRNI ID, and (3) say that the type of LAALP ID value for any
other length will be specified in a future document.

> 3) In Sec 9.2: How can an LAALP ID be withdrawn from PN-RBv
> APPsub-TLV?  Could you please describe that sequence?
>
> [mingui] I think, if RBx needs to just withdraw one LAALP ID, it will
> refresh the previous announced LSP by omitting that LAALP ID from the LAALP
> ID list in the PN-RBv APPsub-TLV.

The APPsub-TLV (which is inside a TRILL GENINFO IS-IS TLV) is link
state although it is not part of the base routing information LSP. It
is distributed in E-L1FS FS-LSPs (support for which is required by
draft-ietf-trill-rfc7180bis which is also in publication requested
state). So the contents of the APPsub-TLV can be changed or it can be
withdrawn by changing the FS-LSP fragment in which it occurs.

> Thanks,
> Mingui
>
> Thanks,
> Alia

Thanks,
Donald
=============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 155 Beaver Street, Milford, MA 01757 USA
 d3e3e3@gmail.com