Re: [trill] [Gen-art] Genart telechat review of draft-ietf-trill-transport-over-mpls-07

Alissa Cooper <alissa@cooperw.in> Thu, 08 March 2018 02:44 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: trill@ietfa.amsl.com
Delivered-To: trill@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 42FF7126C22; Wed, 7 Mar 2018 18:44:25 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.721
X-Spam-Level:
X-Spam-Status: No, score=-2.721 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=P6btGgtF; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=EkOdYHfg
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EoBoNAusDoJR; Wed, 7 Mar 2018 18:44:23 -0800 (PST)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9798B1241F5; Wed, 7 Mar 2018 18:44:20 -0800 (PST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 09E4121428; Wed, 7 Mar 2018 21:44:20 -0500 (EST)
Received: from frontend1 ([10.202.2.160]) by compute7.internal (MEProxy); Wed, 07 Mar 2018 21:44:20 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=7QGHKDv/4LnUG5ul7JYZfaMnE4MqO JcdnNYqi+pOZiY=; b=P6btGgtFD1MAaJMNIi8wbkCRzNh91f4XCo+P0vbKuWcgD WXS37OSVq/Tq6KNnXiW/V8XDjQBd82iUZ5iu/VRYkZGJQmQNaEsJss+004cjEJv9 VTKRYIigoyPq9ObxfDfRLpMJXjakmpKmgD6tGqf8AdMuG47W4lcJQdqselQSmxsD 65d1F0no353BRGU/b7CpEkih66PgKfnOe2qU9OTZbdYYXX+h4VLKmrvE+e6jazdU izhJlmae6kORQ7i2OXtlPz0gtiROcwfW+n9aezpQdQ/RDhAfQBB+qhdcM0D3vOr7 FKFKat7gIDD+AsS3hjaF4sV7cQgonbHNopkiCAJzg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=7QGHKD v/4LnUG5ul7JYZfaMnE4MqOJcdnNYqi+pOZiY=; b=EkOdYHfgnCtTH7UzZ3PbBx Ov0fSFBK79YvFhoPRcA4pz9RBEBdBdi0eVf2dGnKyQUjiFPMXzjvsJNSjKxHrwxj 8Yxry6xBC965G3LOXL6Zq1EUKrub0uxJeuwrCJDSrFrtZVQg8N0xWm61nFfdbNHy RyberV3WgMyEbapJvA7LkFly4qpGjDxaPPeyVgG0ivbjr+PSk7t4HZftkOY0vPx5 vDp1VksSHfLsvhkw3B4m4f7n9WzDiyCVXBnmrQJ6wf7FvbEssWkSoq+pFbB0htvA LFJTd8Ebxe8WVUV+khGWHVf21RmSfBYYJAqe98YAU8olkJhNJwky2JcXe1Ppzbtg ==
X-ME-Sender: <xms:g6OgWmg4hjkVthgEEhExTufT_BUTIJ6ny7hdaTN1pVjUWypN1ackbQ>
Received: from [10.19.234.245] (unknown [128.107.241.170]) by mail.messagingengine.com (Postfix) with ESMTPA id 07CBC7E2C4; Wed, 7 Mar 2018 21:44:18 -0500 (EST)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <152002231785.15775.13618527763271574655@ietfa.amsl.com>
Date: Wed, 7 Mar 2018 21:44:17 -0500
Cc: General Area Review Team <gen-art@ietf.org>, draft-ietf-trill-transport-over-mpls.all@ietf.org, trill IETF mailing list <trill@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <F56853F8-9612-4532-90C5-C3DA835A5234@cooperw.in>
References: <152002231785.15775.13618527763271574655@ietfa.amsl.com>
To: Stewart Bryant <stewart.bryant@gmail.com>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/trill/pabzRJfyfbqKYQrrx_FYuf6h27M>
Subject: Re: [trill] [Gen-art] Genart telechat review of draft-ietf-trill-transport-over-mpls-07
X-BeenThere: trill@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Developing a hybrid router/bridge." <trill.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/trill>, <mailto:trill-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/trill/>
List-Post: <mailto:trill@ietf.org>
List-Help: <mailto:trill-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/trill>, <mailto:trill-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Mar 2018 02:44:25 -0000

Stewart, thanks for your review. I entered a No Objection ballot.

Alissa

> On Mar 2, 2018, at 3:25 PM, Stewart Bryant <stewart.bryant@gmail.com> wrote:
> 
> Reviewer: Stewart Bryant
> Review result: Ready with Issues
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair. Please wait for direction from your
> document shepherd or AD before posting a new version of the draft.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-trill-transport-over-mpls-07
> Reviewer: Stewart Bryant
> Review Date: 2018-03-02
> IETF LC End Date: 2018-03-06
> IESG Telechat date: 2018-03-08
> 
> Summary: An understandable document. The only comment of note is the conflation
> of PW headers and MPLS headers. There are a couple of easy to fix nits.
> 
> Major issues: None
> 
> Minor issues:
> 
> 6. Packet Processing Between Pseudowires
> 
> In this section you conflate PW headers and MPLS headers.
> The PW label is a type of  MPLS label, although it has its own forwarding
> instruction, but the control word is not part of MPLS.
> 
> Nits/editorial comments:
> 
> There is an ASCII art error in Fig 1 on the line containing Tenant1 Site1
> 
> The terms PE device and PE router seem to be used interchangeably.  Is this an
> error, or are they distinct devices.
> 
> The VTSD must be capable of forming TRILL adjacency with the
> SB> Should be "forming a TRILL adjacency"
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art