Re: [Tsv-art] [Last-Call] Tsvart last call review of draft-ietf-sfc-nsh-integrity-06

Joseph Touch <touch@strayalpha.com> Thu, 29 July 2021 15:21 UTC

Return-Path: <touch@strayalpha.com>
X-Original-To: tsv-art@ietfa.amsl.com
Delivered-To: tsv-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 185623A25F1; Thu, 29 Jul 2021 08:21:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.32
X-Spam-Level:
X-Spam-Status: No, score=-1.32 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=strayalpha.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n1NeuA9VDGpT; Thu, 29 Jul 2021 08:21:12 -0700 (PDT)
Received: from server217-4.web-hosting.com (server217-4.web-hosting.com [198.54.116.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3B2DB3A2657; Thu, 29 Jul 2021 08:21:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=strayalpha.com; s=default; h=To:References:Message-Id: Content-Transfer-Encoding:Cc:Date:In-Reply-To:From:Subject:Mime-Version: Content-Type:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/JgIbfeXSEMGpttQD7tcS8cQ/qsrhLRy7oErnCBEROI=; b=GhSvC/B8iHvoxFYGAAuh4dZd0f w78bRRSdlhrpzbBXa0T87L48c/6546ikXnNNQbjmz7wVUlHTUf0psfSTIIErY2kKMea97D8Mby1em fp/5i4Qh1/aigYxJ0M7Bnrouc+BHgUfgyVeTz6dIPBZ+Zk5aU5StR150iwdOzd7QkDr8EPy2H7m60 0fLbNCDTca9/7t2kREKp0KWCdrzUPQ5ABP7jMIQZBCUln4bhhKFW08Igbabr5K16G+O7kqRaFFgSJ QgA3CFRvKNBV4CJyjgN6fDQUis89M5IpkpUCsUM+V9RdwG6ZWfkeay1UCd7mGTRUJfz7e1dyq1BlN Y4SKYO3Q==;
Received: from cpe-172-114-237-88.socal.res.rr.com ([172.114.237.88]:50286 helo=smtpclient.apple) by server217.web-hosting.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <touch@strayalpha.com>) id 1m97qK-000R8T-GZ; Thu, 29 Jul 2021 11:21:09 -0400
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\))
From: Joseph Touch <touch@strayalpha.com>
In-Reply-To: <031a8199-7a93-afc7-37e4-7fcdb4733c60@joelhalpern.com>
Date: Thu, 29 Jul 2021 08:21:01 -0700
Cc: tirumal reddy <kondtir@gmail.com>, tsv-art <tsv-art@ietf.org>, draft-ietf-sfc-nsh-integrity.all@ietf.org, sfc@ietf.org, last-call@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <45937185-139B-4948-8635-DBAAE044F797@strayalpha.com>
References: <CAFpG3gdRLTQvuoaEeRAhDUAqD3yBQ0jdBpZJzSvrJVPN-bMKTg@mail.gmail.com> <FA6B54B4-28FA-4C19-AB37-66B54B22E53E@strayalpha.com> <031a8199-7a93-afc7-37e4-7fcdb4733c60@joelhalpern.com>
To: "Joel M. Halpern" <jmh@joelhalpern.com>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
X-OutGoing-Spam-Status: No, score=-0.5
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - server217.web-hosting.com
X-AntiAbuse: Original Domain - ietf.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - strayalpha.com
X-Get-Message-Sender-Via: server217.web-hosting.com: authenticated_id: touch@strayalpha.com
X-Authenticated-Sender: server217.web-hosting.com: touch@strayalpha.com
X-Source:
X-Source-Args:
X-Source-Dir:
X-From-Rewrite: unmodified, already matched
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/1RCP3IAokXQ6FrcVP96NGadc8xI>
Subject: Re: [Tsv-art] [Last-Call] Tsvart last call review of draft-ietf-sfc-nsh-integrity-06
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jul 2021 15:21:17 -0000

Joel,

I performed this review for the transport area.

An IETF document should never attempt to redefine the word “transport” in a single sentence and refer to an unpublished draft (even mine) to explain. It takes more than that.

> On Jul 29, 2021, at 8:01 AM, Joel M. Halpern <jmh@joelhalpern.com> wrote:
> 
> If you want the terminology usage clarified, then what they have proposed is sufficient.
> 
> If you want to change RFC 8300, this is not the place to do that.

Agreed, but we cannot continue to propagate the error. At a minimum, the sentence should clarify that the term is being used inconsistently with the rest of IETF as a whole and explain what it means in a stand-alone way. That either warrants a separate (even if brief) section or at least a terminology section entry.

Additionally, it is not feasible to review how their approach - which makes packets bigger, necessarily - without understanding how that tunneling works.

Joe

> On 7/29/2021 12:41 AM, Joe Touch wrote:
>> Insufficient.
>>> On Jul 28, 2021, at 7:09 AM, tirumal reddy <kondtir@gmail.com> wrote:
>>> 
>>> 
>>> Thanks Joseph for the detailed comment and explanation. We plan to add the following text to address the issue:
>>> 
>>> Note that the term “transport encapsulation” used in this document is equivalent to the term “tunnel encapsulation” used In [ietf-intarea-tunnel].
>>> 
>>> 
>>> Cheers,
>>> 
>>> -Tiru
>>> 
>>> 
>>> On Mon, 26 Jul 2021 at 10:34, Joseph Touch via Datatracker <noreply@ietf.org <mailto:noreply@ietf.org>> wrote:
>>> 
>>>    Reviewer: Joseph Touch
>>>    Review result: Not Ready
>>> 
>>>    This document has been reviewed as part of the transport area
>>>    review team's
>>>    ongoing effort to review key IETF documents. These comments were
>>>    written
>>>    primarily for the transport area directors, but are copied to the
>>>    document's
>>>    authors and WG to allow them to address any issues raised and also
>>>    to the IETF
>>>    discussion list for information.
>>> 
>>>    When done at the time of IETF Last Call, the authors should
>>>    consider this
>>>    review as part of the last-call comments they receive. Please
>>>    always CC
>>>    tsv-art@ietf.org <mailto:tsv-art@ietf.org> if you reply to or
>>>    forward this review.
>>> 
>>>    It was very difficult to review this document for IETF transport
>>>    protocol
>>>    considerations.
>>> 
>>>    Although "transport encapsulation" is indicated repeatedly, it is
>>>    never
>>>    referred to directly or described either in this document or its
>>>    citations. It
>>>    appears to be using this term in the sense of RFC8300, which too
>>>    never defines
>>>    it, but uses examples that are more accurately referred to in the
>>>    IETF as link
>>>    layer protocols or either network or link tunnel protocols (IP in
>>>    IP, GRE,
>>>    VXLAN, Ethernet).
>>> 
>>>    Regardless of the fact that this confusion originates in RFC8300,
>>>    it needs to
>>>    be addressed here and corrected before this document can be
>>>    reviewed to
>>>    determine if there are any IETF transport area issues.
>>> 
>>>    The remainder of these notes provide detail of this issue.
>>> 
>>>    -----
>>> 
>>>    The document refers back to RFC8300 to define the NSH itself; that
>>>    document
>>>    discusses transport issues just as vaguely (never mentioning a
>>>    particular
>>>    transport protocol), and when it discusses fragmentation, it
>>>    refers to section
>>>    9 of a document (draft-ietf-rtgwg-dt-encap-02 from 2017) that had
>>>    expired prior
>>>    to the publication of RFC8300.  Because transport fragmentation
>>>    is, IMO, a
>>>    normative issue, this should not have been permitted.
>>> 
>>>    Further, Section 9 of that draft incorrectly recommends reliance
>>>    on ICMP
>>>    feedback to address MTU failures when not under a single
>>>    operator’s management.
>>>    That was widely known even then to be insufficient due to
>>>    blackholing; this had
>>>    motivated PLPMTUD in RFC4821 a full decade earlier. RFC8300
>>>    compounds this
>>>    error by simply asserting that the operator should ensure that
>>>    ICMPs are not
>>>    blocked, overlooking the need to address when this is not the case.
>>> 
>>>    This document cannot ignore that issue and simply refer to RFC8300
>>>    on this
>>>    issue.
>>> 
>>>    Note that one of the only places an actual encapsulation protocol
>>>    is mentioned
>>>    is RFC8300, in which Section 5 mentions IP and  Section 6.1 Table
>>>    1 describes
>>>    VXLAN-GPE, GRE, and Ethernet – all of which are described as
>>>    “transport
>>>    encapsulation”.
>>> 
>>>    If, in fact, IETF transport protocols are being used, at some
>>>    point the use of
>>>    an actual IETF transport protocol should be described (e.g., TCP,
>>>    UDP, SCTP,
>>>    DCCP). At that point, the transport issues would be reviewable. As
>>>    the document
>>>    currently stands, it completely ignores such transport issues and
>>>    should not
>>>    proceed until this is addressed and re-reviewed.
>>> 
>>>    If instead, as I suspect, the term “transport encapsulation”
>>>    actually refers to
>>>    “network layer encapsulation” or “link layer encapsulation” and
>>>    really implies
>>>    some sort of tunnel, there would be no transport area issues to
>>>    review unless
>>>    that tunnel were to include a transport protocol as part of the
>>>    layers of
>>>    encapsulation. If that is the case, the document should be revised
>>>    to replace
>>>    the term “transport” with something that more accurately describes
>>>    VXLAN-GPE,
>>>    GRE, Ethernet, and IP encapsulation using IETF terminology. Note that
>>>    draft-ietf-intarea-tunnels never uses the term “transport” except when
>>>    referring to the use of IETF transport protocols as a tunnel
>>>    layer, e.g. (i.e.,
>>>    the last sentence of Sec 8 of this doc is incorrect in implying
>>>    otherwise).
>>> 
>>>    (I would also note that neither this doc nor RFC8300 define “transport
>>>    encapsulation” in their terminology; even if they would, they
>>>    should not
>>>    attempt to define it in a way inconsistent with widespread use in
>>>    the IETF).
>>> 
>>> 
>>> 
>>> -- 
>>> last-call mailing list
>>> last-call@ietf.org
>>> https://www.ietf.org/mailman/listinfo/last-call
> 
> -- 
> last-call mailing list
> last-call@ietf.org
> https://www.ietf.org/mailman/listinfo/last-call