Re: [Tsv-art] Tsvart last call review of draft-ietf-idr-te-pm-bgp-15

"Susan Hares" <shares@ndzh.com> Fri, 14 December 2018 14:49 UTC

Return-Path: <shares@ndzh.com>
X-Original-To: tsv-art@ietfa.amsl.com
Delivered-To: tsv-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D9A021288BD; Fri, 14 Dec 2018 06:49:26 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.947
X-Spam-Level:
X-Spam-Status: No, score=0.947 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DOS_OUTLOOK_TO_MX=2.845, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id finG4ZJeZBdI; Fri, 14 Dec 2018 06:49:24 -0800 (PST)
Received: from hickoryhill-consulting.com (50-245-122-97-static.hfc.comcastbusiness.net [50.245.122.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AC5101277BB; Fri, 14 Dec 2018 06:49:23 -0800 (PST)
X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=166.177.57.147;
From: "Susan Hares" <shares@ndzh.com>
To: "'Les Ginsberg \(ginsberg\)'" <ginsberg@cisco.com>, "'Yoshifumi Nishida'" <nishida@sfc.wide.ad.jp>
Cc: <nishida@wide.ad.jp>, <tsv-art@ietf.org>, <idr@ietf.org>, <ietf@ietf.org>, <draft-ietf-idr-te-pm-bgp.all@ietf.org>
References: <154469190410.2732.7123292408392294701@ietfa.amsl.com> <d07090284c9f46f48c5d479297b4a865@XCH-ALN-001.cisco.com> <CAO249yd5v3pDuOgLqmVsp2yr+zfXWJyvSx6b67kM21Tusza7DQ@mail.gmail.com> <9eff1b233b484c9cb6dae8b64dff6d89@XCH-ALN-001.cisco.com>
In-Reply-To: <9eff1b233b484c9cb6dae8b64dff6d89@XCH-ALN-001.cisco.com>
Date: Fri, 14 Dec 2018 09:49:18 -0500
Message-ID: <006a01d493bc$31912ec0$94b38c40$@ndzh.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="----=_NextPart_000_006B_01D49392.48BD97C0"
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQDZ28V8NsfnFsTpD4hdo6VWIHblPAMBQV0tAVeIPmcBkr5qoadEYhcw
Content-Language: en-us
X-Antivirus: AVG (VPS 181214-4, 12/14/2018), Outbound message
X-Antivirus-Status: Not-Tested
X-Authenticated-User: skh@ndzh.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/25k16ifJCfW1rDD_MuEL7O0GPCc>
Subject: Re: [Tsv-art] Tsvart last call review of draft-ietf-idr-te-pm-bgp-15
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Dec 2018 14:49:27 -0000

Les and Yoshi:

 

You both raised two sides of the issue regarding the BGP-LS TLVs when these TLVs align with IGP TLVs. 

 

Side 1: It is helpful to note that the TLVs are the same

Side 2: It is confusing to have this information in individual drafts.    

 

This is not a single draft issue but a concern regarding several drafts in the BGP-LS series from IDR.

 

Yoshi -  Would it help the clarity of the BGP-LS series to have an explanatory draft that indicates the places to find the alignment?  Or should we suggest a note to IANA registration to provide clarity.  

 

Thank you for raising both sides of this issue.   Your IDR chairs and AD have been discussing how to make this easier to understand for implementers and those who deploy the BGP-LS code.  

 

Susan Hares 

 

From: Les Ginsberg (ginsberg) [mailto:ginsberg@cisco.com] 
Sent: Thursday, December 13, 2018 4:57 PM
To: Yoshifumi Nishida
Cc: nishida@wide.ad.jp; tsv-art@ietf.org; idr@ietf.org; ietf@ietf.org; draft-ietf-idr-te-pm-bgp.all@ietf.org
Subject: RE: Tsvart last call review of draft-ietf-idr-te-pm-bgp-15

 

Yoshi –

 

Inline.

 

From: Yoshifumi Nishida <nishida@sfc.wide.ad.jp>; 
Sent: Thursday, December 13, 2018 11:16 AM
To: Les Ginsberg (ginsberg) <ginsberg@cisco.com>;
Cc: nishida@wide.ad.jp; tsv-art@ietf.org; idr@ietf.org; ietf@ietf.org; draft-ietf-idr-te-pm-bgp.all@ietf.org
Subject: Re: Tsvart last call review of draft-ietf-idr-te-pm-bgp-15

 

Hi Les,

On Thu, Dec 13, 2018 at 10:13 AM Les Ginsberg (ginsberg) <ginsberg@cisco.com>; wrote:

Yoshi -

Thanx for the review.
Replies inline.

> -----Original Message-----
> From: Yoshifumi Nishida <nishida@wide.ad.jp>;
> Sent: Thursday, December 13, 2018 1:05 AM
> To: tsv-art@ietf.org
> Cc: idr@ietf.org; ietf@ietf.org; draft-ietf-idr-te-pm-bgp.all@ietf.org
> Subject: Tsvart last call review of draft-ietf-idr-te-pm-bgp-15
> 
> Reviewer: Yoshifumi Nishida
> Review result: Ready with Nits
> 
> This document has been reviewed as part of the transport area review
> team's
> ongoing effort to review key IETF documents. These comments were written
> primarily for the transport area directors, but are copied to the document's
> authors and WG to allow them to address any issues raised and also to the
> IETF
> discussion list for information.
> 
> When done at the time of IETF Last Call, the authors should consider this
> review as part of the last-call comments they receive. Please always CC
> tsv-art@ietf.org if you reply to or forward this review.
> 
> Summary: Ready with Nits
> 
> 1: The TLV formats in the draft look identical with RFC7471 except the value in
> Type field.
>      it would be better to clarify this points so that the readers who are
>      familiar with RFC7471 can interpret them easily. I am also wondering if
>      the format figures of TLV are necessary when the same figures are already
>      presented in RFC7471.
> 

[Les:] The draft says:

Section 2

" TLV formats follow the rules defined in [RFC7752]."

Then in each subsequent sub-section 2.x  both RFC 7471 and draft-ietf-lsr-isis-rfc7810bis are explicitly referenced.

The TLV formats need to be presented here since these are the BGP-LS encodings, which are similar to but NOT identical to the IGP specific encodings (for example IS-IS encoding uses an 8-bit type/length).

 

Right. But, but in case of OSPF, I think the format will be identical except the type field value. 

I just thought if you add one sentence to clarify the formats happen to be the same as 7471, it could be a small benefit for OSPF users.

But, this is not a strong opinion. 

 

[Les:] The format follows RFC7752. It just happens in this case the format for these TLVs matches OSPF – that isn’t always the case. As a practical matter I don’t think it helps implementers to point out when BGP-LS TLVs are identical to protocol X or protocol Y.

 

> 2: There is no guidance for default values such as measurement interval in
> the
> draft. If these values should also be inherited from other draft, it should be
> stated.
> 
[Les:] This is not within the purview of this draft. All this draft is doing is defining the encodings for the BGP-LS advertisements which are essentially copies of what the IGPs are advertising.

 

Does it mean when an IGP advertises these metrics at 10 sec interval, the BGP-LS will be advertised at the same interval? 

 

[Les:] The IGP RFCs provide significant detail on the importance of controlling the rate of change of advertisements.

Given that, yes – I would expect that updates are provided to BGP whenever the IGP advertisements change.

BGP implementations typically have their own knobs to control the frequency of BGP updates – but given the filtering done at the source I would hope implementations have no need for additional dampening in BGP itself – but that is an implementation choice.

 

  Les

 

Thanks,

--

Yoshi