[Tsv-art] Tsvart last call review of draft-ietf-perc-private-media-framework-08
Gorry Fairhurst <gorry@erg.abdn.ac.uk> Mon, 04 February 2019 17:33 UTC
Return-Path: <gorry@erg.abdn.ac.uk>
X-Original-To: tsv-art@ietf.org
Delivered-To: tsv-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id BDDC0130EB7; Mon, 4 Feb 2019 09:33:18 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Gorry Fairhurst <gorry@erg.abdn.ac.uk>
To: tsv-art@ietf.org
Cc: ietf@ietf.org, draft-ietf-perc-private-media-framework.all@ietf.org, perc@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.91.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <154930159870.28630.16457371613620717540@ietfa.amsl.com>
Date: Mon, 04 Feb 2019 09:33:18 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/3UuXsqLOlU3McKO1UROef_BoyPI>
Subject: [Tsv-art] Tsvart last call review of draft-ietf-perc-private-media-framework-08
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Feb 2019 17:33:19 -0000
Reviewer: Gorry Fairhurst Review result: Ready with Nits This document has been reviewed as part of the transport area review team's ongoing effort to review key IETF documents. These comments were written primarily for the transport area directors, but are copied to the document's authors and WG to allow them to address any issues raised and also to the IETF discussion list for information. The authors should consider this review as part of the last-call comments they receive. Please always CC tsv-art@ietf.org if you reply to or forward this review. There are two other IETF drafts cited normally by this document, also in last call. This document defines a security architecture based around an IETF transport, but does not itself propose updates to the transport mechanisms. I did not find additional transport concerns, but have a number of general comments I'd like you to consider in the LC. ---- General comments Some keywords appear not defined before first used - whilst these are likely to be well-known by the coimmunity of interest, it would none-the-less be helpful to define these: SRTP; RTCP; SIP; SDP. In section 8.1, there is a sentence starting "Off-path atttackers may" ... while this is lower case, the authors may wish toi consider using "could" to remove any possibility of this being regarded as permissive. In 8.1, the text "could incorrectly assuming their packets..." probably ought to read could incorrectly assume their packets..." In section 8.2.1. there is a dscription of a resource consumption attack, but no miitigation is described. It could be possible to consider using rate-limiting of requests to reduce the impact - a mthod commonly suggested in other attacks on the transport endpoints.
- [Tsv-art] Tsvart last call review of draft-ietf-p… Gorry Fairhurst
- Re: [Tsv-art] Tsvart last call review of draft-ie… Paul E. Jones
- Re: [Tsv-art] Tsvart last call review of draft-ie… Ben Campbell
- Re: [Tsv-art] [Perc] Tsvart last call review of d… Paul E. Jones
- Re: [Tsv-art] Tsvart last call review of draft-ie… Gorry Fairhurst
- Re: [Tsv-art] Tsvart last call review of draft-ie… Paul E. Jones