Re: [Tsv-art] Tsvart telechat review of draft-ietf-6man-rfc6434-bis-08

"Black, David" <David.Black@dell.com> Fri, 06 July 2018 19:50 UTC

Return-Path: <David.Black@dell.com>
X-Original-To: tsv-art@ietfa.amsl.com
Delivered-To: tsv-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8A7FF130F06; Fri, 6 Jul 2018 12:50:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.71
X-Spam-Level:
X-Spam-Status: No, score=-2.71 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=dell.com header.b=gqgjauvT; dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=emc.com header.b=l4DUt17E
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8jTGG8aV9JRF; Fri, 6 Jul 2018 12:50:07 -0700 (PDT)
Received: from esa3.dell-outbound.iphmx.com (esa3.dell-outbound.iphmx.com [68.232.153.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AB5D412F1A6; Fri, 6 Jul 2018 12:50:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dell.com; i=@dell.com; q=dns/txt; s=smtpout; t=1530906517; x=1562442517; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=6VTrbYX4FV9MMvkzaXILuSJ0rpxP5zrE2GKGwZXiyIs=; b=gqgjauvT8RrIdCIzvs+DBZ/Vb5FkJ9XpUTiX+LxnxHkEKNV8n4IkwjSQ 83oOfUdpNIqJYaEnmdHORUY3Sk9eePjS/8OVPH1HZQKZPYmzcw3x8Q894 vf02KJuZV1oQd5cdQb+br8t9/SEkyqNva88+U7k1O4BRLYJADaMCmBuzr M=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A2FOAAA3xz9bmMuZ6ERcGgEBAQEBAgEBAQEIAQEBAYJ1gSgOfygKi3SMNYIHlTKBPzsLGAsLhD4Cgi4hNBgBAgEBAgEBAgEBAhABAQEBAQgLCwYpIwyCNSQBDi8cLwgGAQEBAQEBJwEBAQEBAQEBAQEBAQEBAQEBARcCQwESAQEYAQEBAQIBAQE4Bh8PCwEEBwICAgEIEQEDAQEBChQJBxsMCxQDBggCBAENBQiDGAGBdwgBDqt2gniFUoEyAwUFh1+BCYFXPoEPgw+DGAEBAgGBX4MwgiSHZJFtAwQCAoYGil2EDIgMijWHLwIEAgQFAhSBQYILcFCCaYIyg06FFIU+bwGNeoEaAQE
X-IPAS-Result: A2FOAAA3xz9bmMuZ6ERcGgEBAQEBAgEBAQEIAQEBAYJ1gSgOfygKi3SMNYIHlTKBPzsLGAsLhD4Cgi4hNBgBAgEBAgEBAgEBAhABAQEBAQgLCwYpIwyCNSQBDi8cLwgGAQEBAQEBJwEBAQEBAQEBAQEBAQEBAQEBARcCQwESAQEYAQEBAQIBAQE4Bh8PCwEEBwICAgEIEQEDAQEBChQJBxsMCxQDBggCBAENBQiDGAGBdwgBDqt2gniFUoEyAwUFh1+BCYFXPoEPgw+DGAEBAgGBX4MwgiSHZJFtAwQCAoYGil2EDIgMijWHLwIEAgQFAhSBQYILcFCCaYIyg06FFIU+bwGNeoEaAQE
Received: from esa5.dell-outbound2.iphmx.com ([68.232.153.203]) by esa3.dell-outbound.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jul 2018 14:48:35 -0500
From: "Black, David" <David.Black@dell.com>
Received: from mailuogwdur.emc.com ([128.221.224.79]) by esa5.dell-outbound2.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jul 2018 01:41:29 +0600
Received: from maildlpprd52.lss.emc.com (maildlpprd52.lss.emc.com [10.106.48.156]) by mailuogwprd52.lss.emc.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.0) with ESMTP id w66Jo34M016002 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 6 Jul 2018 15:50:04 -0400
X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd52.lss.emc.com w66Jo34M016002
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=emc.com; s=jan2013; t=1530906604; bh=8RmIJ0z+UU4xF8TBchPx2rT7dIM=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:Content-Transfer-Encoding:MIME-Version; b=l4DUt17E+GSDNU/PWRj63sdAsTNk28QLy/sTkpVTSlnbkev2juYCouRTMWPAXOny6 D7P49WvKh3sM1OQOsw8sKg3XMSYSNsf8zLLOsV3NJUFdHwTJL4XkHyEXBxXu6uDBbk 0gRH4cOZTB/7MvUw7hYGePWW/xRl7XoEcXgzGDLA=
X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd52.lss.emc.com w66Jo34M016002
Received: from mailusrhubprd04.lss.emc.com (mailusrhubprd04.lss.emc.com [10.253.24.22]) by maildlpprd52.lss.emc.com (RSA Interceptor); Fri, 6 Jul 2018 15:49:41 -0400
Received: from MXHUB313.corp.emc.com (MXHUB313.corp.emc.com [10.146.3.91]) by mailusrhubprd04.lss.emc.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.0) with ESMTP id w66JnvJ6011746 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=FAIL); Fri, 6 Jul 2018 15:49:57 -0400
Received: from MX307CL04.corp.emc.com ([fe80::849f:5da2:11b:4385]) by MXHUB313.corp.emc.com ([10.146.3.91]) with mapi id 14.03.0382.000; Fri, 6 Jul 2018 15:49:57 -0400
To: Magnus Westerlund <magnus.westerlund@ericsson.com>, Brian E Carpenter <brian.e.carpenter@gmail.com>, "tsv-art@ietf.org" <tsv-art@ietf.org>
CC: "draft-ietf-6man-rfc6434-bis.all@ietf.org" <draft-ietf-6man-rfc6434-bis.all@ietf.org>, "ipv6@ietf.org" <ipv6@ietf.org>
Thread-Topic: [Tsv-art] Tsvart telechat review of draft-ietf-6man-rfc6434-bis-08
Thread-Index: AQHUEtyQRl3+yz3rw0aSC3fkagB8AqR+O7YAgAC1+wCAA6orYA==
Date: Fri, 06 Jul 2018 19:49:57 +0000
Message-ID: <CE03DB3D7B45C245BCA0D24327794936301A7589@MX307CL04.corp.emc.com>
References: <153062913573.4970.1895339267284208631@ietfa.amsl.com> <b096cc14-3d7e-5712-63f5-096525a007ca@gmail.com> <7d46a4cf-a995-f2be-cf9b-51dddd2eb3d9@ericsson.com>
In-Reply-To: <7d46a4cf-a995-f2be-cf9b-51dddd2eb3d9@ericsson.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.238.21.34]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Sentrion-Hostname: mailusrhubprd04.lss.emc.com
X-RSA-Classifications: public
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/6btByxS9tKNZH4JsY3qyUi49lXY>
Subject: Re: [Tsv-art] Tsvart telechat review of draft-ietf-6man-rfc6434-bis-08
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Jul 2018 19:50:11 -0000

Separate comment on this text:

> B. Section 5.12:
> 
>     Nodes that may be deployed in environments where they would benefit
>     from such early congestion notification SHOULD implement [RFC3168].
>     In such cases, the updates presented in [RFC8311] may also be
>     relevant.

For the most part characterizing RFC 8311 as "may also be relevant" is ok,
as that RFC's primary purpose is to enable experiments.

There is one exception that deserves to be called out from Section 2.2
of RFC 8311 (https://tools.ietf.org/html/rfc8311#section-2.2): 

   3.  A network node MUST NOT originate traffic marked with ECT(1)
       unless the network node is participating in a Congestion Marking
       Differences experiment that uses ECT(1), as specified in
       Section 4.2 below.

That's a mandatory change.

Thanks, --David

> -----Original Message-----
> From: Tsv-art [mailto:tsv-art-bounces@ietf.org] On Behalf Of Magnus
> Westerlund
> Sent: Wednesday, July 4, 2018 3:40 AM
> To: Brian E Carpenter; tsv-art@ietf.org
> Cc: draft-ietf-6man-rfc6434-bis.all@ietf.org; ipv6@ietf.org
> Subject: Re: [Tsv-art] Tsvart telechat review of draft-ietf-6man-rfc6434-bis-08
> 
> Hi,
> 
> Thanks for the rapid response.
> 
> 
> Den 2018-07-03 kl. 22:48, skrev Brian E Carpenter:
> > Hi Magnus,
> > On 04/07/2018 02:45, Magnus Westerlund wrote:
> >> Reviewer: Magnus Westerlund
> >> Review result: Ready with Issues
> >>
> >> I've reviewed this document as part of the transport area directorate's ongoing
> >> effort to review key IETF documents. These comments were written primarily for
> >> the transport area directors, but are copied to the document's authors for
> >> their information and to allow them to address any issues raised.
> >> When done at the time of IETF Last Call, the authors should consider this
> >> review together with any other last-call comments they receive.
> >> Please always CC tsv-art@ietf.org if you reply to or forward this review.
> >>
> >> I have focused on the transport aspects of these node requirements and have two
> >> things I would like to flag that should be considered to be addressed.
> >>
> >> A. Section 5.7.1:
> >>
> >> Path MTU Discovery relies on ICMPv6 Packet Too
> >>     Big (PTB) to determine the MTU of the path (and thus these should not
> >>     be filtered, as per the recommendation in [RFC4890]).
> >>
> >> Considering that RFC 4890 recommendation for PTB is "Traffic That Must Not Be
> >> Dropped". I think using "should not" is weaking the recommendation.
> > Interesting point. This is a lower case "should" so actually I don't think
> > it is really a weakening, but by the same argument "must not" is OK too.
> 
> So, I don't consider it a major weakening, but non the less "must not"
> is stricter than "should not".
> 
> >
> >> B. Section 5.12:
> >>
> >>     Nodes that may be deployed in environments where they would benefit
> >>     from such early congestion notification SHOULD implement [RFC3168].
> >>     In such cases, the updates presented in [RFC8311] may also be
> >>     relevant.
> >>
> >> Why isn't this a MUST? A IPv6 node has no way of determining if it is has
> >> connectivity that will actively mark with ECN-CE.
> > I think the problem in that sentence is the "may be deployed..." clause.
> > The implementer of a stack can't possibly know that. So why not reduce it
> > to:
> >     Nodes SHOULD implement [RFC3168].
> > In RFC2119 terms that's fine, since it simply says "do this unless you
> > have a good reason not to."
> 
> I wished I had reviewed this earlier (during the WG process) because I
> think ECN is so stable and mature with a small implementation burden
> from the IP layer that it really should be mandated to implement. At the
> same time I do realize that a stack that simply ignores the bits and
> sets them to 00 on outgoing IPv6 packets are fully interoperable so that
> this is not an argument for mandating implementation. But, I really
> wanted to flag this for the ADs. From my perspective the SHOULD is the
> minimal level ECN should be required to be implemented at, and I had
> hoped for a MUST. And I think the only one that has a reason not to
> implement ECN in the IP layer are low performance minimal footprint
> implementation.
> 
> Cheers
> 
> Magnus Westerlund
> 
> ----------------------------------------------------------------------
> Network Architecture & Protocols, Ericsson Research
> ----------------------------------------------------------------------
> Ericsson AB                 | Phone  +46 10 7148287
> Torshamnsgatan 23           | Mobile +46 73 0949079
> SE-164 80 Stockholm, Sweden | mailto: magnus.westerlund@ericsson.com
> ----------------------------------------------------------------------
> 
> _______________________________________________
> Tsv-art mailing list
> Tsv-art@ietf.org
> https://www.ietf.org/mailman/listinfo/tsv-art