Re: [Tsv-art] [Last-Call] Tsvart last call review of draft-ietf-mpls-rmr-12

Colin Perkins <csp@csperkins.org> Sun, 04 October 2020 08:45 UTC

Return-Path: <csp@csperkins.org>
X-Original-To: tsv-art@ietfa.amsl.com
Delivered-To: tsv-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9CDDE3A1312; Sun, 4 Oct 2020 01:45:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=csperkins.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EQFdUI8J3idL; Sun, 4 Oct 2020 01:44:58 -0700 (PDT)
Received: from haggis.mythic-beasts.com (haggis.mythic-beasts.com [IPv6:2a00:1098:0:86:1000:0:2:1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1FB633A1310; Sun, 4 Oct 2020 01:44:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=csperkins.org; s=mythic-beasts-k1; h=To:Date:Subject:From; bh=BFllCOL8u5m39IHYBogytPTvza+C2xIT3aVJZPWdmzg=; b=LHGiP3/MEnXvJqUdCEGMJXC5N6 EJo2D4EgczA7lHxNA8tpfp3SX/71hhLFikUA1NpyYAYbitni74mdgtikIZPITdV6Zn+1KjSRjT710 5LKtGxVmMN0UpU3EgDfDhLU/7LQrdLruLeRSPVc0vJDiTuCHovREDicY91i8g4PuUhEXSkc0dvqXt GbGgxomYqL0PKp+2dmtn3B7KxybVN2NzrO1Dk4HqGKwZqd+KTOkWjOkjA7ihd7uowFr2Am0r/nvoy r9ZVP4pbZv8AlSc9PQf3qC3NKiXOEWN92Z6sGSy+weTPCD9ZJgCRCzncWm+OH7dpfhGLI9HKbVNwE dyqRqlMw==;
Received: from [81.187.2.149] (port=45842 helo=[192.168.0.67]) by haggis.mythic-beasts.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from <csp@csperkins.org>) id 1kOzdX-0002RZ-Vw; Sun, 04 Oct 2020 09:44:56 +0100
From: Colin Perkins <csp@csperkins.org>
Message-Id: <D9FA1A91-E5F9-49F3-ADB2-13EDBAAB5C49@csperkins.org>
Content-Type: multipart/alternative; boundary="Apple-Mail=_AFA77298-BC5E-4643-96AA-AECB41A6233A"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\))
Date: Sun, 4 Oct 2020 09:44:50 +0100
In-Reply-To: <CABRz93UuKp65mdEUCBJFs4BczJYF95VPUuHuS45qwcBzCzjDOA@mail.gmail.com>
Cc: draft-ietf-mpls-rmr.all@ietf.org, tsv-art@ietf.org, mpls@ietf.org, last-call@ietf.org
To: Kireeti Kompella <kireeti.kompella@gmail.com>
References: <157299662261.4537.207640958778372329@ietfa.amsl.com> <CABRz93UuKp65mdEUCBJFs4BczJYF95VPUuHuS45qwcBzCzjDOA@mail.gmail.com>
X-Mailer: Apple Mail (2.3445.104.17)
X-BlackCat-Spam-Score: 4
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/7GqR69cjvwDhHTZFKAOY1-HhgrM>
Subject: Re: [Tsv-art] [Last-Call] Tsvart last call review of draft-ietf-mpls-rmr-12
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Oct 2020 08:45:01 -0000

Hi Kireeti,

Apologies for not following-up on this earlier myself. These changes look to address my concerns. 

Colin




> On 16 Sep 2020, at 15:52, Kireeti Kompella <kireeti.kompella@gmail.com> wrote:
> 
> Hi Colin,
> 
> Sorry for the very belated response!
> 
> Thank you for your review.  All of your comments have been addressed in the -13 update; section 1.2 has a summary of the changes, marked with [TAR] for the Transport Area Review.  Section 4.2 has updated text on timers; unfortunately, there are two typos here: one, this change was made in response to TAR, not SAD; two, the actual change was duplicated.  Section 5 defers the value of the OAM timer to the OAM protocol being used.
> 
> The nits in section 1 & 1.1 have also been fixed.
> 
> Hopefully, all your concerns have been addressed.
> 
> Cheers,
> Kireeti.
> 
> 
> On Tue, Nov 5, 2019 at 3:30 PM Colin Perkins via Datatracker <noreply@ietf.org <mailto:noreply@ietf.org>> wrote:
> Reviewer: Colin Perkins
> Review result: Almost Ready
> 
> This document has been reviewed as part of the transport area review team's
> ongoing effort to review key IETF documents. These comments were written
> primarily for the transport area directors, but are copied to the document's
> authors and WG to allow them to address any issues raised and also to the IETF
> discussion list for information.
> 
> When done at the time of IETF Last Call, the authors should consider this
> review as part of the last-call comments they receive. Please always CC
> tsv-art@ietf.org <mailto:tsv-art@ietf.org> if you reply to or forward this review.
> 
> The draft describes how MPLS can be used to configure ring topologies,
> as is frequently used to provide resilience. This seems like a reasonable
> thing to do - indeed I'm surprised such a specification doesn't already
> exist. From a transport perspective, this looks reasonable, but I do have
> some comments:
> 
> - The draft discusses resilience mechanisms, by which the ring can be
> used to protect from link failures. There is, however, no discussion of
> how to recover from loss of the various messages used to announce and
> manage the ring network. It may be that the protocol used to convey
> these messages provides appropriate reliability mechanisms and the
> draft just needs to reference and clarify that. However, if not, it would
> seem worth considering robustness to loss of the ring advertisement
> and maintenance messages.
> 
> - Auto-discovery in Section 4 uses timers T1 and T2. It's not clear what
> is the timeout value for these timers, and whether their value needs to
> be statically chosen or somehow tuned based on the size of the network. 
> 
> - Similarly, Section 5 on Ring OAM specifies two timers. These have fixed
> values of 3.3ms and 1s. It's not clear why these values were chosen or why
> they are correct.
> 
> Nits:
> - The Introduction talks about "transport networks". It's not clear what
> is meant by this, and there might be an alternative term that's clearer.
> 
> - The last paragraph before Section 1.1 states: “The intent is not to
>  construct rings in a mesh network,  and use those for protection”. I
> can’t parse the grammar here – can you clarify?
> 
> 
> 
> 
> -- 
> Kireeti
> -- 
> last-call mailing list
> last-call@ietf.org
> https://www.ietf.org/mailman/listinfo/last-call