Re: [Tsv-art] Tsvart last call review of draft-ietf-6lo-minimal-fragment-07

"Pascal Thubert (pthubert)" <pthubert@cisco.com> Thu, 30 January 2020 11:02 UTC

Return-Path: <pthubert@cisco.com>
X-Original-To: tsv-art@ietfa.amsl.com
Delivered-To: tsv-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 836D612012E; Thu, 30 Jan 2020 03:02:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=BU7kZD2N; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=ARftX/3S
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O2lz2iLNJzPO; Thu, 30 Jan 2020 03:02:22 -0800 (PST)
Received: from rcdn-iport-1.cisco.com (rcdn-iport-1.cisco.com [173.37.86.72]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 99F3812012D; Thu, 30 Jan 2020 03:02:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2924; q=dns/txt; s=iport; t=1580382142; x=1581591742; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=idoChGNGu758LuNiPYOEdvYhIyKVz+CBy6QPhglu+RQ=; b=BU7kZD2N63of4wBTZEgVV807EEOAuqg7j+wqg0zhyrXgO2as3cu2amd9 Y1uqQRvM2oaDqIMrSuWJQYsImbFtmhLGQptSahMVSQz2wlLjPUd2Ub9kY LIMm761Gn2ofYNCu5+bCJVOvOFdwJA5O52ktY25WHn0p/9OoC16mQ3vmr Q=;
IronPort-PHdr: =?us-ascii?q?9a23=3AQdoOhxwvlf6k12HXCy+N+z0EezQntrPoPwUc9p?= =?us-ascii?q?sgjfdUf7+++4j5YhWN/u1j2VnOW4iTq+lJjebbqejBYSQB+t7A1RJKa5lQT1?= =?us-ascii?q?kAgMQSkRYnBZudFU3mJvPwcwQxHd9JUxlu+HToeUU=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0DVCQDCtjJe/51dJa1mHgELHINPUAW?= =?us-ascii?q?BRCAECyoKhAqDRgOKc4JfmA+CUgNUCQEBAQwBAS0CAQGEQAIXghUkOBMCAw0?= =?us-ascii?q?BAQQBAQECAQUEbYU3DIVeAQEBAQIBEhEEDQwBATcBBAsCAQYCDgwCJgICAjA?= =?us-ascii?q?VEAIEAQ0NGoVPAw4gAQIBkBiQZgKBOYhidX8zgn8BAQWFDhiCDAmBDiqJV4J?= =?us-ascii?q?JGoFBP4ERR4FOfj6ES4MOMoIskFWPVY80CoI5llWCSIgLi2iERY5gmxICBAI?= =?us-ascii?q?EBQIOAQEFgWkigVhwFTuCbFAYDY4dDBeDUIpTdIEpi3ABgQ8BAQ?=
X-IronPort-AV: E=Sophos;i="5.70,381,1574121600"; d="scan'208";a="706746006"
Received: from rcdn-core-6.cisco.com ([173.37.93.157]) by rcdn-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 30 Jan 2020 11:02:21 +0000
Received: from XCH-ALN-006.cisco.com (xch-aln-006.cisco.com [173.36.7.16]) by rcdn-core-6.cisco.com (8.15.2/8.15.2) with ESMTPS id 00UB2Lds008137 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 30 Jan 2020 11:02:21 GMT
Received: from xhs-rcd-002.cisco.com (173.37.227.247) by XCH-ALN-006.cisco.com (173.36.7.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 30 Jan 2020 05:02:20 -0600
Received: from xhs-aln-003.cisco.com (173.37.135.120) by xhs-rcd-002.cisco.com (173.37.227.247) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 30 Jan 2020 05:02:18 -0600
Received: from NAM10-MW2-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-003.cisco.com (173.37.135.120) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 30 Jan 2020 05:02:18 -0600
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TYC5WpmfKXrtWouXE15TxZgQRKH0Znl0ZzJolgV8B0mjYa/pHIbGRuI6o3ePI2vcOcxpWsfNqc/XlBCGx0wRaxRSNOmfUFhd3XBvycbc8Kkx6wHFfRhQNOenIqpE0r+8ju05WCn4hZBWnYXTgNNiWKs0mvnYAeuaPxjlnzEZvQxgioB+CsV1lNPUl/TVOP56uWAgcfL/jRAK0rcMAvzmJjFqjElBXCKqpJHyl3DwJWUvNdQcg0ioGtCHcH/YcIIYiuLlQtDpaOr5zZMjGvlPmSzKqgejp3GeJfpGPhFzjewWVXq4aYyM+rIVWkcR+UEHMFDniHvsC5XLvwTqzF1Lfw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=idoChGNGu758LuNiPYOEdvYhIyKVz+CBy6QPhglu+RQ=; b=K3LHr/M9lEgG1feuIeEzwNLz5LknkhlLzfrtex4QJkMseJHf3HncTt7SpYpresRRoVjHpXGIkf94dMaSHpt1aEn/y+U1rBIr6TESP8RGQG933qassFHNYX1DOBoRq4bosTymcxsb7CyELumOQxxZ91HbqkC/HN6cjGsm1ckOpzAKNpFNORn/PftBpOqMx2kWr8sbAvIyPozfWNMoctX1gAuxzg9kO+FwniQnBizB3FzgDTi8JgcYxwtPR//ISVjMSbYzctwQXnkiiUxI8h7r/C9FSIU/bmAwSvKujBil03n2I1Ovf3yNBOKeXp9IDI9ZNYEJTdKQVzoubeOb6NgVSQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=idoChGNGu758LuNiPYOEdvYhIyKVz+CBy6QPhglu+RQ=; b=ARftX/3S+H77dNnOgKUu1YZptwtDCtsrB9Mwl6VWEWL8wC7pIoHRd47v9yYOqb8oslqpte9KHvOCwJJrw0lG+rTeegHFYgMziArCeFwDBTIWgAH+vOsQrOezftDoS8ywA9IdFlZi1mTLTgHJiTX5HaeMcD3IJZkelID39WAZ90k=
Received: from MN2PR11MB3565.namprd11.prod.outlook.com (20.178.250.159) by MN2SPR01MB0010.namprd11.prod.outlook.com (20.179.86.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.27; Thu, 30 Jan 2020 11:02:17 +0000
Received: from MN2PR11MB3565.namprd11.prod.outlook.com ([fe80::fd76:1534:4f9a:452a]) by MN2PR11MB3565.namprd11.prod.outlook.com ([fe80::fd76:1534:4f9a:452a%3]) with mapi id 15.20.2665.027; Thu, 30 Jan 2020 11:02:17 +0000
From: "Pascal Thubert (pthubert)" <pthubert@cisco.com>
To: Joerg Ott <jo@acm.org>, "tsv-art@ietf.org" <tsv-art@ietf.org>
CC: "draft-ietf-6lo-minimal-fragment.all@ietf.org" <draft-ietf-6lo-minimal-fragment.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "6lo@ietf.org" <6lo@ietf.org>
Thread-Topic: Tsvart last call review of draft-ietf-6lo-minimal-fragment-07
Thread-Index: AQHV11GUC085zmGcAkicl7qtzeAtLqgDAPtQ
Date: Thu, 30 Jan 2020 11:01:54 +0000
Deferred-Delivery: Thu, 30 Jan 2020 11:01:39 +0000
Message-ID: <MN2PR11MB3565E7C6948978B820FF95C1D8040@MN2PR11MB3565.namprd11.prod.outlook.com>
References: <158037733663.10174.9948288306890965922@ietfa.amsl.com>
In-Reply-To: <158037733663.10174.9948288306890965922@ietfa.amsl.com>
Accept-Language: fr-FR, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=pthubert@cisco.com;
x-originating-ip: [2.15.172.153]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2a1f8f09-ca96-4a50-cc24-08d7a573df11
x-ms-traffictypediagnostic: MN2SPR01MB0010:
x-microsoft-antispam-prvs: <MN2SPR01MB00109CD779CC783FB841EB1AD8040@MN2SPR01MB0010.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 02981BE340
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(396003)(39860400002)(346002)(136003)(366004)(189003)(199004)(26005)(9686003)(71200400001)(186003)(4326008)(2906002)(81166006)(81156014)(316002)(7696005)(478600001)(8936002)(110136005)(8676002)(54906003)(55016002)(33656002)(6666004)(5660300002)(6506007)(66446008)(52536014)(86362001)(76116006)(66556008)(64756008)(66476007)(66946007); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2SPR01MB0010; H:MN2PR11MB3565.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 5s0yIJ151ENF2EbXUfQmoarRrJ/h14NstgSO9ndvwzRbAltX6Re5Mp7ne8d+gLgjpd7PwLyKm4ogiJjswFqgn3NsqgwHIVD7D5g1TAWajuLwIs9kjQRgEz3kbPhEGa/UhRLom5VY+NNvyc8dXtUNCfwifHD2BP8POik5hjIEUjPLS4gdxBE7DxV/Q5LZUz/COP5HQ/G12K8DvkEc6QqjMZ48IfnJOHxJKc847FjnmECkXRsizFG3ZRCM1Wb0JGMSwKtJiEhQq7C6n3Jt5dru019NrcGH71stOSRQX1xn5oWK5paGJL8GtwLEtR63WniCgfNaCDMYRuEuXprGjFTaSyN4Tw+DtUUjAK1MRKUrwSfurEmAJnv2qPdIOU1DgnwnNmt/+h49JDAswTBMqhKWi9D3dunKh/7OTNWgi0PBwtuxZ7EVcoRFzP7hkljYs/od
x-ms-exchange-antispam-messagedata: 17qw2Rr9a+nmTGHQigEQsMY2yrBE9R8Q9N/IUexrJ15elptbwUth7yT/1eCt2fyqa0lS1+XBGhTmc7CE27gIxcgoUdx6HoMoef/0q71tTJa7HLVR0Sa4qeYcLUHpEWlB9Zzm/gypEMS76aUsTJETJw==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a1f8f09-ca96-4a50-cc24-08d7a573df11
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2020 11:02:17.7472 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /gsPOwMN/SBWAHRNDknKdLwL8ZScSLG1l6kRkW07xiwiFxmGE8xgV6x/nwmVMruUPSQNMOp/JP0YtbtaKo3t9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2SPR01MB0010
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.16, xch-aln-006.cisco.com
X-Outbound-Node: rcdn-core-6.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/8O4eb_Z6f32JzwQx-vr-HxWaAhU>
Subject: Re: [Tsv-art] Tsvart last call review of draft-ietf-6lo-minimal-fragment-07
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jan 2020 11:02:25 -0000

Many thanks Joerg!

Please see below:

> Generally, the document is in good state and almost ready to publish. A few
> nits, one on protocol state management below:
> 
> Nits:
> 
> The text uses both "6lo fragments" and "6LoWPAN fragments".

Changed to 6LoWPAN fragments everywhere


> 
> Section 5, end of 1st para:
> "Since the datagram_tag is uniquely associated to the source Link-Layer
> address of the fragment, the forwarding node MUST assign a new
> datagram_tag from its own namespace for the next hop and rewrite the
> fragment header of each fragment with that datagram_tag."
> 
> This sentence is correct but it comes after the description of handling
> subsequent fragments, rather than the first one, and subsequent ones should,
> of course, not receive a new datagram_tag. Maybe move the sentence further
> up or make explicit reference to the first fragment.

Great point, moved up.

> 
> Sect. 5, bullet list, "* a datagram_size"
> Just as a remark, this does not seem to be used. It *could* be used to check if
> a fragment beyond the end of the packet arrives, but has otherwise no
> (documented) meaning. The draft should spell out its purpose.

Since we did not use it the simplest is to remove it 😊

> 
> Sect. 5, bullet list, "a timer that allows discarding the stale FF state after some
> timeout"
> Surely needed, but no advice is given. There is generally no explicit statement
> when to discard the state. What should an implementation do to interoperate,
> given that upstream multiplexing of packet fragments from multiple sources
> can yield diverse intervals between consecutive fragments? Would this be the
> same timer previously used for reassembly? If so, maybe just state this.

Great point again! Does the below work, added to the bullet?
"
The duration of the timer should be longer than that which covers the reassembly at the receiving end point. 
"

> 
> Sect. 7, 2nd bullet: "attck" -> "attack"
> 

Fixed!


Many thanks again, Joerg. I posted 09 with the above. Please let me know if we are OK?

All the best

Pascal