Re: [Tsv-art] Tsvart last call review of draft-ietf-detnet-data-plane-framework-04

Balázs Varga A <balazs.a.varga@ericsson.com> Wed, 15 April 2020 15:10 UTC

Return-Path: <balazs.a.varga@ericsson.com>
X-Original-To: tsv-art@ietfa.amsl.com
Delivered-To: tsv-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E602E3A0A0F; Wed, 15 Apr 2020 08:10:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.268
X-Spam-Level:
X-Spam-Status: No, score=-2.268 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.168, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dY8VMI59PSYX; Wed, 15 Apr 2020 08:10:32 -0700 (PDT)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2068.outbound.protection.outlook.com [40.107.22.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 471423A0861; Wed, 15 Apr 2020 08:10:32 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NaZA6uWrDlKtR6jhozRaxmSIF9QEdI+aqk1IQOCrcp4E9PClD0waEooaEngjIGLy/s6nWdfwWUQIWN3ycg+qf7bcw5zA+JbdLv8DHTDyS8ytvoLOLZqwDXU2WY84F/gafHQwZbdi2IgEooCd1M7I9G7IpQMtwM0F0dHCIttKNw5yi7aZwuy/JiXXcRcjCF1ubP4PeHeooTaIuvUiRY0F+hdDdXP5SZ63elam3YNHWbSeB1nQQLODagX5JTiDxcm5axCQR+IgAOhAKG6pd76Z3gRGXdb585jXIzlAWNkSZOD9G0nRSslaQCm3LIymeGXKLOXGle72gCU/oTrPxjhNLw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bmvJ7PMyZeSAvPdUQ6cVShSSyNkbWI3oFu3CskjbMt4=; b=STNYFaokXoESIJdxDuzck9zEw/lyeGicmQKj+0jwxkYMgMLNykWyiSBpBLinv61yyaLKdKrr42t0H76UVs4HBTxaRizsm6LpRiYbRDHVpDQgOGH//3vwWCk5m01rSED6hEEzpEV8i2014iJwZATHdxSPOCag7WFFv2oR/Yxe6H5LWihs2x5tn84gCaougQ+VwyjS5CUvqLe6daU0UdwwltAyi7p0njrMdgIdhba2dGVoXK4JMNHVhQbhJUUNBqdMNRgGd0fCgMrGp/cNJ3JJ2auNub3oqfE5J/VjkYCXIeHrFeksFTa63Rn3Xq1dCJGLt665XFx+2C6C01BVbi6TFg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bmvJ7PMyZeSAvPdUQ6cVShSSyNkbWI3oFu3CskjbMt4=; b=rc4FlHHT9E1EZeKWK9OB6p69pgJ5RcciDa5tO0ahA6UeHTsN3HvfsjPm18+vFFUSR564+/BcmRYfCz0PoJDzACj+hAM6VQlH4gIecKVV7vOYFbue9jj/i3faCKinrXq0yH3o0TEEIQIg3s1PAHz+KI0qZTI0G0ahB12cC8YRraU=
Received: from AM0PR0702MB3603.eurprd07.prod.outlook.com (2603:10a6:208:22::25) by AM0PR0702MB3636.eurprd07.prod.outlook.com (2603:10a6:208:1d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.20; Wed, 15 Apr 2020 15:10:30 +0000
Received: from AM0PR0702MB3603.eurprd07.prod.outlook.com ([fe80::9c11:1589:8e18:5209]) by AM0PR0702MB3603.eurprd07.prod.outlook.com ([fe80::9c11:1589:8e18:5209%3]) with mapi id 15.20.2921.024; Wed, 15 Apr 2020 15:10:29 +0000
From: =?utf-8?B?QmFsw6F6cyBWYXJnYSBB?= <balazs.a.varga@ericsson.com>
To: Yoshifumi Nishida <nsd.ietf@gmail.com>, "tsv-art@ietf.org" <tsv-art@ietf.org>
CC: "last-call@ietf.org" <last-call@ietf.org>, "detnet@ietf.org" <detnet@ietf.org>, "draft-ietf-detnet-data-plane-framework.all@ietf.org" <draft-ietf-detnet-data-plane-framework.all@ietf.org>
Thread-Topic: Tsvart last call review of draft-ietf-detnet-data-plane-framework-04
Thread-Index: AQHWDLqd4XP9u62kHU2O8H+yfGcg9ah6UV/g
Date: Wed, 15 Apr 2020 15:10:29 +0000
Message-ID: <AM0PR0702MB3603A74841E553B7BCA636C1ACDB0@AM0PR0702MB3603.eurprd07.prod.outlook.com>
References: <158624986177.7879.15272885885261397703@ietfa.amsl.com>
In-Reply-To: <158624986177.7879.15272885885261397703@ietfa.amsl.com>
Accept-Language: hu-HU, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=balazs.a.varga@ericsson.com;
x-originating-ip: [188.143.71.76]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: dee22a05-e322-4af1-e66b-08d7e14f22d1
x-ms-traffictypediagnostic: AM0PR0702MB3636:
x-microsoft-antispam-prvs: <AM0PR0702MB36369677824C9A17421335B8ACDB0@AM0PR0702MB3636.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 0374433C81
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0702MB3603.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(396003)(376002)(346002)(136003)(366004)(39860400002)(186003)(316002)(53546011)(6506007)(7696005)(76116006)(66556008)(33656002)(71200400001)(66476007)(54906003)(66446008)(4326008)(66946007)(64756008)(110136005)(86362001)(26005)(966005)(81156014)(55016002)(85202003)(52536014)(9686003)(85182001)(8676002)(8936002)(478600001)(5660300002)(2906002); DIR:OUT; SFP:1101;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: d+x9LMlp7ecEVfmVzF7H4uSM4pdXim6o5aNypgL1LG5EGwsS8zdGTcjfPFOXflXrX4X4b7ak2J/ZqSUpjKFHOnvwFLCHEWWd40fIWgDH04oWT4Q2QqLazIWLKJ02SzWjxq0M3NI9fKr7d5tLSk+FJ8eZIoimD/DPaEAR117RyKpAXaVDyfzMZqC2QqTPG4GVyyhaS+DZDUR92Jxw1ZWrmGXlmAXBOLUkfhNc6kWTBSozeOPqvMVpishly4sLOvJ7E+SXaP/HxQk9JsDK/cG7PnTvV2yVYiyVXOGeE+EMKen9hS4pUhfPudQVpggiKSsyrazLUb+gBQkKgpt6SRab+CPPhHQVjPBhQxND0yomnxM7F6diRcwHCuEBKKHbIExPXrZs9tv1Mh1WL2jGPIOi7wY9X3kb+T4jV1mGPCzQJoFqMlcUH/7tcgzUmghUE/7pbdEBja1nN7a6gL8NS53CklYEkEYRAbhcPFKSiG+lyb2AvIK6LYTJZ4mdd3zPkSFoFwWBaovU66cECjCcpbAhuw==
x-ms-exchange-antispam-messagedata: Ua1l3NotT7nSYBMbUPr28CbhcecYCjGGvVO0xvBDvqeJ3ACtk/FBR0dhLpXieMbrx7lrNg1qiWp2leAaIiRmGqrh6mYXS5gAN0z57gmRA8IlFR5YYIUoJwmkHwA4GZ4CTe1rfHsdURaXOvDAeIENVQ==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dee22a05-e322-4af1-e66b-08d7e14f22d1
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2020 15:10:29.8002 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ccDjEO/nPZjBsa7uOMkwLmsuQmoY/Zn88pB018hOysKZ+8VjGH4fSJtC9KcSJz7EUbBQFPhKkF87a2/Q3E4uqa165aZSalYKUVHKqBZLixM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0702MB3636
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/2Itb9MoJV57uKyClQSugOTESIzE>
Subject: Re: [Tsv-art] Tsvart last call review of draft-ietf-detnet-data-plane-framework-04
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Apr 2020 15:10:34 -0000

Hi Yoshi,

Many thanks for the review.
Regarding your comment on "conflict of the flow ID or wrap-around of the sequence number".
Yes, these are important aspects in DetNet.

Yes, flow ID must be unique in order to identify packets belonging to the DetNet flow. 
This must be ensured by the control and/or management plane. DetNet WG was re-chartered 
recently to focus on these planes as well. In data plane drafts we have dedicated a section
to collect " Controller Plane (Management and Control) Considerations".

Regarding sequence number, wrap-around events are flow characteristics and network 
dependent. The data plane technology specific documents ensures that the sequence number 
space does not wrap whilst packets are in flight ( see Section 4.1. and 4.2.1 in 
https://datatracker.ietf.org/doc/draft-ietf-detnet-mpls ).

I hope that clarifies your comments.

Many Thanks
Bala'zs

-----Original Message-----
From: Yoshifumi Nishida via Datatracker <noreply@ietf.org> 
Sent: Tuesday, April 7, 2020 10:58 AM
To: tsv-art@ietf.org
Cc: last-call@ietf.org; detnet@ietf.org; draft-ietf-detnet-data-plane-framework.all@ietf.org
Subject: Tsvart last call review of draft-ietf-detnet-data-plane-framework-04

Reviewer: Yoshifumi Nishida
Review result: Ready with Nits

This document has been reviewed as part of the transport area review team's ongoing effort to review key IETF documents. These comments were written primarily for the transport area directors, but are copied to the document's authors and WG to allow them to address any issues raised and also to the IETF discussion list for information.

When done at the time of IETF Last Call, the authors should consider this review as part of the last-call comments they receive. Please always CC tsv-art@ietf.org if you reply to or forward this review.

Summary: Ready with Nits.

This document is well-written as an informational RFC. I don't see any technical issues related to transport, but it might be better to clarify the following minor point.

The draft allows DetNet data plane to carry flow ID and sequence number as metadata. But, aren't there any potential risks for the conflict of the flow ID or wrap-around of the sequence number? (especially for explicit case) It might be better to state which module should care if it's out of scope for the draft or to clarify there is no risk against them.

Thanks,
--
Yoshi