[Tsv-art] Tsvart last call review of draft-ietf-httpbis-proxy-status-05

Magnus Westerlund via Datatracker <noreply@ietf.org> Wed, 04 August 2021 08:48 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: tsv-art@ietf.org
Delivered-To: tsv-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id D716B3A0ED7; Wed, 4 Aug 2021 01:48:08 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Magnus Westerlund via Datatracker <noreply@ietf.org>
To: tsv-art@ietf.org
Cc: draft-ietf-httpbis-proxy-status.all@ietf.org, ietf-http-wg@w3.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.35.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <162806688882.17375.7880634816418241367@ietfa.amsl.com>
Reply-To: Magnus Westerlund <magnus.westerlund@ericsson.com>
Date: Wed, 04 Aug 2021 01:48:08 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/ehy-Grde1Cuxyo_H8QIHEK-byhM>
Subject: [Tsv-art] Tsvart last call review of draft-ietf-httpbis-proxy-status-05
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Aug 2021 08:48:09 -0000

Reviewer: Magnus Westerlund
Review result: Ready with Issues

This document has been reviewed as part of the transport area review team's
ongoing effort to review key IETF documents. These comments were written
primarily for the transport area directors, but are copied to the document's
authors and WG to allow them to address any issues raised and also to the IETF
discussion list for information.

When done at the time of IETF Last Call, the authors should consider this
review as part of the last-call comments they receive. Please always CC
tsv-art@ietf.org if you reply to or forward this review.

I found not transport related issues, only some clarity issues related to extra
parameters and their registration.

1. Section 2:
Depending on the deployment, this might be a product or service name (e.g.,
ExampleProxy or "Example CDN"), a hostname ("proxy-3.example.com"), an IP
address, or a generated string.

Is really an IP address a good identifier for intermediary? Or is the case that
there some that doesn't have a better identity than its IP? And should there be
additional security considerations about including IP addresses in the header?

2. Section 2.1.1:

Proxy Error Types can also define any number of extra parameters for use with
that type. Their use, like all parameters, is optional. As a result, if an
extra parameter is used with a Proxy Error Type for which it is not defined, it
will be ignored.

It is not obvious how these extra parameters are to be encoded.

If we take the example of DNS Error, how would that look like in an example?

HTTP/1.1 502 Bad Gateway
Proxy-Status: SomeReverseProxy; error=dns_error; rcode="123 something";
info-code=3454

Can you please clarify this aspect?

3. Section 3:

Shouldn't the extra parameters in Section 2.3 be registered in the HTTP
Proxy-Status Parameters registry? If not can you clarify how they are handled?

Cheers

Magnus Westerlund