[Tsv-art] Tsvart last call review of draft-ietf-lpwan-schc-compound-ack-14

Wesley Eddy via Datatracker <noreply@ietf.org> Tue, 14 March 2023 15:13 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: tsv-art@ietf.org
Delivered-To: tsv-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 3444AC13737D; Tue, 14 Mar 2023 08:13:40 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Wesley Eddy via Datatracker <noreply@ietf.org>
To: tsv-art@ietf.org
Cc: draft-ietf-lpwan-schc-compound-ack.all@ietf.org, last-call@ietf.org, lp-wan@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 9.14.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <167880682020.62833.11164576152796174950@ietfa.amsl.com>
Reply-To: Wesley Eddy <wes@mti-systems.com>
Date: Tue, 14 Mar 2023 08:13:40 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/evwnTneO8EbPhl66pStSjh6nl5s>
Subject: [Tsv-art] Tsvart last call review of draft-ietf-lpwan-schc-compound-ack-14
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Mar 2023 15:13:40 -0000

Reviewer: Wesley Eddy
Review result: Ready with Nits

This document has been reviewed as part of the transport area review team's
ongoing effort to review key IETF documents. These comments were written
primarily for the transport area directors, but are copied to the document's
authors and WG to allow them to address any issues raised and also to the IETF
discussion list for information.

When done at the time of IETF Last Call, the authors should consider this
review as part of the last-call comments they receive. Please always CC
tsv-art@ietf.org if you reply to or forward this review.

In general, the document seems to be clear and well written.  I did not find
any technical issues or corrections to note.

Comments:
- The reason for using this is explained as reducing the number of ACK
transmissions.  Is there a corresponding cost (e.g. slower recovery from
losses) that should also be mentioned so that the tradeoffs are clear? - The
shepherd writeup mentions a Sigfox implementation.  It would be of interest to
note whether compound ACKs have been found to be beneficial in practice or note
any quantification of the expected benefits.  Of course these are heavily
dependent on the specific LPWAN and configuration, so it would just be
anecdotal data. - There are older RFCs from the PILC working group that provide
advice for subnetwork design (e.g. RFC 3819).  I was surprised not to find that
cited here as a reference, as it might be important regarding tuning of
configuration parameters.

Very minor comments:
- Section 4 has "Examples" (plural) in the title, however, it really only
contains a single example.  It could be "Example" instead.